* [PATCH] Revised PSP comments @ 2018-10-16 22:47 John Clements [not found] ` <20181016224754.4105-1-clements.jm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: John Clements @ 2018-10-16 22:47 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: John Clements From: John Clements <clements.jm@gmail.com> Revised comments in PSP SOS/Sysdriver loading sequence Signed-off-by: John Clements <clements.jm@gmail.com> --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c index b70cfa3fe1b2..3fe30eb46d26 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c @@ -167,7 +167,7 @@ static int psp_v11_0_bootloader_load_sysdrv(struct psp_context *psp) /* Copy PSP System Driver binary to memory */ memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); - /* Provide the sys driver to bootrom */ + /* Provide the sys driver to bootloader */ WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, (uint32_t)(psp->fw_pri_mc_addr >> 20)); psp_gfxdrv_command_reg = 1 << 16; @@ -208,7 +208,7 @@ static int psp_v11_0_bootloader_load_sos(struct psp_context *psp) /* Copy Secure OS binary to PSP memory */ memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); - /* Provide the PSP secure OS to bootrom */ + /* Provide the PSP secure OS to bootloader */ WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, (uint32_t)(psp->fw_pri_mc_addr >> 20)); psp_gfxdrv_command_reg = 2 << 16; diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c index e1ebf770c303..9cea0bbe4525 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c @@ -194,7 +194,7 @@ static int psp_v3_1_bootloader_load_sysdrv(struct psp_context *psp) /* Copy PSP System Driver binary to memory */ memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); - /* Provide the sys driver to bootrom */ + /* Provide the sys driver to bootloader */ WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, (uint32_t)(psp->fw_pri_mc_addr >> 20)); psp_gfxdrv_command_reg = 1 << 16; @@ -254,7 +254,7 @@ static int psp_v3_1_bootloader_load_sos(struct psp_context *psp) /* Copy Secure OS binary to PSP memory */ memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); - /* Provide the PSP secure OS to bootrom */ + /* Provide the PSP secure OS to bootloader */ WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, (uint32_t)(psp->fw_pri_mc_addr >> 20)); psp_gfxdrv_command_reg = 2 << 16; -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <20181016224754.4105-1-clements.jm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* RE: [PATCH] Revised PSP comments [not found] ` <20181016224754.4105-1-clements.jm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2018-10-17 7:56 ` Huang, Ray 0 siblings, 0 replies; 2+ messages in thread From: Huang, Ray @ 2018-10-17 7:56 UTC (permalink / raw) To: John Clements, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > Of John Clements > Sent: Wednesday, October 17, 2018 6:48 AM > To: amd-gfx@lists.freedesktop.org > Cc: John Clements <clements.jm@gmail.com> > Subject: [PATCH] Revised PSP comments > > From: John Clements <clements.jm@gmail.com> > > Revised comments in PSP SOS/Sysdriver loading sequence > > Signed-off-by: John Clements <clements.jm@gmail.com> Thanks, applied it. Reviewed-by: Huang Rui <ray.huang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c > b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c > index b70cfa3fe1b2..3fe30eb46d26 100644 > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c > @@ -167,7 +167,7 @@ static int psp_v11_0_bootloader_load_sysdrv(struct > psp_context *psp) > /* Copy PSP System Driver binary to memory */ > memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); > > - /* Provide the sys driver to bootrom */ > + /* Provide the sys driver to bootloader */ > WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, > (uint32_t)(psp->fw_pri_mc_addr >> 20)); > psp_gfxdrv_command_reg = 1 << 16; > @@ -208,7 +208,7 @@ static int psp_v11_0_bootloader_load_sos(struct > psp_context *psp) > /* Copy Secure OS binary to PSP memory */ > memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); > > - /* Provide the PSP secure OS to bootrom */ > + /* Provide the PSP secure OS to bootloader */ > WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, > (uint32_t)(psp->fw_pri_mc_addr >> 20)); > psp_gfxdrv_command_reg = 2 << 16; > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > index e1ebf770c303..9cea0bbe4525 100644 > --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c > @@ -194,7 +194,7 @@ static int psp_v3_1_bootloader_load_sysdrv(struct > psp_context *psp) > /* Copy PSP System Driver binary to memory */ > memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); > > - /* Provide the sys driver to bootrom */ > + /* Provide the sys driver to bootloader */ > WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, > (uint32_t)(psp->fw_pri_mc_addr >> 20)); > psp_gfxdrv_command_reg = 1 << 16; > @@ -254,7 +254,7 @@ static int psp_v3_1_bootloader_load_sos(struct > psp_context *psp) > /* Copy Secure OS binary to PSP memory */ > memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); > > - /* Provide the PSP secure OS to bootrom */ > + /* Provide the PSP secure OS to bootloader */ > WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36, > (uint32_t)(psp->fw_pri_mc_addr >> 20)); > psp_gfxdrv_command_reg = 2 << 16; > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-17 7:56 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-16 22:47 [PATCH] Revised PSP comments John Clements [not found] ` <20181016224754.4105-1-clements.jm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2018-10-17 7:56 ` Huang, Ray
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.