All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/3] myrb: Add Mylex RAID controller (block interface)
Date: Wed, 17 Oct 2018 09:26:06 +0200	[thread overview]
Message-ID: <20181017072606.GF23407@lst.de> (raw)
In-Reply-To: <20181012071548.129113-2-hare@suse.de>

> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 99d366cb0e9f..1efbd175411a 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -922,10 +922,12 @@
>  #define PCI_DEVICE_ID_PICOPOWER_PT86C523BBP	0x8002
>  
>  #define PCI_VENDOR_ID_MYLEX		0x1069
> +#define PCI_SUBVENDOR_ID_MYLEX		0x1069

Vendor and subvendor its are the same.  Just use PCI_VENDOR_ID_MYLEX
where you;d want to use PCI_SUBVENDOR_ID_MYLEX.

>  #define PCI_DEVICE_ID_MYLEX_DAC960_P	0x0001
>  #define PCI_DEVICE_ID_MYLEX_DAC960_PD	0x0002
>  #define PCI_DEVICE_ID_MYLEX_DAC960_PG	0x0010
>  #define PCI_DEVICE_ID_MYLEX_DAC960_LA	0x0020
> +#define PCI_SUBDEVICE_ID_MYLEX_DAC960_LA 0x0020

Same here, in addition to the fact that we really don't
want single use PCI IDs in pci_ids.h.

Bonous points for just using the numeric values in the driver, and
adding another patch to remove them from pci_ids.h.

Otherwise looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2018-10-17  7:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  7:15 [PATCHv5 0/3] Deprecate DAC960 driver Hannes Reinecke
2018-10-12  7:15 ` [PATCH 1/3] myrb: Add Mylex RAID controller (block interface) Hannes Reinecke
2018-10-17  7:26   ` Christoph Hellwig [this message]
2018-10-12  7:15 ` [PATCH 2/3] myrs: Add Mylex RAID controller (SCSI interface) Hannes Reinecke
2018-10-17  7:28   ` Christoph Hellwig
2018-10-12  7:15 ` [PATCH 3/3] drivers/block: Remove DAC960 driver Hannes Reinecke
2018-10-17  7:28   ` Christoph Hellwig
2018-10-12 13:38 ` [PATCHv5 0/3] Deprecate " Bart Van Assche
2018-10-12 16:39   ` Jens Axboe
2018-10-17 14:19 ` Jens Axboe
2018-10-17 22:49   ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2018-10-17 15:25 [PATCHv6 " Hannes Reinecke
2018-10-17 15:25 ` [PATCH 1/3] myrb: Add Mylex RAID controller (block interface) Hannes Reinecke
2018-10-09 15:26 [PATCHv4 0/3] Deprecate DAC960 driver Hannes Reinecke
2018-10-09 15:26 ` [PATCH 1/3] myrb: Add Mylex RAID controller (block interface) Hannes Reinecke
2018-10-10 12:56   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017072606.GF23407@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.