* [U-Boot] [PATCH] power: regulator: Makefile: Remove SPL tag for REGULATOR_GPIO
@ 2018-10-17 10:45 Lokesh Vutla
2018-10-24 10:06 ` Lokesh Vutla
0 siblings, 1 reply; 2+ messages in thread
From: Lokesh Vutla @ 2018-10-17 10:45 UTC (permalink / raw)
To: u-boot
From: Keerthy <j-keerthy@ti.com>
There is no SPL specific Kconfig symbol defined for DM_REGULATOR_GPIO but
Makefile uses a SPL tag for building gpio-regulator. This makes
gpio-regulator can never be built for SPL. Fix it by dropping the
SPL tag in Makefile. CONFIG_SPL_POWER_SUPPORT is used for including
regulator support in SPL.
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
drivers/power/regulator/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile
index 16208af069..ba71504f8c 100644
--- a/drivers/power/regulator/Makefile
+++ b/drivers/power/regulator/Makefile
@@ -12,7 +12,7 @@ obj-$(CONFIG_DM_REGULATOR_MAX77686) += max77686.o
obj-$(CONFIG_$(SPL_)DM_PMIC_PFUZE100) += pfuze100.o
obj-$(CONFIG_REGULATOR_PWM) += pwm_regulator.o
obj-$(CONFIG_$(SPL_)DM_REGULATOR_FIXED) += fixed.o
-obj-$(CONFIG_$(SPL_)DM_REGULATOR_GPIO) += gpio-regulator.o
+obj-$(CONFIG_DM_REGULATOR_GPIO) += gpio-regulator.o
obj-$(CONFIG_REGULATOR_RK8XX) += rk8xx.o
obj-$(CONFIG_DM_REGULATOR_S2MPS11) += s2mps11_regulator.o
obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] power: regulator: Makefile: Remove SPL tag for REGULATOR_GPIO
2018-10-17 10:45 [U-Boot] [PATCH] power: regulator: Makefile: Remove SPL tag for REGULATOR_GPIO Lokesh Vutla
@ 2018-10-24 10:06 ` Lokesh Vutla
0 siblings, 0 replies; 2+ messages in thread
From: Lokesh Vutla @ 2018-10-24 10:06 UTC (permalink / raw)
To: u-boot
On Wednesday 17 October 2018 04:15 PM, Lokesh Vutla wrote:
> From: Keerthy <j-keerthy@ti.com>
>
> There is no SPL specific Kconfig symbol defined for DM_REGULATOR_GPIO but
> Makefile uses a SPL tag for building gpio-regulator. This makes
> gpio-regulator can never be built for SPL. Fix it by dropping the
> SPL tag in Makefile. CONFIG_SPL_POWER_SUPPORT is used for including
> regulator support in SPL.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
This is breaking omap3_logic defconfig as DM_REGULATOR_GPIO is selected for SPL
but SPL_GPIO support is not enabled. We should add a Kconfig symbol for fixing
it. Will repost the patch.
Thanks and regards,
Lokesh
> ---
> drivers/power/regulator/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile
> index 16208af069..ba71504f8c 100644
> --- a/drivers/power/regulator/Makefile
> +++ b/drivers/power/regulator/Makefile
> @@ -12,7 +12,7 @@ obj-$(CONFIG_DM_REGULATOR_MAX77686) += max77686.o
> obj-$(CONFIG_$(SPL_)DM_PMIC_PFUZE100) += pfuze100.o
> obj-$(CONFIG_REGULATOR_PWM) += pwm_regulator.o
> obj-$(CONFIG_$(SPL_)DM_REGULATOR_FIXED) += fixed.o
> -obj-$(CONFIG_$(SPL_)DM_REGULATOR_GPIO) += gpio-regulator.o
> +obj-$(CONFIG_DM_REGULATOR_GPIO) += gpio-regulator.o
> obj-$(CONFIG_REGULATOR_RK8XX) += rk8xx.o
> obj-$(CONFIG_DM_REGULATOR_S2MPS11) += s2mps11_regulator.o
> obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-24 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17 10:45 [U-Boot] [PATCH] power: regulator: Makefile: Remove SPL tag for REGULATOR_GPIO Lokesh Vutla
2018-10-24 10:06 ` Lokesh Vutla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.