All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] python-crossbar: drop Python 2 support
@ 2018-10-16 23:44 Ricardo Martincoski
  2018-10-17 19:48 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Martincoski @ 2018-10-16 23:44 UTC (permalink / raw)
  To: buildroot

Upstream is now Python 3 only.

Quoting the maintainer [1]: "the last version of crossbar with python 2
support: pip install crossbar==18.4.1".

[1] https://github.com/crossbario/crossbar/issues/1332

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>
Cc: Mauro Condarelli <mc5686@mclink.it>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
---
NOTES:

This is only for master branch. Other branches are not affected.

There are newer releases available via pip2 but they are broken in
runtime. Some people complained about this on [1].

Based on "f4972e2e8c python-django: bump to version 2.1.2" I assume we
don't need any legacy handling for this case.

I followed the convention from the manual:
4. Any dependencies on the toolchain in depends on form
5. Any dependencies on other packages in depends on form
---
 package/python-crossbar/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/python-crossbar/Config.in b/package/python-crossbar/Config.in
index 2f9de6e0b5..526d9871be 100644
--- a/package/python-crossbar/Config.in
+++ b/package/python-crossbar/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PYTHON_CROSSBAR
 	bool "python-crossbar"
 	depends on BR2_INSTALL_LIBSTDCPP # python-cryptography
+	depends on BR2_PACKAGE_PYTHON3
 	# All the following dependencies are runtime dependencies
 	select BR2_PACKAGE_PYTHON_ATTRS
 	select BR2_PACKAGE_PYTHON_AUTOBAHN
@@ -48,3 +49,4 @@ config BR2_PACKAGE_PYTHON_CROSSBAR
 
 comment "python-crossbar needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_PYTHON3
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] python-crossbar: drop Python 2 support
  2018-10-16 23:44 [Buildroot] [PATCH 1/1] python-crossbar: drop Python 2 support Ricardo Martincoski
@ 2018-10-17 19:48 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-10-17 19:48 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 16 Oct 2018 20:44:57 -0300, Ricardo Martincoski wrote:
> Upstream is now Python 3 only.
> 
> Quoting the maintainer [1]: "the last version of crossbar with python 2
> support: pip install crossbar==18.4.1".
> 
> [1] https://github.com/crossbario/crossbar/issues/1332
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Asaf Kahlon <asafka7@gmail.com>
> Cc: Mauro Condarelli <mc5686@mclink.it>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> NOTES:

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-17 19:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 23:44 [Buildroot] [PATCH 1/1] python-crossbar: drop Python 2 support Ricardo Martincoski
2018-10-17 19:48 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.