From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: nikolay@cumulusnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: ipmr: fix unresolved entry dumps
Date: Thu, 18 Oct 2018 16:46:29 -0700 (PDT) [thread overview]
Message-ID: <20181018.164629.99095073835498552.davem@davemloft.net> (raw)
In-Reply-To: <ec18010b-cd8a-f419-a929-c0b1a0a09928@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Thu, 18 Oct 2018 09:16:17 -0600
> On 10/17/18 11:36 PM, David Miller wrote:
>> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>> Date: Wed, 17 Oct 2018 22:34:34 +0300
>>
>>> If the skb space ends in an unresolved entry while dumping we'll miss
>>> some unresolved entries. The reason is due to zeroing the entry counter
>>> between dumping resolved and unresolved mfc entries. We should just
>>> keep counting until the whole table is dumped and zero when we move to
>>> the next as we have a separate table counter.
>>>
>>> Reported-by: Colin Ian King <colin.king@canonical.com>
>>> Fixes: 8fb472c09b9d ("ipmr: improve hash scalability")
>>> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>>
>> Applied and queued up for -stable.
>>
>
> FYI: on the net to net-next merge, those 2 lines were moved to
> mr_table_dump.
Thanks for the heads up.
prev parent reply other threads:[~2018-10-19 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 18:22 ipmr, ip6mr: Unite dumproute flows Colin Ian King
2018-10-17 18:49 ` Nikolay Aleksandrov
2018-10-17 19:34 ` [PATCH net] net: ipmr: fix unresolved entry dumps Nikolay Aleksandrov
2018-10-17 19:35 ` Nikolay Aleksandrov
2018-10-18 5:36 ` David Miller
2018-10-18 15:16 ` David Ahern
2018-10-18 23:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018.164629.99095073835498552.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.