From: kbuild test robot <lkp@intel.com>
To: Steve Capper <steve.capper@arm.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, ard.biesheuvel@linaro.org, jcm@redhat.com
Subject: Re: [PATCH V2 2/4] arm64: mm: Introduce DEFAULT_MAP_WINDOW
Date: Thu, 18 Oct 2018 09:50:07 +0800 [thread overview]
Message-ID: <201810180952.4NR6F0Y7%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181017163459.20175-3-steve.capper@arm.com>
[-- Attachment #1: Type: text/plain, Size: 8329 bytes --]
Hi Steve,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on v4.19-rc8]
[cannot apply to next-20181017]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Steve-Capper/52-bit-userspace-VAs/20181018-061652
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64
All error/warnings (new ones prefixed by >>):
In file included from include/linux/cache.h:5:0,
from include/linux/printk.h:9,
from include/linux/kernel.h:14,
from include/asm-generic/bug.h:18,
from arch/arm64/include/asm/bug.h:37,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from fs//hugetlbfs/inode.c:12:
fs//hugetlbfs/inode.c: In function 'hugetlb_get_unmapped_area':
>> arch/arm64/include/asm/processor.h:63:50: error: 'tsk' undeclared (first use in this function)
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
>> fs//hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
arch/arm64/include/asm/processor.h:63:50: note: each undeclared identifier is reported only once for each function it appears in
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
>> fs//hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
--
In file included from include/linux/cache.h:5:0,
from include/linux/printk.h:9,
from include/linux/kernel.h:14,
from include/asm-generic/bug.h:18,
from arch/arm64/include/asm/bug.h:37,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from fs/hugetlbfs/inode.c:12:
fs/hugetlbfs/inode.c: In function 'hugetlb_get_unmapped_area':
>> arch/arm64/include/asm/processor.h:63:50: error: 'tsk' undeclared (first use in this function)
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
fs/hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
arch/arm64/include/asm/processor.h:63:50: note: each undeclared identifier is reported only once for each function it appears in
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
fs/hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
vim +/tsk +63 arch/arm64/include/asm/processor.h
52
53 /*
54 * TASK_SIZE - the maximum size of a user space task.
55 * TASK_UNMAPPED_BASE - the lower boundary of the mmap VM area.
56 */
57 #ifdef CONFIG_COMPAT
58 #define TASK_SIZE_32 UL(0x100000000)
59 #define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
60 TASK_SIZE_32 : TASK_SIZE_64)
61 #define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
62 TASK_SIZE_32 : TASK_SIZE_64)
> 63 #define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
64 TASK_SIZE_32 : DEFAULT_MAP_WINDOW_64)
65 #else
66 #define TASK_SIZE TASK_SIZE_64
67 #define DEFAULT_MAP_WINDOW DEFAULT_MAP_WINDOW_64
68 #endif /* CONFIG_COMPAT */
69
> 70 #define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
71 #define STACK_TOP_MAX DEFAULT_MAP_WINDOW_64
72
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40225 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/4] arm64: mm: Introduce DEFAULT_MAP_WINDOW
Date: Thu, 18 Oct 2018 09:50:07 +0800 [thread overview]
Message-ID: <201810180952.4NR6F0Y7%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181017163459.20175-3-steve.capper@arm.com>
Hi Steve,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on v4.19-rc8]
[cannot apply to next-20181017]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Steve-Capper/52-bit-userspace-VAs/20181018-061652
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64
All error/warnings (new ones prefixed by >>):
In file included from include/linux/cache.h:5:0,
from include/linux/printk.h:9,
from include/linux/kernel.h:14,
from include/asm-generic/bug.h:18,
from arch/arm64/include/asm/bug.h:37,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from fs//hugetlbfs/inode.c:12:
fs//hugetlbfs/inode.c: In function 'hugetlb_get_unmapped_area':
>> arch/arm64/include/asm/processor.h:63:50: error: 'tsk' undeclared (first use in this function)
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
>> fs//hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
arch/arm64/include/asm/processor.h:63:50: note: each undeclared identifier is reported only once for each function it appears in
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
>> fs//hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
--
In file included from include/linux/cache.h:5:0,
from include/linux/printk.h:9,
from include/linux/kernel.h:14,
from include/asm-generic/bug.h:18,
from arch/arm64/include/asm/bug.h:37,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from fs/hugetlbfs/inode.c:12:
fs/hugetlbfs/inode.c: In function 'hugetlb_get_unmapped_area':
>> arch/arm64/include/asm/processor.h:63:50: error: 'tsk' undeclared (first use in this function)
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
fs/hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
arch/arm64/include/asm/processor.h:63:50: note: each undeclared identifier is reported only once for each function it appears in
#define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
^
include/uapi/linux/kernel.h:11:41: note: in definition of macro '__ALIGN_KERNEL_MASK'
#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
^
>> include/linux/kernel.h:58:22: note: in expansion of macro '__ALIGN_KERNEL'
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^~~~~~~~~~~~~~
>> include/linux/mm.h:144:26: note: in expansion of macro 'ALIGN'
#define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
^~~~~
>> arch/arm64/include/asm/processor.h:70:29: note: in expansion of macro 'PAGE_ALIGN'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~
>> arch/arm64/include/asm/processor.h:70:40: note: in expansion of macro 'DEFAULT_MAP_WINDOW'
#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
^~~~~~~~~~~~~~~~~~
fs/hugetlbfs/inode.c:214:19: note: in expansion of macro 'TASK_UNMAPPED_BASE'
info.low_limit = TASK_UNMAPPED_BASE;
^~~~~~~~~~~~~~~~~~
vim +/tsk +63 arch/arm64/include/asm/processor.h
52
53 /*
54 * TASK_SIZE - the maximum size of a user space task.
55 * TASK_UNMAPPED_BASE - the lower boundary of the mmap VM area.
56 */
57 #ifdef CONFIG_COMPAT
58 #define TASK_SIZE_32 UL(0x100000000)
59 #define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \
60 TASK_SIZE_32 : TASK_SIZE_64)
61 #define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
62 TASK_SIZE_32 : TASK_SIZE_64)
> 63 #define DEFAULT_MAP_WINDOW (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
64 TASK_SIZE_32 : DEFAULT_MAP_WINDOW_64)
65 #else
66 #define TASK_SIZE TASK_SIZE_64
67 #define DEFAULT_MAP_WINDOW DEFAULT_MAP_WINDOW_64
68 #endif /* CONFIG_COMPAT */
69
> 70 #define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 4))
71 #define STACK_TOP_MAX DEFAULT_MAP_WINDOW_64
72
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 40225 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181018/fe5209b1/attachment-0001.gz>
next prev parent reply other threads:[~2018-10-18 1:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 16:34 [PATCH V2 0/4] 52-bit userspace VAs Steve Capper
2018-10-17 16:34 ` Steve Capper
2018-10-17 16:34 ` [PATCH V2 1/4] mm: mmap: Allow for "high" userspace addresses Steve Capper
2018-10-17 16:34 ` Steve Capper
2018-10-17 16:48 ` Matthew Wilcox
2018-10-17 16:48 ` Matthew Wilcox
2018-10-18 10:35 ` Steve Capper
2018-10-18 10:35 ` Steve Capper
2018-10-17 16:34 ` [PATCH V2 2/4] arm64: mm: Introduce DEFAULT_MAP_WINDOW Steve Capper
2018-10-17 16:34 ` Steve Capper
2018-10-18 1:50 ` kbuild test robot [this message]
2018-10-18 1:50 ` kbuild test robot
2018-10-18 2:09 ` kbuild test robot
2018-10-18 2:09 ` kbuild test robot
2018-10-18 10:47 ` Steve Capper
2018-10-18 10:47 ` Steve Capper
2018-10-17 16:34 ` [PATCH V2 3/4] arm64: mm: Define arch_get_mmap_end, arch_get_mmap_base Steve Capper
2018-10-17 16:34 ` Steve Capper
2018-10-18 2:28 ` kbuild test robot
2018-10-18 2:28 ` kbuild test robot
2018-10-17 16:34 ` [PATCH V2 4/4] arm64: mm: introduce 52-bit userspace support Steve Capper
2018-10-17 16:34 ` Steve Capper
2018-10-18 2:44 ` kbuild test robot
2018-10-18 2:44 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810180952.4NR6F0Y7%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=jcm@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.