* [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type
@ 2018-10-18 23:18 kbuild test robot
2018-10-18 23:28 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-10-18 23:18 UTC (permalink / raw)
To: Keith Busch; +Cc: kbuild-all, linux-pci, Bjorn Helgaas
[-- Attachment #1: Type: text/plain, Size: 2439 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
head: 5a076cc998d369f701104e35d5bb985cab0a66d3
commit: 0459ba0b0d50429500b6ed46d0a97203de37ba6b [45/50] PCI/AER: Use threaded IRQ for bottom half
config: sh-sdk7786_defconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 0459ba0b0d50429500b6ed46d0a97203de37ba6b
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sh
Note: the pci/pci/hotplug HEAD 5a076cc998d369f701104e35d5bb985cab0a66d3 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/pci/pcie/aer.c: In function 'aer_probe':
>> drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
struct device *device = &dev->port->device;
^
cc1: some warnings being treated as errors
vim +1387 drivers/pci/pcie/aer.c
1376
1377 /**
1378 * aer_probe - initialize resources
1379 * @dev: pointer to the pcie_dev data structure
1380 *
1381 * Invoked when PCI Express bus loads AER service driver.
1382 */
1383 static int aer_probe(struct pcie_device *dev)
1384 {
1385 int status;
1386 struct aer_rpc *rpc;
> 1387 struct device *device = &dev->port->device;
1388
1389 /* Alloc rpc data structure */
1390 rpc = kzalloc(sizeof(struct aer_rpc), GFP_KERNEL);
1391 if (!rpc) {
1392 dev_printk(KERN_DEBUG, device, "alloc AER rpc failed\n");
1393 return -ENOMEM;
1394 }
1395 rpc->rpd = dev->port;
1396 set_service_data(dev, rpc);
1397
1398 /* Request IRQ ISR */
1399 status = request_threaded_irq(dev->irq, aer_irq, aer_isr,
1400 IRQF_SHARED, "aerdrv", dev);
1401 if (status) {
1402 dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
1403 dev->irq);
1404 aer_remove(dev);
1405 return status;
1406 }
1407
1408 aer_enable_rootport(rpc);
1409 dev_info(device, "AER enabled with IRQ %d\n", dev->irq);
1410 return 0;
1411 }
1412
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 18366 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type
2018-10-18 23:18 [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type kbuild test robot
@ 2018-10-18 23:28 ` Keith Busch
2018-10-19 0:49 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Keith Busch @ 2018-10-18 23:28 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, linux-pci, Bjorn Helgaas
On Fri, Oct 19, 2018 at 07:18:52AM +0800, kbuild test robot wrote:
> drivers/pci/pcie/aer.c: In function 'aer_probe':
> >> drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> struct device *device = &dev->port->device;
> ^
> cc1: some warnings being treated as errors
>
> vim +1387 drivers/pci/pcie/aer.c
>
> 1376
> 1377 /**
> 1378 * aer_probe - initialize resources
> 1379 * @dev: pointer to the pcie_dev data structure
> 1380 *
> 1381 * Invoked when PCI Express bus loads AER service driver.
> 1382 */
> 1383 static int aer_probe(struct pcie_device *dev)
> 1384 {
> 1385 int status;
> 1386 struct aer_rpc *rpc;
> > 1387 struct device *device = &dev->port->device;
You must be building patches incrementally since this was (inadvertently)
fixed by the following commit 09d260ca3ad04d9b4c4d5e8b0fa1e3501b3e3793
("PCI/AER: Use managed resource allocations").
Bjorn,
If you want to replay the history, I quickly rebase the two affected
patches so this intermediate compile breakage doesn't happen. Up to you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type
2018-10-18 23:28 ` Keith Busch
@ 2018-10-19 0:49 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2018-10-19 0:49 UTC (permalink / raw)
To: Keith Busch; +Cc: kbuild test robot, kbuild-all, linux-pci
On Thu, Oct 18, 2018 at 05:28:04PM -0600, Keith Busch wrote:
> On Fri, Oct 19, 2018 at 07:18:52AM +0800, kbuild test robot wrote:
> > drivers/pci/pcie/aer.c: In function 'aer_probe':
> > >> drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> > struct device *device = &dev->port->device;
> > ^
> > cc1: some warnings being treated as errors
> >
> > vim +1387 drivers/pci/pcie/aer.c
> >
> > 1376
> > 1377 /**
> > 1378 * aer_probe - initialize resources
> > 1379 * @dev: pointer to the pcie_dev data structure
> > 1380 *
> > 1381 * Invoked when PCI Express bus loads AER service driver.
> > 1382 */
> > 1383 static int aer_probe(struct pcie_device *dev)
> > 1384 {
> > 1385 int status;
> > 1386 struct aer_rpc *rpc;
> > > 1387 struct device *device = &dev->port->device;
>
> You must be building patches incrementally since this was (inadvertently)
> fixed by the following commit 09d260ca3ad04d9b4c4d5e8b0fa1e3501b3e3793
> ("PCI/AER: Use managed resource allocations").
Yes, I think the 0-day service builds each incremental patch.
> Bjorn,
> If you want to replay the history, I quickly rebase the two affected
> patches so this intermediate compile breakage doesn't happen. Up to you.
I fixed this up by removing this from 0459ba0b0d50 ("PCI/AER: Use threaded
IRQ for bottom half"), since I don't think it's relevant to that patch:
@@ -1418,18 +1384,20 @@ static int aer_probe(struct pcie_device *dev)
{
int status;
struct aer_rpc *rpc;
- struct device *device = &dev->port->dev;
+ struct device *device = &dev->port->device;
and making 09d260ca3ad0 ("PCI/AER: Use managed resource allocations") look
like this:
@@ -1384,10 +1380,9 @@ static int aer_probe(struct pcie_device *dev)
{
int status;
struct aer_rpc *rpc;
- struct device *device = &dev->port->dev;
+ struct device *device = &dev->device;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-19 0:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 23:18 [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type kbuild test robot
2018-10-18 23:28 ` Keith Busch
2018-10-19 0:49 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.