Re: [PATCH V2 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's

From: kbuild test robot <lkp@intel.com>
To: Al Cooper <alcooperx@gmail.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Al Cooper <alcooperx@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Alban Bedel <albeu@free.fr>, Alex Elder <elder@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Avi Fishman <avifishman70@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org, Dmitry Osipenko <digetx@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Hans de Goede <hdegoede@redhat.com>,
	James Hogan <jhogan@kernel.org>,
	Jianguo Sun <sunjianguo1@huawei.com>,
	Johan Hovold <johan@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-usb@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rishabh Bhatnagar <rishabhb@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH V2 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
Date: Fri, 19 Oct 2018 00:49:15 +0800	[thread overview]
Message-ID: <201810190028.sduFtg5C%fengguang.wu@intel.com> (raw)
In-Reply-To: <1539815349-24126-4-git-send-email-alcooperx@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

Hi Al,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.19-rc8 next-20181018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181019-001132
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-x017-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181019-001132 HEAD 80aedf2037a6c697bfe2193ffbb635e4ab26a0b6 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> drivers/usb//host/xhci-plat.c:117:16: error: 'xhci_plat_brcm_init_quirk' undeclared here (not in a function); did you mean 'xhci_brcm_init_quirk'?
     .init_quirk = xhci_plat_brcm_init_quirk
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
                   xhci_brcm_init_quirk

vim +117 drivers/usb//host/xhci-plat.c

   115	
   116	static const struct xhci_plat_priv xhci_plat_brcm = {
 > 117		.init_quirk = xhci_plat_brcm_init_quirk
   118	};
   119	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35984 bytes --]