All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
	punit.agrawal@arm.com, will.deacon@arm.com, Steven.Price@arm.com,
	steve.capper@arm.com, catalin.marinas@arm.com,
	akpm@linux-foundation.org, mike.kravetz@oracle.com,
	n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration
Date: Fri, 19 Oct 2018 10:09:59 +0200	[thread overview]
Message-ID: <20181019080959.GL18839@dhcp22.suse.cz> (raw)
In-Reply-To: <1539316799-6064-2-git-send-email-anshuman.khandual@arm.com>

I planed to get to review this earlier but been busy. Anyway, this patch
should be applied only after movability one to prevent from
(theoretical) bisectability issues.

I would probably fold it into the one which defines arch specific hook.

On Fri 12-10-18 09:29:55, Anshuman Khandual wrote:
> Architectures like arm64 have PUD level HugeTLB pages for certain configs
> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be
> enabled for migration. It can be achieved through checking for PUD_SHIFT
> order based HugeTLB pages during migration.
> 
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  include/linux/hugetlb.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 6b68e34..9c1b77f 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -483,7 +483,8 @@ static inline bool hugepage_migration_supported(struct hstate *h)
>  {
>  #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
>  	if ((huge_page_shift(h) == PMD_SHIFT) ||
> -		(huge_page_shift(h) == PGDIR_SHIFT))
> +		(huge_page_shift(h) == PUD_SHIFT) ||
> +			(huge_page_shift(h) == PGDIR_SHIFT))
>  		return true;
>  	else
>  		return false;
> -- 
> 2.7.4

-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: mhocko@kernel.org (Michal Hocko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration
Date: Fri, 19 Oct 2018 10:09:59 +0200	[thread overview]
Message-ID: <20181019080959.GL18839@dhcp22.suse.cz> (raw)
In-Reply-To: <1539316799-6064-2-git-send-email-anshuman.khandual@arm.com>

I planed to get to review this earlier but been busy. Anyway, this patch
should be applied only after movability one to prevent from
(theoretical) bisectability issues.

I would probably fold it into the one which defines arch specific hook.

On Fri 12-10-18 09:29:55, Anshuman Khandual wrote:
> Architectures like arm64 have PUD level HugeTLB pages for certain configs
> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be
> enabled for migration. It can be achieved through checking for PUD_SHIFT
> order based HugeTLB pages during migration.
> 
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  include/linux/hugetlb.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 6b68e34..9c1b77f 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -483,7 +483,8 @@ static inline bool hugepage_migration_supported(struct hstate *h)
>  {
>  #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
>  	if ((huge_page_shift(h) == PMD_SHIFT) ||
> -		(huge_page_shift(h) == PGDIR_SHIFT))
> +		(huge_page_shift(h) == PUD_SHIFT) ||
> +			(huge_page_shift(h) == PGDIR_SHIFT))
>  		return true;
>  	else
>  		return false;
> -- 
> 2.7.4

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2018-10-19  8:10 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  3:59 [PATCH V2 0/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-12  3:59 ` Anshuman Khandual
2018-10-12  3:59 ` [PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration Anshuman Khandual
2018-10-12  3:59   ` Anshuman Khandual
2018-10-19  8:09   ` Michal Hocko [this message]
2018-10-19  8:09     ` Michal Hocko
2018-10-22  3:01     ` Anshuman Khandual
2018-10-22  3:01       ` Anshuman Khandual
2018-10-22  7:16       ` Michal Hocko
2018-10-22  7:16         ` Michal Hocko
2018-10-12  3:59 ` [PATCH V2 2/5] mm/hugetlb: Distinguish between migratability and movability Anshuman Khandual
2018-10-12  3:59   ` Anshuman Khandual
2018-10-19  1:59   ` Naoya Horiguchi
2018-10-19  1:59     ` Naoya Horiguchi
2018-10-19  1:59     ` Naoya Horiguchi
2018-10-19  2:32     ` Anshuman Khandual
2018-10-19  2:32       ` Anshuman Khandual
2018-10-19  2:32       ` Anshuman Khandual
2018-10-12  3:59 ` [PATCH V2 3/5] mm/hugetlb: Enable arch specific huge page size support for migration Anshuman Khandual
2018-10-12  3:59   ` Anshuman Khandual
2018-10-12  3:59 ` [PATCH V2 4/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-12  3:59   ` Anshuman Khandual
2018-10-12  3:59 ` [PATCH V2 5/5] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages Anshuman Khandual
2018-10-12  3:59   ` Anshuman Khandual
2018-10-17  8:19 ` [PATCH V2 0/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-17  8:19   ` Anshuman Khandual
2018-10-19  2:01   ` Naoya Horiguchi
2018-10-19  2:01     ` Naoya Horiguchi
2018-10-19  2:01     ` Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019080959.GL18839@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=Steven.Price@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=punit.agrawal@arm.com \
    --cc=steve.capper@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.