* [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object
@ 2018-10-19 8:46 Petri Latvala
2018-10-19 12:01 ` Andi Shyti
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Petri Latvala @ 2018-10-19 8:46 UTC (permalink / raw)
To: igt-dev; +Cc: Andi Shyti, Petri Latvala
Turns out the same information is looked up in different places in
different code paths. Piglit's summary module looks up total counts in
['totals']['root'], CI looks up ['totals']['']. The latter is
inherited from piglit, so this has probably changed at some point.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108486
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
runner/resultgen.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/runner/resultgen.c b/runner/resultgen.c
index ed8c9266..e059c65b 100644
--- a/runner/resultgen.c
+++ b/runner/resultgen.c
@@ -906,13 +906,14 @@ static void add_to_totals(char *binary,
struct subtests *subtests,
struct results *results)
{
- struct json_object *test, *resultobj, *roottotal, *binarytotal;
+ struct json_object *test, *resultobj, *emptystrtotal, *roottotal, *binarytotal;
char piglit_name[256];
const char *result;
size_t i;
generate_piglit_name(binary, NULL, piglit_name, sizeof(piglit_name));
- roottotal = get_totals_object(results->totals, "");
+ emptystrtotal = get_totals_object(results->totals, "");
+ roottotal = get_totals_object(results->totals, "root");
binarytotal = get_totals_object(results->totals, piglit_name);
if (subtests->size == 0) {
@@ -922,6 +923,7 @@ static void add_to_totals(char *binary,
return;
}
result = json_object_get_string(resultobj);
+ add_result_to_totals(emptystrtotal, result);
add_result_to_totals(roottotal, result);
add_result_to_totals(binarytotal, result);
return;
@@ -935,6 +937,7 @@ static void add_to_totals(char *binary,
return;
}
result = json_object_get_string(resultobj);
+ add_result_to_totals(emptystrtotal, result);
add_result_to_totals(roottotal, result);
add_result_to_totals(binarytotal, result);
}
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object
2018-10-19 8:46 [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object Petri Latvala
@ 2018-10-19 12:01 ` Andi Shyti
2018-10-19 12:17 ` Arkadiusz Hiler
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Andi Shyti @ 2018-10-19 12:01 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
Hi Petri,
On Fri, Oct 19, 2018 at 11:46:48AM +0300, Petri Latvala wrote:
> Turns out the same information is looked up in different places in
> different code paths. Piglit's summary module looks up total counts in
> ['totals']['root'], CI looks up ['totals']['']. The latter is
> inherited from piglit, so this has probably changed at some point.
Thanks, you've been superfast :)
You can add:
Tested-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object
2018-10-19 8:46 [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object Petri Latvala
2018-10-19 12:01 ` Andi Shyti
@ 2018-10-19 12:17 ` Arkadiusz Hiler
2018-10-22 18:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Arkadiusz Hiler @ 2018-10-19 12:17 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev, Andi Shyti
On Fri, Oct 19, 2018 at 11:46:48AM +0300, Petri Latvala wrote:
> Turns out the same information is looked up in different places in
> different code paths. Piglit's summary module looks up total counts in
> ['totals']['root'], CI looks up ['totals']['']. The latter is
> inherited from piglit, so this has probably changed at some point.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108486
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] runner: Add "root" also to the "totals" object
2018-10-19 8:46 [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object Petri Latvala
2018-10-19 12:01 ` Andi Shyti
2018-10-19 12:17 ` Arkadiusz Hiler
@ 2018-10-22 18:48 ` Patchwork
2018-10-23 4:38 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-10-23 5:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-22 18:48 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Add "root" also to the "totals" object
URL : https://patchwork.freedesktop.org/series/51238/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5013 -> IGTPW_1966 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1966 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1966, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51238/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1966:
=== IGT changes ===
==== Possible regressions ====
igt@gem_exec_suspend@basic:
fi-icl-u2: PASS -> DMESG-WARN
== Known issues ==
Here are the changes found in IGTPW_1966 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106725, fdo#106248)
igt@drv_selftest@live_hangcheck:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#108315)
igt@gem_exec_basic@gtt-bsd:
fi-icl-u: NOTRUN -> DMESG-WARN (fdo#107732) +4
igt@gem_exec_store@basic-all:
fi-icl-u: NOTRUN -> DMESG-WARN (fdo#107724) +28
igt@gem_exec_suspend@basic-s3:
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107556, fdo#107774, fdo#107859)
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
fi-icl-u: NOTRUN -> DMESG-WARN (fdo#108512)
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: PASS -> DMESG-WARN (fdo#105998) +1
fi-hsw-4770r: PASS -> DMESG-WARN (fdo#105602) +1
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: PASS -> FAIL (fdo#100368)
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
==== Possible fixes ====
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107732 https://bugs.freedesktop.org/show_bug.cgi?id=107732
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108512 https://bugs.freedesktop.org/show_bug.cgi?id=108512
== Participating hosts (41 -> 48) ==
Additional (11): fi-kbl-soraka fi-icl-u fi-skl-guc fi-bdw-gvtdvm fi-glk-dsi fi-gdg-551 fi-pnv-d510 fi-ivb-3520m fi-kbl-7560u fi-byt-n2820 fi-snb-2600
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ivb-3770
== Build changes ==
* IGT: IGT_4684 -> IGTPW_1966
CI_DRM_5013: 0008b23799728680da3d6d871d46f746a3f69c35 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1966: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1966/
IGT_4684: 6f27fddc6dd79c0486181b64201c6773c5c42a24 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1966/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] runner: Add "root" also to the "totals" object
2018-10-19 8:46 [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object Petri Latvala
` (2 preceding siblings ...)
2018-10-22 18:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
@ 2018-10-23 4:38 ` Patchwork
2018-10-23 5:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-23 4:38 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Add "root" also to the "totals" object
URL : https://patchwork.freedesktop.org/series/51238/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5013 -> IGTPW_1976 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51238/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1976 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-kbl-7560u: NOTRUN -> INCOMPLETE (fdo#108044)
igt@gem_exec_suspend@basic-s3:
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107774, fdo#107556, fdo#107859)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859
fdo#108044 https://bugs.freedesktop.org/show_bug.cgi?id=108044
== Participating hosts (41 -> 42) ==
Additional (7): fi-kbl-soraka fi-bdw-gvtdvm fi-glk-dsi fi-ivb-3520m fi-kbl-7560u fi-byt-n2820 fi-snb-2600
Missing (6): fi-ilk-m540 fi-byt-j1900 fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-ivb-3770
== Build changes ==
* IGT: IGT_4684 -> IGTPW_1976
CI_DRM_5013: 0008b23799728680da3d6d871d46f746a3f69c35 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1976: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1976/
IGT_4684: 6f27fddc6dd79c0486181b64201c6773c5c42a24 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1976/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/1] runner: Add "root" also to the "totals" object
2018-10-19 8:46 [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object Petri Latvala
` (3 preceding siblings ...)
2018-10-23 4:38 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-10-23 5:27 ` Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-23 5:27 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Add "root" also to the "totals" object
URL : https://patchwork.freedesktop.org/series/51238/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4684_full -> IGTPW_1976_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1976_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1976_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51238/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1976_full:
=== IGT changes ===
==== Warnings ====
igt@kms_vblank@pipe-b-ts-continuation-idle:
shard-snb: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_1976_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-glk: NOTRUN -> FAIL (fdo#103158)
shard-apl: NOTRUN -> FAIL (fdo#103158)
igt@gem_exec_schedule@preempt-self-render:
shard-snb: SKIP -> INCOMPLETE (fdo#105411)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-hsw: NOTRUN -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-render-c:
shard-glk: NOTRUN -> DMESG-WARN (fdo#107956) +1
shard-hsw: NOTRUN -> DMESG-WARN (fdo#107956) +1
shard-kbl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
shard-apl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-glk: PASS -> DMESG-WARN (fdo#107956)
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_cursor_crc@cursor-256x85-random:
shard-glk: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-glk: NOTRUN -> FAIL (fdo#103232)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363, fdo#102887)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
shard-glk: PASS -> FAIL (fdo#103167) +1
igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
shard-apl: NOTRUN -> FAIL (fdo#108146)
shard-kbl: NOTRUN -> FAIL (fdo#108146)
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-kbl: NOTRUN -> FAIL (fdo#103166)
shard-glk: NOTRUN -> FAIL (fdo#103166)
shard-apl: NOTRUN -> FAIL (fdo#103166)
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
igt@kms_setmode@basic:
shard-snb: NOTRUN -> FAIL (fdo#99912)
igt@syncobj_wait@wait-all-for-submit-delayed-submit:
shard-glk: NOTRUN -> INCOMPLETE (fdo#103359, k.org#198133)
igt@syncobj_wait@wait-for-submit-snapshot:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@kms_color@pipe-c-degamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x42-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: FAIL (fdo#103232) -> PASS +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-glk: FAIL (fdo#103167) -> PASS +5
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: FAIL (fdo#103166) -> PASS +3
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4684 -> IGTPW_1976
* Linux: CI_DRM_5010 -> CI_DRM_5013
CI_DRM_5010: 27a4f334d3ec8882d50227c26ae4e393d7d1f4a1 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_5013: 0008b23799728680da3d6d871d46f746a3f69c35 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1976: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1976/
IGT_4684: 6f27fddc6dd79c0486181b64201c6773c5c42a24 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1976/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-23 5:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-19 8:46 [igt-dev] [PATCH i-g-t 1/1] runner: Add "root" also to the "totals" object Petri Latvala
2018-10-19 12:01 ` Andi Shyti
2018-10-19 12:17 ` Arkadiusz Hiler
2018-10-22 18:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
2018-10-23 4:38 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-10-23 5:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.