* [PATCH 1/2] target: Set response length for REPORT TARGET PORT GROUPS
@ 2018-10-20 16:45 Roland Dreier
2018-10-22 8:56 ` Christoph Hellwig
2018-10-24 1:18 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Roland Dreier @ 2018-10-20 16:45 UTC (permalink / raw)
To: target-devel
From: Roland Dreier <roland@purestorage.com>
One more place where we can return the length we actually fill in.
Signed-off-by: Roland Dreier <roland@purestorage.com>
---
drivers/target/target_core_alua.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c
index e46ca968009c..4f134b0c3e29 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -268,7 +268,7 @@ target_emulate_report_target_port_groups(struct se_cmd *cmd)
}
transport_kunmap_data_sg(cmd);
- target_complete_cmd(cmd, GOOD);
+ target_complete_cmd_with_length(cmd, GOOD, rd_len + 4);
return 0;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] target: Set response length for REPORT TARGET PORT GROUPS
2018-10-20 16:45 [PATCH 1/2] target: Set response length for REPORT TARGET PORT GROUPS Roland Dreier
@ 2018-10-22 8:56 ` Christoph Hellwig
2018-10-24 1:18 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2018-10-22 8:56 UTC (permalink / raw)
To: target-devel
On Sat, Oct 20, 2018 at 09:45:04AM -0700, Roland Dreier wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> One more place where we can return the length we actually fill in.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] target: Set response length for REPORT TARGET PORT GROUPS
2018-10-20 16:45 [PATCH 1/2] target: Set response length for REPORT TARGET PORT GROUPS Roland Dreier
2018-10-22 8:56 ` Christoph Hellwig
@ 2018-10-24 1:18 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-10-24 1:18 UTC (permalink / raw)
To: target-devel
Roland,
> One more place where we can return the length we actually fill in.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-24 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-20 16:45 [PATCH 1/2] target: Set response length for REPORT TARGET PORT GROUPS Roland Dreier
2018-10-22 8:56 ` Christoph Hellwig
2018-10-24 1:18 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.