* [Buildroot] [git commit] package/ca-certificates: fix rebuilds
@ 2018-10-21 13:34 Arnout Vandecappelle
2018-10-24 12:33 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2018-10-21 13:34 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=42b10634c628918c753bfb1aad4f950fa5d41299
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Rebuilding ca-certificates using make ca-certificates-rebuild
caused duplicate certificates to be installed in the target. Its build
system is broken: it doesn't detect that the output file already exists,
and instead of overwriting it, a duplicate is generated under a
different name. The net effect is that all certificates are installed
twice after rebuild.
Fix this by cleaning the build directory before building the package.
Signed-off-by: Martin Bark <martin@barkynet.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/ca-certificates/ca-certificates.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ca-certificates/ca-certificates.mk b/package/ca-certificates/ca-certificates.mk
index 9685d0e6f0..1df9543e03 100644
--- a/package/ca-certificates/ca-certificates.mk
+++ b/package/ca-certificates/ca-certificates.mk
@@ -16,7 +16,7 @@ CA_CERTIFICATES_LICENSE = GPL-2.0+ (script), MPL-2.0 (data)
CA_CERTIFICATES_LICENSE_FILES = debian/copyright
define CA_CERTIFICATES_BUILD_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) all
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) clean all
endef
define CA_CERTIFICATES_INSTALL_TARGET_CMDS
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [git commit] package/ca-certificates: fix rebuilds
2018-10-21 13:34 [Buildroot] [git commit] package/ca-certificates: fix rebuilds Arnout Vandecappelle
@ 2018-10-24 12:33 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2018-10-24 12:33 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=42b10634c628918c753bfb1aad4f950fa5d41299
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Rebuilding ca-certificates using make ca-certificates-rebuild
> caused duplicate certificates to be installed in the target. Its build
> system is broken: it doesn't detect that the output file already exists,
> and instead of overwriting it, a duplicate is generated under a
> different name. The net effect is that all certificates are installed
> twice after rebuild.
> Fix this by cleaning the build directory before building the package.
> Signed-off-by: Martin Bark <martin@barkynet.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed to 2018.02.x and 2018.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-24 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-21 13:34 [Buildroot] [git commit] package/ca-certificates: fix rebuilds Arnout Vandecappelle
2018-10-24 12:33 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.