* [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style
@ 2018-10-23 5:25 Zach Turner
2018-10-23 7:36 ` [Outreachy kernel] " Himanshu Jha
2018-10-30 9:28 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Zach Turner @ 2018-10-23 5:25 UTC (permalink / raw)
To: gregkh, hwentland, manasi.d.navare, daniel.vetter, outreachy-kernel
Add SPDX-License-Identifier tag to the start of the file. This is
a coding style change which should not impact runtime code execution.
Signed-off-by: Zach Turner <turnerzdp@gmail.com>
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index bc45cf098b04..8cfc2a1a5c48 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -1,5 +1,5 @@
-/*
- * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
+// SPDX-License-Identifier: GPL-2.0-or-later
+/* Host AP crypt: host-based CCMP encryption implementation for Host AP driver
*
* Copyright (c) 2003-2004, Jouni Malinen <jkmaline@cc.hut.fi>
*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style
2018-10-23 5:25 [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style Zach Turner
@ 2018-10-23 7:36 ` Himanshu Jha
2018-10-30 9:28 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Himanshu Jha @ 2018-10-23 7:36 UTC (permalink / raw)
To: Zach Turner
Cc: gregkh, hwentland, manasi.d.navare, daniel.vetter, outreachy-kernel
On Mon, Oct 22, 2018 at 11:25:59PM -0600, Zach Turner wrote:
> Add SPDX-License-Identifier tag to the start of the file. This is
> a coding style change which should not impact runtime code execution.
>
> Signed-off-by: Zach Turner <turnerzdp@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index bc45cf098b04..8cfc2a1a5c48 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -1,5 +1,5 @@
> -/*
> - * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
> +// SPDX-License-Identifier: GPL-2.0-or-later
I believe it should be:
// SPDX-License-Identifier: GPL-2.0+
considering MODULE_LICENSE("GPL")
check Documentation/process/license-rules.rst
Also, the purpose of SPDX tag was to remove bolierplate text:
```
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation. See README and COPYING for
* more details.
*/
```
But this above text suggest GPLv2 which is inconsistent with MODULE_LICENSE("GPL");
present at the bottom of the file.
Lastly, for these copyrights changes Cc the author of the file too.
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style
2018-10-23 5:25 [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style Zach Turner
2018-10-23 7:36 ` [Outreachy kernel] " Himanshu Jha
@ 2018-10-30 9:28 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-10-30 9:28 UTC (permalink / raw)
To: Zach Turner; +Cc: hwentland, manasi.d.navare, daniel.vetter, outreachy-kernel
On Mon, Oct 22, 2018 at 11:25:59PM -0600, Zach Turner wrote:
> Add SPDX-License-Identifier tag to the start of the file. This is
> a coding style change which should not impact runtime code execution.
>
> Signed-off-by: Zach Turner <turnerzdp@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index bc45cf098b04..8cfc2a1a5c48 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -1,5 +1,5 @@
> -/*
> - * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
> +// SPDX-License-Identifier: GPL-2.0-or-later
Please read Documentation/process/license-rules.rst for the proper
string to put here (hint do not use "or-later" in it...)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-30 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 5:25 [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style Zach Turner
2018-10-23 7:36 ` [Outreachy kernel] " Himanshu Jha
2018-10-30 9:28 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.