From: Philipp Zabel <pza@pengutronix.de>
To: Tomasz Figa <tfiga@chromium.org>
Cc: nicolas@ndufresne.ca, Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [RFP] Which V4L2 ioctls could be replaced by better versions?
Date: Tue, 23 Oct 2018 15:02:54 +0200 [thread overview]
Message-ID: <20181023130254.t27fp7gh6gp5uqk4@pengutronix.de> (raw)
In-Reply-To: <CAAFQd5A3a1o55pcV6Kn5ZWXQFYJvuv4y1+oD4=PEZXoYMhrX0Q@mail.gmail.com>
Hi Tomasz,
On Mon, Oct 22, 2018 at 12:37:57PM +0900, Tomasz Figa wrote:
[...]
> On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel <pza@pengutronix.de> wrote:
[...]
> > REQBUFS 0 fails if the vb2 buffer is still in use, including from dmabuf
> > attachments: vb2_buffer_in_use checks the num_users memop. The refcount
> > returned by num_users shared between the vmarea handler and dmabuf ops,
> > so any dmabuf attachment counts towards in_use.
>
> Ah, right. I've managed to completely forget about it, since we have a
> downstream patch that we attempted to upstream earlier [1], but didn't
> have a chance to follow up on the comments and there wasn't much
> interest in it in general.
>
> [1] https://lore.kernel.org/patchwork/patch/607853/
>
> Perhaps it would be worth reviving?
Yes, thanks for the pointer. I've completely missed that patch.
I was under the mistaken impression that there was some technical reason
to keep the queue around until after the last dmabuf attachment is gone,
but everything is properly refcounted.
regards
Philipp
next prev parent reply other threads:[~2018-10-23 21:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 14:42 [RFP] Which V4L2 ioctls could be replaced by better versions? Hans Verkuil
2018-09-20 18:14 ` Nicolas Dufresne
2018-10-03 8:24 ` Tomasz Figa
2018-10-16 13:22 ` Hans Verkuil
2018-10-21 16:28 ` Philipp Zabel
2018-10-22 3:37 ` Tomasz Figa
2018-10-22 9:49 ` Dave Stevenson
2018-10-23 13:02 ` Philipp Zabel [this message]
2018-10-27 9:38 ` Nicolas Dufresne
2018-11-08 7:45 ` Tomasz Figa
2018-11-09 21:06 ` Nicolas Dufresne
2018-11-11 3:43 ` Tomasz Figa
2018-11-12 9:29 ` Philipp Zabel
2018-11-12 15:02 ` Hans Verkuil
2018-10-21 16:17 ` Philipp Zabel
2018-10-17 8:57 ` Laurent Pinchart
2018-10-17 9:16 ` Hans Verkuil
2018-10-17 20:46 ` Laurent Pinchart
2018-10-20 20:28 ` Sakari Ailus
2018-10-26 11:41 ` Tomasz Figa
2018-10-26 13:42 ` Laurent Pinchart
2019-03-15 4:18 ` Tomasz Figa
2019-03-17 16:10 ` Laurent Pinchart
2019-03-17 17:10 ` Nicolas Dufresne
2019-03-17 17:14 ` Nicolas Dufresne
2019-03-25 9:41 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023130254.t27fp7gh6gp5uqk4@pengutronix.de \
--to=pza@pengutronix.de \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.