* [PATCH] blk-mq: place trace_block_getrq() in correct place
@ 2018-10-23 14:30 Xiaoguang Wang
2018-10-24 1:30 ` jianchao.wang
2018-10-24 9:29 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Xiaoguang Wang @ 2018-10-23 14:30 UTC (permalink / raw)
To: linux-block; +Cc: axboe, Xiaoguang Wang
trace_block_getrq() is to indicate a request struct has been allcoated
for queue, so put it in right place.
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
---
block/blk-mq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index e3c39ea8e17b..93aec25f1340 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1833,8 +1833,6 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
rq_qos_throttle(q, bio, NULL);
- trace_block_getrq(q, bio, bio->bi_opf);
-
rq = blk_mq_get_request(q, bio, bio->bi_opf, &data);
if (unlikely(!rq)) {
rq_qos_cleanup(q, bio);
@@ -1843,6 +1841,8 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
return BLK_QC_T_NONE;
}
+ trace_block_getrq(q, bio, bio->bi_opf);
+
rq_qos_track(q, rq, bio);
cookie = request_to_qc_t(data.hctx, rq);
--
2.14.4.44.g2045bb6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq: place trace_block_getrq() in correct place
2018-10-23 14:30 [PATCH] blk-mq: place trace_block_getrq() in correct place Xiaoguang Wang
@ 2018-10-24 1:30 ` jianchao.wang
2018-10-24 9:29 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: jianchao.wang @ 2018-10-24 1:30 UTC (permalink / raw)
To: Xiaoguang Wang, linux-block; +Cc: axboe
On 10/23/18 10:30 PM, Xiaoguang Wang wrote:
> trace_block_getrq() is to indicate a request struct has been allcoated
> for queue, so put it in right place.
>
> Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
> ---
> block/blk-mq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index e3c39ea8e17b..93aec25f1340 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1833,8 +1833,6 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
>
> rq_qos_throttle(q, bio, NULL);
>
> - trace_block_getrq(q, bio, bio->bi_opf);
> -
> rq = blk_mq_get_request(q, bio, bio->bi_opf, &data);
> if (unlikely(!rq)) {
> rq_qos_cleanup(q, bio);
> @@ -1843,6 +1841,8 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
> return BLK_QC_T_NONE;
> }
>
> + trace_block_getrq(q, bio, bio->bi_opf);
> +
> rq_qos_track(q, rq, bio);
>
> cookie = request_to_qc_t(data.hctx, rq);
>
Looks fine.
Reviewed-by: Jianchao Wang <jianchao.w.wang@oracle.com>
Thanks
Jianchao
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq: place trace_block_getrq() in correct place
2018-10-23 14:30 [PATCH] blk-mq: place trace_block_getrq() in correct place Xiaoguang Wang
2018-10-24 1:30 ` jianchao.wang
@ 2018-10-24 9:29 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-10-24 9:29 UTC (permalink / raw)
To: Xiaoguang Wang, linux-block
On 10/23/18 8:30 AM, Xiaoguang Wang wrote:
> trace_block_getrq() is to indicate a request struct has been allcoated
^^^
allocated
> for queue, so put it in right place.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-24 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 14:30 [PATCH] blk-mq: place trace_block_getrq() in correct place Xiaoguang Wang
2018-10-24 1:30 ` jianchao.wang
2018-10-24 9:29 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.