From: kbuild test robot <lkp@intel.com> To: Jessica Yu <jeyu@kernel.org> Cc: kbuild-all@01.org, Torsten Duwe <duwe@lst.de>, Will Deacon <will.deacon@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Julien Thierry <julien.thierry@arm.com>, Steven Rostedt <rostedt@goodmis.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Ingo Molnar <mingo@redhat.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Arnd Bergmann <arnd@arndb.de>, AKASHI Takahiro <takahiro.akashi@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH] arm64/module: use mod->klp_info section header information Date: Wed, 24 Oct 2018 03:32:11 +0800 [thread overview] Message-ID: <201810240304.xBI18Icm%fengguang.wu@intel.com> (raw) In-Reply-To: <20181023175553.gaobskk26koft6s2@linux-8ccs> [-- Attachment #1: Type: text/plain, Size: 2301 bytes --] Hi Jessica, I love your patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jessica-Yu/arm64-module-use-mod-klp_info-section-header-information/20181024-023709 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core config: x86_64-randconfig-x002-201842 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): kernel/module.c: In function 'post_relocation': >> kernel/module.c:3369:30: warning: passing argument 2 of 'copy_module_elf' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] err = copy_module_elf(mod, info); ^~~~ kernel/module.c:2103:12: note: expected 'struct load_info *' but argument is of type 'const struct load_info *' static int copy_module_elf(struct module *mod, struct load_info *info) ^~~~~~~~~~~~~~~ vim +3369 kernel/module.c 3353 3354 static int post_relocation(struct module *mod, const struct load_info *info) 3355 { 3356 int err; 3357 3358 /* Sort exception table now relocations are done. */ 3359 sort_extable(mod->extable, mod->extable + mod->num_exentries); 3360 3361 /* Copy relocated percpu area over. */ 3362 percpu_modcopy(mod, (void *)info->sechdrs[info->index.pcpu].sh_addr, 3363 info->sechdrs[info->index.pcpu].sh_size); 3364 3365 /* Setup kallsyms-specific fields. */ 3366 add_kallsyms(mod, info); 3367 3368 if (is_livepatch_module(mod)) { > 3369 err = copy_module_elf(mod, info); 3370 if (err < 0) 3371 return err; 3372 } 3373 3374 /* Arch-specific module finalizing. */ 3375 err = module_finalize(info->hdr, info->sechdrs, mod); 3376 if (err < 0) 3377 free_module_elf(mod); 3378 3379 return err; 3380 } 3381 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 31980 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: lkp@intel.com (kbuild test robot) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64/module: use mod->klp_info section header information Date: Wed, 24 Oct 2018 03:32:11 +0800 [thread overview] Message-ID: <201810240304.xBI18Icm%fengguang.wu@intel.com> (raw) In-Reply-To: <20181023175553.gaobskk26koft6s2@linux-8ccs> Hi Jessica, I love your patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jessica-Yu/arm64-module-use-mod-klp_info-section-header-information/20181024-023709 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core config: x86_64-randconfig-x002-201842 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): kernel/module.c: In function 'post_relocation': >> kernel/module.c:3369:30: warning: passing argument 2 of 'copy_module_elf' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] err = copy_module_elf(mod, info); ^~~~ kernel/module.c:2103:12: note: expected 'struct load_info *' but argument is of type 'const struct load_info *' static int copy_module_elf(struct module *mod, struct load_info *info) ^~~~~~~~~~~~~~~ vim +3369 kernel/module.c 3353 3354 static int post_relocation(struct module *mod, const struct load_info *info) 3355 { 3356 int err; 3357 3358 /* Sort exception table now relocations are done. */ 3359 sort_extable(mod->extable, mod->extable + mod->num_exentries); 3360 3361 /* Copy relocated percpu area over. */ 3362 percpu_modcopy(mod, (void *)info->sechdrs[info->index.pcpu].sh_addr, 3363 info->sechdrs[info->index.pcpu].sh_size); 3364 3365 /* Setup kallsyms-specific fields. */ 3366 add_kallsyms(mod, info); 3367 3368 if (is_livepatch_module(mod)) { > 3369 err = copy_module_elf(mod, info); 3370 if (err < 0) 3371 return err; 3372 } 3373 3374 /* Arch-specific module finalizing. */ 3375 err = module_finalize(info->hdr, info->sechdrs, mod); 3376 if (err < 0) 3377 free_module_elf(mod); 3378 3379 return err; 3380 } 3381 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -------------- next part -------------- A non-text attachment was scrubbed... Name: .config.gz Type: application/gzip Size: 31980 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181024/ea28058b/attachment-0001.gz>
next prev parent reply other threads:[~2018-10-23 19:33 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-01 14:09 [PATCH v3 0/4] arm64 live patching Torsten Duwe 2018-10-01 14:09 ` Torsten Duwe 2018-10-01 14:16 ` [PATCH v3 1/4] DYNAMIC_FTRACE configurable with and without REGS Torsten Duwe 2018-10-01 14:16 ` Torsten Duwe 2018-10-01 14:52 ` Ard Biesheuvel 2018-10-01 14:52 ` Ard Biesheuvel 2018-10-01 15:03 ` Torsten Duwe 2018-10-01 15:03 ` Torsten Duwe 2018-10-01 15:06 ` Ard Biesheuvel 2018-10-01 15:06 ` Ard Biesheuvel 2018-10-01 15:10 ` Torsten Duwe 2018-10-01 15:10 ` Torsten Duwe 2018-10-01 15:14 ` Steven Rostedt 2018-10-01 15:14 ` Steven Rostedt 2018-10-01 14:16 ` [PATCH v3 2/4] arm64: implement ftrace with regs Torsten Duwe 2018-10-01 14:16 ` Torsten Duwe 2018-10-01 15:57 ` Ard Biesheuvel 2018-10-01 15:57 ` Ard Biesheuvel 2018-10-02 10:02 ` Torsten Duwe 2018-10-02 10:02 ` Torsten Duwe 2018-10-02 10:39 ` Ard Biesheuvel 2018-10-02 10:39 ` Ard Biesheuvel 2018-10-02 11:27 ` Mark Rutland 2018-10-02 11:27 ` Mark Rutland 2018-10-02 12:18 ` Torsten Duwe 2018-10-02 12:18 ` Torsten Duwe 2018-10-02 12:57 ` Mark Rutland 2018-10-02 12:57 ` Mark Rutland 2018-10-01 14:16 ` [PATCH v3 3/4] arm64: implement live patching Torsten Duwe 2018-10-01 14:16 ` Torsten Duwe 2018-10-17 13:39 ` Miroslav Benes 2018-10-17 13:39 ` Miroslav Benes 2018-10-18 12:58 ` Jessica Yu 2018-10-18 12:58 ` Jessica Yu 2018-10-19 11:59 ` Miroslav Benes 2018-10-19 11:59 ` Miroslav Benes 2018-10-19 12:18 ` Jessica Yu 2018-10-19 12:18 ` Jessica Yu 2018-10-19 15:14 ` Miroslav Benes 2018-10-19 15:14 ` Miroslav Benes 2018-10-19 13:46 ` Torsten Duwe 2018-10-19 13:46 ` Torsten Duwe 2018-10-19 13:52 ` Ard Biesheuvel 2018-10-19 13:52 ` Ard Biesheuvel 2018-10-19 15:21 ` Miroslav Benes 2018-10-19 15:21 ` Miroslav Benes 2018-10-20 14:10 ` Ard Biesheuvel 2018-10-20 14:10 ` Ard Biesheuvel 2018-10-22 12:53 ` Miroslav Benes 2018-10-22 12:53 ` Miroslav Benes 2018-10-22 14:54 ` Torsten Duwe 2018-10-22 14:54 ` Torsten Duwe 2018-10-23 17:55 ` [PATCH] arm64/module: use mod->klp_info section header information Jessica Yu 2018-10-23 17:55 ` Jessica Yu 2018-10-23 19:32 ` kbuild test robot [this message] 2018-10-23 19:32 ` kbuild test robot 2018-10-24 11:57 ` Miroslav Benes 2018-10-24 11:57 ` Miroslav Benes 2018-10-25 8:08 ` Petr Mladek 2018-10-25 8:08 ` Petr Mladek 2018-10-25 9:00 ` Miroslav Benes 2018-10-25 9:00 ` Miroslav Benes 2018-10-25 11:42 ` Jessica Yu 2018-10-25 11:42 ` Jessica Yu 2018-10-26 17:25 ` [PATCH v2] arm64/module: use mod->klp_info section header information for livepatch modules Jessica Yu 2018-10-26 17:25 ` Jessica Yu 2018-10-29 13:24 ` Miroslav Benes 2018-10-29 13:24 ` Miroslav Benes 2018-10-29 13:32 ` Jessica Yu 2018-10-29 13:32 ` Jessica Yu 2018-10-29 15:28 ` Will Deacon 2018-10-29 15:28 ` Will Deacon 2018-10-30 13:19 ` Jessica Yu 2018-10-30 13:19 ` Jessica Yu 2018-11-01 15:18 ` Miroslav Benes 2018-11-01 15:18 ` Miroslav Benes 2018-11-01 16:07 ` Will Deacon 2018-11-01 16:07 ` Will Deacon 2018-11-05 12:30 ` Ard Biesheuvel 2018-11-05 12:30 ` Ard Biesheuvel 2018-11-05 17:57 ` [PATCH] arm64/module: use plt section indices for relocations Jessica Yu 2018-11-05 17:57 ` Jessica Yu 2018-11-05 18:04 ` Ard Biesheuvel 2018-11-05 18:04 ` Ard Biesheuvel 2018-11-05 18:53 ` [PATCH v2] " Jessica Yu 2018-11-05 18:53 ` Jessica Yu 2018-11-05 18:56 ` Ard Biesheuvel 2018-11-05 18:56 ` Ard Biesheuvel 2018-11-05 19:26 ` Will Deacon 2018-11-05 19:26 ` Will Deacon 2018-11-05 19:49 ` Jessica Yu 2018-11-05 19:49 ` Jessica Yu 2018-11-06 9:44 ` Miroslav Benes 2018-11-06 9:44 ` Miroslav Benes 2018-10-01 14:16 ` [PATCH v3 4/4] arm64: reliable stacktraces Torsten Duwe 2018-10-01 14:16 ` Torsten Duwe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201810240304.xBI18Icm%fengguang.wu@intel.com \ --to=lkp@intel.com \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=duwe@lst.de \ --cc=jeyu@kernel.org \ --cc=jpoimboe@redhat.com \ --cc=julien.thierry@arm.com \ --cc=kbuild-all@01.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=live-patching@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=rostedt@goodmis.org \ --cc=takahiro.akashi@linaro.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.