All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: replace gpio-key, wakeup with wakeup-source property
@ 2018-10-24 11:45 ` Sudeep Holla
  0 siblings, 0 replies; 18+ messages in thread
From: Sudeep Holla @ 2018-10-24 11:45 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel
  Cc: Alexandre Belloni, Sascha Hauer, Michal Simek, Sudeep Holla,
	Fabio Estevam, Shawn Guo, Peter Rosin

Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
properties are already replaced with "wakeup-source". However few
occurrences of old property has popped up again, probably from the
remnants in downstream trees.

This patch replaces the legacy properties with the unified
"wakeup-source" property.

Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Rosin <peda@axentia.se>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
 arch/arm/boot/dts/at91-wb45n.dts            | 2 +-
 arch/arm/boot/dts/at91-wb50n.dts            | 4 ++--
 arch/arm/boot/dts/imx6q-pistachio.dts       | 2 +-
 arch/arm/boot/dts/imx6sll-evk.dts           | 2 +-
 arch/arm/boot/dts/zynq-zturn.dts            | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

Hi all,

If possible and if ARM SoC agrees, I would prefer to keep this as
simple one patch instead of splitting into 3 different once and push as
a fix.

Regards,
Sudeep

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index af9f38456d04..375f54010b79 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -62,7 +62,7 @@
 		wakeup {
 			label = "Wakeup";
 			linux,code = <10>;
-			gpio-key,wakeup;
+			wakeup-source;
 			gpios = <&pioB 27 GPIO_ACTIVE_LOW>;
 		};
 	};
diff --git a/arch/arm/boot/dts/at91-wb45n.dts b/arch/arm/boot/dts/at91-wb45n.dts
index 5b9512a6c89c..54d130c92185 100644
--- a/arch/arm/boot/dts/at91-wb45n.dts
+++ b/arch/arm/boot/dts/at91-wb45n.dts
@@ -22,7 +22,7 @@
 			label = "IRQBTN";
 			linux,code = <99>;
 			gpios = <&pioB 18 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup = <1>;
+			wakeup-source;
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
index 8cecc7051a86..a5e45bb95c04 100644
--- a/arch/arm/boot/dts/at91-wb50n.dts
+++ b/arch/arm/boot/dts/at91-wb50n.dts
@@ -23,7 +23,7 @@
 			label = "BTNESC";
 			linux,code = <1>; /* ESC button */
 			gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup = <1>;
+			wakeup-source;
 		};

 		irqbtn@31 {
@@ -31,7 +31,7 @@
 			label = "IRQBTN";
 			linux,code = <99>; /* SysReq button */
 			gpios = <&pioE 31 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup = <1>;
+			wakeup-source;
 		};
 	};

diff --git a/arch/arm/boot/dts/imx6q-pistachio.dts b/arch/arm/boot/dts/imx6q-pistachio.dts
index a31e83cd07a3..8f4b60dd819c 100644
--- a/arch/arm/boot/dts/imx6q-pistachio.dts
+++ b/arch/arm/boot/dts/imx6q-pistachio.dts
@@ -102,7 +102,7 @@
 		power {
 			label = "Power Button";
 			gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup;
+			wakeup-source;
 			linux,code = <KEY_POWER>;
 		};
 	};
diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index c8e115564ba2..30b5d63ed319 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -296,7 +296,7 @@
 	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
 	cd-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
 	keep-power-in-suspend;
-	enable-sdio-wakeup;
+	wakeup-source;
 	vmmc-supply = <&reg_sd3_vmmc>;
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
index b38704657960..5ec616ebca08 100644
--- a/arch/arm/boot/dts/zynq-zturn.dts
+++ b/arch/arm/boot/dts/zynq-zturn.dts
@@ -54,7 +54,7 @@
 			label = "K1";
 			gpios = <&gpio0 0x32 0x1>;
 			linux,code = <0x66>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
--
2.17.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH] ARM: dts: replace gpio-key, wakeup with wakeup-source property
@ 2018-10-24 11:45 ` Sudeep Holla
  0 siblings, 0 replies; 18+ messages in thread
From: Sudeep Holla @ 2018-10-24 11:45 UTC (permalink / raw)
  To: linux-arm-kernel

Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
properties are already replaced with "wakeup-source". However few
occurrences of old property has popped up again, probably from the
remnants in downstream trees.

This patch replaces the legacy properties with the unified
"wakeup-source" property.

Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Rosin <peda@axentia.se>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
 arch/arm/boot/dts/at91-wb45n.dts            | 2 +-
 arch/arm/boot/dts/at91-wb50n.dts            | 4 ++--
 arch/arm/boot/dts/imx6q-pistachio.dts       | 2 +-
 arch/arm/boot/dts/imx6sll-evk.dts           | 2 +-
 arch/arm/boot/dts/zynq-zturn.dts            | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

Hi all,

If possible and if ARM SoC agrees, I would prefer to keep this as
simple one patch instead of splitting into 3 different once and push as
a fix.

Regards,
Sudeep

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index af9f38456d04..375f54010b79 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -62,7 +62,7 @@
 		wakeup {
 			label = "Wakeup";
 			linux,code = <10>;
-			gpio-key,wakeup;
+			wakeup-source;
 			gpios = <&pioB 27 GPIO_ACTIVE_LOW>;
 		};
 	};
diff --git a/arch/arm/boot/dts/at91-wb45n.dts b/arch/arm/boot/dts/at91-wb45n.dts
index 5b9512a6c89c..54d130c92185 100644
--- a/arch/arm/boot/dts/at91-wb45n.dts
+++ b/arch/arm/boot/dts/at91-wb45n.dts
@@ -22,7 +22,7 @@
 			label = "IRQBTN";
 			linux,code = <99>;
 			gpios = <&pioB 18 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup = <1>;
+			wakeup-source;
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
index 8cecc7051a86..a5e45bb95c04 100644
--- a/arch/arm/boot/dts/at91-wb50n.dts
+++ b/arch/arm/boot/dts/at91-wb50n.dts
@@ -23,7 +23,7 @@
 			label = "BTNESC";
 			linux,code = <1>; /* ESC button */
 			gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup = <1>;
+			wakeup-source;
 		};

 		irqbtn at 31 {
@@ -31,7 +31,7 @@
 			label = "IRQBTN";
 			linux,code = <99>; /* SysReq button */
 			gpios = <&pioE 31 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup = <1>;
+			wakeup-source;
 		};
 	};

diff --git a/arch/arm/boot/dts/imx6q-pistachio.dts b/arch/arm/boot/dts/imx6q-pistachio.dts
index a31e83cd07a3..8f4b60dd819c 100644
--- a/arch/arm/boot/dts/imx6q-pistachio.dts
+++ b/arch/arm/boot/dts/imx6q-pistachio.dts
@@ -102,7 +102,7 @@
 		power {
 			label = "Power Button";
 			gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
-			gpio-key,wakeup;
+			wakeup-source;
 			linux,code = <KEY_POWER>;
 		};
 	};
diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index c8e115564ba2..30b5d63ed319 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -296,7 +296,7 @@
 	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
 	cd-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
 	keep-power-in-suspend;
-	enable-sdio-wakeup;
+	wakeup-source;
 	vmmc-supply = <&reg_sd3_vmmc>;
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
index b38704657960..5ec616ebca08 100644
--- a/arch/arm/boot/dts/zynq-zturn.dts
+++ b/arch/arm/boot/dts/zynq-zturn.dts
@@ -54,7 +54,7 @@
 			label = "K1";
 			gpios = <&gpio0 0x32 0x1>;
 			linux,code = <0x66>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
--
2.17.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH] arm64: dts: zynqmp: replace gpio-key, wakeup with wakeup-source property
  2018-10-24 11:45 ` Sudeep Holla
@ 2018-10-24 11:45   ` Sudeep Holla
  -1 siblings, 0 replies; 18+ messages in thread
From: Sudeep Holla @ 2018-10-24 11:45 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel; +Cc: Michal Simek, Sudeep Holla

Most of the legacy "gpio-key,wakeup" boolean property is already
replaced with "wakeup-source". However few occurrences of old property
has popped up again, probably from the remnants in downstream trees.

This patch replaces the legacy properties with the unified
"wakeup-source" property.

Cc: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
 arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 +-
 arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 2 +-
 arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index eb5e8bddb610..527b4d0f88e2 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -49,7 +49,7 @@
 			label = "sw4";
 			gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index 25dd57485323..0397bf66b2e7 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -46,7 +46,7 @@
 			label = "sw19";
 			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_DOWN>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
index 259f21b0c001..7238f022a671 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
@@ -46,7 +46,7 @@
 			label = "sw19";
 			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_DOWN>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
index a61b3cc6f4c9..fa055e718d4b 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
@@ -46,7 +46,7 @@
 			label = "sw19";
 			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_DOWN>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
--
2.17.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH] arm64: dts: zynqmp: replace gpio-key, wakeup with wakeup-source property
@ 2018-10-24 11:45   ` Sudeep Holla
  0 siblings, 0 replies; 18+ messages in thread
From: Sudeep Holla @ 2018-10-24 11:45 UTC (permalink / raw)
  To: linux-arm-kernel

Most of the legacy "gpio-key,wakeup" boolean property is already
replaced with "wakeup-source". However few occurrences of old property
has popped up again, probably from the remnants in downstream trees.

This patch replaces the legacy properties with the unified
"wakeup-source" property.

Cc: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
 arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 +-
 arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 2 +-
 arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index eb5e8bddb610..527b4d0f88e2 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -49,7 +49,7 @@
 			label = "sw4";
 			gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index 25dd57485323..0397bf66b2e7 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -46,7 +46,7 @@
 			label = "sw19";
 			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_DOWN>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
index 259f21b0c001..7238f022a671 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
@@ -46,7 +46,7 @@
 			label = "sw19";
 			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_DOWN>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
index a61b3cc6f4c9..fa055e718d4b 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
@@ -46,7 +46,7 @@
 			label = "sw19";
 			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
 			linux,code = <KEY_DOWN>;
-			gpio-key,wakeup;
+			wakeup-source;
 			autorepeat;
 		};
 	};
--
2.17.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH] ARM: dts: replace gpio-key,wakeup with wakeup-source property
  2018-10-24 11:45 ` Sudeep Holla
@ 2018-10-24 11:51   ` Alexandre Belloni
  -1 siblings, 0 replies; 18+ messages in thread
From: Alexandre Belloni @ 2018-10-24 11:51 UTC (permalink / raw)
  To: Sudeep Holla
  Cc: devicetree, Sascha Hauer, Michal Simek, Fabio Estevam, Shawn Guo,
	Peter Rosin, linux-arm-kernel

On 24/10/2018 12:45:39+0100, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
>  arch/arm/boot/dts/at91-wb45n.dts            | 2 +-
>  arch/arm/boot/dts/at91-wb50n.dts            | 4 ++--
>  arch/arm/boot/dts/imx6q-pistachio.dts       | 2 +-
>  arch/arm/boot/dts/imx6sll-evk.dts           | 2 +-
>  arch/arm/boot/dts/zynq-zturn.dts            | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)
> 
> Hi all,
> 
> If possible and if ARM SoC agrees, I would prefer to keep this as
> simple one patch instead of splitting into 3 different once and push as
> a fix.
> 
> Regards,
> Sudeep
> 
> diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> index af9f38456d04..375f54010b79 100644
> --- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> +++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> @@ -62,7 +62,7 @@
>  		wakeup {
>  			label = "Wakeup";
>  			linux,code = <10>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			gpios = <&pioB 27 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/at91-wb45n.dts b/arch/arm/boot/dts/at91-wb45n.dts
> index 5b9512a6c89c..54d130c92185 100644
> --- a/arch/arm/boot/dts/at91-wb45n.dts
> +++ b/arch/arm/boot/dts/at91-wb45n.dts
> @@ -22,7 +22,7 @@
>  			label = "IRQBTN";
>  			linux,code = <99>;
>  			gpios = <&pioB 18 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup = <1>;
> +			wakeup-source;
>  		};
>  	};
>  };
> diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
> index 8cecc7051a86..a5e45bb95c04 100644
> --- a/arch/arm/boot/dts/at91-wb50n.dts
> +++ b/arch/arm/boot/dts/at91-wb50n.dts
> @@ -23,7 +23,7 @@
>  			label = "BTNESC";
>  			linux,code = <1>; /* ESC button */
>  			gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup = <1>;
> +			wakeup-source;
>  		};
> 
>  		irqbtn@31 {
> @@ -31,7 +31,7 @@
>  			label = "IRQBTN";
>  			linux,code = <99>; /* SysReq button */
>  			gpios = <&pioE 31 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup = <1>;
> +			wakeup-source;
>  		};
>  	};
> 
> diff --git a/arch/arm/boot/dts/imx6q-pistachio.dts b/arch/arm/boot/dts/imx6q-pistachio.dts
> index a31e83cd07a3..8f4b60dd819c 100644
> --- a/arch/arm/boot/dts/imx6q-pistachio.dts
> +++ b/arch/arm/boot/dts/imx6q-pistachio.dts
> @@ -102,7 +102,7 @@
>  		power {
>  			label = "Power Button";
>  			gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			linux,code = <KEY_POWER>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
> index c8e115564ba2..30b5d63ed319 100644
> --- a/arch/arm/boot/dts/imx6sll-evk.dts
> +++ b/arch/arm/boot/dts/imx6sll-evk.dts
> @@ -296,7 +296,7 @@
>  	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
>  	cd-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
>  	keep-power-in-suspend;
> -	enable-sdio-wakeup;
> +	wakeup-source;
>  	vmmc-supply = <&reg_sd3_vmmc>;
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
> index b38704657960..5ec616ebca08 100644
> --- a/arch/arm/boot/dts/zynq-zturn.dts
> +++ b/arch/arm/boot/dts/zynq-zturn.dts
> @@ -54,7 +54,7 @@
>  			label = "K1";
>  			gpios = <&gpio0 0x32 0x1>;
>  			linux,code = <0x66>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> --
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] ARM: dts: replace gpio-key,wakeup with wakeup-source property
@ 2018-10-24 11:51   ` Alexandre Belloni
  0 siblings, 0 replies; 18+ messages in thread
From: Alexandre Belloni @ 2018-10-24 11:51 UTC (permalink / raw)
  To: linux-arm-kernel

On 24/10/2018 12:45:39+0100, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
>  arch/arm/boot/dts/at91-wb45n.dts            | 2 +-
>  arch/arm/boot/dts/at91-wb50n.dts            | 4 ++--
>  arch/arm/boot/dts/imx6q-pistachio.dts       | 2 +-
>  arch/arm/boot/dts/imx6sll-evk.dts           | 2 +-
>  arch/arm/boot/dts/zynq-zturn.dts            | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)
> 
> Hi all,
> 
> If possible and if ARM SoC agrees, I would prefer to keep this as
> simple one patch instead of splitting into 3 different once and push as
> a fix.
> 
> Regards,
> Sudeep
> 
> diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> index af9f38456d04..375f54010b79 100644
> --- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> +++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> @@ -62,7 +62,7 @@
>  		wakeup {
>  			label = "Wakeup";
>  			linux,code = <10>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			gpios = <&pioB 27 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/at91-wb45n.dts b/arch/arm/boot/dts/at91-wb45n.dts
> index 5b9512a6c89c..54d130c92185 100644
> --- a/arch/arm/boot/dts/at91-wb45n.dts
> +++ b/arch/arm/boot/dts/at91-wb45n.dts
> @@ -22,7 +22,7 @@
>  			label = "IRQBTN";
>  			linux,code = <99>;
>  			gpios = <&pioB 18 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup = <1>;
> +			wakeup-source;
>  		};
>  	};
>  };
> diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
> index 8cecc7051a86..a5e45bb95c04 100644
> --- a/arch/arm/boot/dts/at91-wb50n.dts
> +++ b/arch/arm/boot/dts/at91-wb50n.dts
> @@ -23,7 +23,7 @@
>  			label = "BTNESC";
>  			linux,code = <1>; /* ESC button */
>  			gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup = <1>;
> +			wakeup-source;
>  		};
> 
>  		irqbtn at 31 {
> @@ -31,7 +31,7 @@
>  			label = "IRQBTN";
>  			linux,code = <99>; /* SysReq button */
>  			gpios = <&pioE 31 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup = <1>;
> +			wakeup-source;
>  		};
>  	};
> 
> diff --git a/arch/arm/boot/dts/imx6q-pistachio.dts b/arch/arm/boot/dts/imx6q-pistachio.dts
> index a31e83cd07a3..8f4b60dd819c 100644
> --- a/arch/arm/boot/dts/imx6q-pistachio.dts
> +++ b/arch/arm/boot/dts/imx6q-pistachio.dts
> @@ -102,7 +102,7 @@
>  		power {
>  			label = "Power Button";
>  			gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			linux,code = <KEY_POWER>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
> index c8e115564ba2..30b5d63ed319 100644
> --- a/arch/arm/boot/dts/imx6sll-evk.dts
> +++ b/arch/arm/boot/dts/imx6sll-evk.dts
> @@ -296,7 +296,7 @@
>  	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
>  	cd-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
>  	keep-power-in-suspend;
> -	enable-sdio-wakeup;
> +	wakeup-source;
>  	vmmc-supply = <&reg_sd3_vmmc>;
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
> index b38704657960..5ec616ebca08 100644
> --- a/arch/arm/boot/dts/zynq-zturn.dts
> +++ b/arch/arm/boot/dts/zynq-zturn.dts
> @@ -54,7 +54,7 @@
>  			label = "K1";
>  			gpios = <&gpio0 0x32 0x1>;
>  			linux,code = <0x66>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> --
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] ARM: dts: replace gpio-key, wakeup with wakeup-source property
  2018-10-24 11:45 ` Sudeep Holla
@ 2018-10-24 12:03   ` Fabio Estevam
  -1 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2018-10-24 12:03 UTC (permalink / raw)
  To: Sudeep Holla
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	alexandre.belloni, Sascha Hauer, Michal Simek, Fabio Estevam,
	Shawn Guo, Peter Rosin,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

On Wed, Oct 24, 2018 at 8:47 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
>
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] ARM: dts: replace gpio-key, wakeup with wakeup-source property
@ 2018-10-24 12:03   ` Fabio Estevam
  0 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2018-10-24 12:03 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 24, 2018 at 8:47 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
>
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] ARM: dts: replace gpio-key,wakeup with wakeup-source property
  2018-10-24 11:45 ` Sudeep Holla
@ 2018-10-24 13:43   ` Peter Rosin
  -1 siblings, 0 replies; 18+ messages in thread
From: Peter Rosin @ 2018-10-24 13:43 UTC (permalink / raw)
  To: Sudeep Holla, devicetree, linux-arm-kernel
  Cc: Alexandre Belloni, Sascha Hauer, Michal Simek, Fabio Estevam, Shawn Guo

On 2018-10-24 13:45, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] ARM: dts: replace gpio-key,wakeup with wakeup-source property
@ 2018-10-24 13:43   ` Peter Rosin
  0 siblings, 0 replies; 18+ messages in thread
From: Peter Rosin @ 2018-10-24 13:43 UTC (permalink / raw)
  To: linux-arm-kernel

On 2018-10-24 13:45, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup with wakeup-source property
  2018-10-24 11:45   ` Sudeep Holla
@ 2018-11-05  9:32     ` Michal Simek
  -1 siblings, 0 replies; 18+ messages in thread
From: Michal Simek @ 2018-11-05  9:32 UTC (permalink / raw)
  To: Sudeep Holla, devicetree, linux-arm-kernel; +Cc: Michal Simek

On 24. 10. 18 13:45, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" boolean property is already
> replaced with "wakeup-source". However few occurrences of old property
> has popped up again, probably from the remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index eb5e8bddb610..527b4d0f88e2 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -49,7 +49,7 @@
>  			label = "sw4";
>  			gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
>  			linux,code = <KEY_POWER>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 25dd57485323..0397bf66b2e7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -46,7 +46,7 @@
>  			label = "sw19";
>  			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
>  			linux,code = <KEY_DOWN>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 259f21b0c001..7238f022a671 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -46,7 +46,7 @@
>  			label = "sw19";
>  			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
>  			linux,code = <KEY_DOWN>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> index a61b3cc6f4c9..fa055e718d4b 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> @@ -46,7 +46,7 @@
>  			label = "sw19";
>  			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
>  			linux,code = <KEY_DOWN>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> --
> 2.17.1
> 
> 

Will be good to point to 700a38b27eefc which introduced but that's fine.

Applied.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup with wakeup-source property
@ 2018-11-05  9:32     ` Michal Simek
  0 siblings, 0 replies; 18+ messages in thread
From: Michal Simek @ 2018-11-05  9:32 UTC (permalink / raw)
  To: linux-arm-kernel

On 24. 10. 18 13:45, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" boolean property is already
> replaced with "wakeup-source". However few occurrences of old property
> has popped up again, probably from the remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index eb5e8bddb610..527b4d0f88e2 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -49,7 +49,7 @@
>  			label = "sw4";
>  			gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
>  			linux,code = <KEY_POWER>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 25dd57485323..0397bf66b2e7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -46,7 +46,7 @@
>  			label = "sw19";
>  			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
>  			linux,code = <KEY_DOWN>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 259f21b0c001..7238f022a671 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -46,7 +46,7 @@
>  			label = "sw19";
>  			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
>  			linux,code = <KEY_DOWN>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> index a61b3cc6f4c9..fa055e718d4b 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> @@ -46,7 +46,7 @@
>  			label = "sw19";
>  			gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
>  			linux,code = <KEY_DOWN>;
> -			gpio-key,wakeup;
> +			wakeup-source;
>  			autorepeat;
>  		};
>  	};
> --
> 2.17.1
> 
> 

Will be good to point to 700a38b27eefc which introduced but that's fine.

Applied.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup with wakeup-source property
  2018-11-05  9:32     ` Michal Simek
@ 2018-11-05 11:47       ` Sudeep Holla
  -1 siblings, 0 replies; 18+ messages in thread
From: Sudeep Holla @ 2018-11-05 11:47 UTC (permalink / raw)
  To: Michal Simek, devicetree, linux-arm-kernel; +Cc: Sudeep Holla




On 05/11/2018 09:32, Michal Simek wrote:
> On 24. 10. 18 13:45, Sudeep Holla wrote:
>> Most of the legacy "gpio-key,wakeup" boolean property is already
>> replaced with "wakeup-source". However few occurrences of old property
>> has popped up again, probably from the remnants in downstream trees.
>>
>> This patch replaces the legacy properties with the unified
>> "wakeup-source" property.
>>
> 
> Will be good to point to 700a38b27eefc which introduced but that's fine.
> 

If you prefer, you can add the reference as you have already applied.
I am fine with that. Are you fine with 32-bit change ? I have posted
single patch covering multiple platforms so that I can ask ARM SoC to
pick it. If you can Ack it, I will ask them to pick directly.

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup with wakeup-source property
@ 2018-11-05 11:47       ` Sudeep Holla
  0 siblings, 0 replies; 18+ messages in thread
From: Sudeep Holla @ 2018-11-05 11:47 UTC (permalink / raw)
  To: linux-arm-kernel




On 05/11/2018 09:32, Michal Simek wrote:
> On 24. 10. 18 13:45, Sudeep Holla wrote:
>> Most of the legacy "gpio-key,wakeup" boolean property is already
>> replaced with "wakeup-source". However few occurrences of old property
>> has popped up again, probably from the remnants in downstream trees.
>>
>> This patch replaces the legacy properties with the unified
>> "wakeup-source" property.
>>
> 
> Will be good to point to 700a38b27eefc which introduced but that's fine.
> 

If you prefer, you can add the reference as you have already applied.
I am fine with that. Are you fine with 32-bit change ? I have posted
single patch covering multiple platforms so that I can ask ARM SoC to
pick it. If you can Ack it, I will ask them to pick directly.

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] ARM: dts: replace gpio-key,wakeup with wakeup-source property
  2018-10-24 11:45 ` Sudeep Holla
@ 2018-11-05 12:40   ` Michal Simek
  -1 siblings, 0 replies; 18+ messages in thread
From: Michal Simek @ 2018-11-05 12:40 UTC (permalink / raw)
  To: Sudeep Holla, devicetree, linux-arm-kernel
  Cc: Alexandre Belloni, Sascha Hauer, Michal Simek, Fabio Estevam,
	Shawn Guo, Peter Rosin

On 24. 10. 18 13:45, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
>  arch/arm/boot/dts/at91-wb45n.dts            | 2 +-
>  arch/arm/boot/dts/at91-wb50n.dts            | 4 ++--
>  arch/arm/boot/dts/imx6q-pistachio.dts       | 2 +-
>  arch/arm/boot/dts/imx6sll-evk.dts           | 2 +-
>  arch/arm/boot/dts/zynq-zturn.dts            | 2 +-

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] ARM: dts: replace gpio-key,wakeup with wakeup-source property
@ 2018-11-05 12:40   ` Michal Simek
  0 siblings, 0 replies; 18+ messages in thread
From: Michal Simek @ 2018-11-05 12:40 UTC (permalink / raw)
  To: linux-arm-kernel

On 24. 10. 18 13:45, Sudeep Holla wrote:
> Most of the legacy "gpio-key,wakeup" and "enable-sdio-wakeup" boolean
> properties are already replaced with "wakeup-source". However few
> occurrences of old property has popped up again, probably from the
> remnants in downstream trees.
> 
> This patch replaces the legacy properties with the unified
> "wakeup-source" property.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
>  arch/arm/boot/dts/at91-wb45n.dts            | 2 +-
>  arch/arm/boot/dts/at91-wb50n.dts            | 4 ++--
>  arch/arm/boot/dts/imx6q-pistachio.dts       | 2 +-
>  arch/arm/boot/dts/imx6sll-evk.dts           | 2 +-
>  arch/arm/boot/dts/zynq-zturn.dts            | 2 +-

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup with wakeup-source property
  2018-11-05 11:47       ` Sudeep Holla
@ 2018-11-05 12:43         ` Michal Simek
  -1 siblings, 0 replies; 18+ messages in thread
From: Michal Simek @ 2018-11-05 12:43 UTC (permalink / raw)
  To: Sudeep Holla, Michal Simek, devicetree, linux-arm-kernel

On 05. 11. 18 12:47, Sudeep Holla wrote:
> 
> 
> 
> On 05/11/2018 09:32, Michal Simek wrote:
>> On 24. 10. 18 13:45, Sudeep Holla wrote:
>>> Most of the legacy "gpio-key,wakeup" boolean property is already
>>> replaced with "wakeup-source". However few occurrences of old property
>>> has popped up again, probably from the remnants in downstream trees.
>>>
>>> This patch replaces the legacy properties with the unified
>>> "wakeup-source" property.
>>>
>>
>> Will be good to point to 700a38b27eefc which introduced but that's fine.
>>
> 
> If you prefer, you can add the reference as you have already applied.
> I am fine with that. Are you fine with 32-bit change ? I have posted
> single patch covering multiple platforms so that I can ask ARM SoC to
> pick it. If you can Ack it, I will ask them to pick directly.
> 

32bit version should go directly via arm-soc guys. I have sent you my
review. Also I have updated that commit message to match with sha1 above.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup with wakeup-source property
@ 2018-11-05 12:43         ` Michal Simek
  0 siblings, 0 replies; 18+ messages in thread
From: Michal Simek @ 2018-11-05 12:43 UTC (permalink / raw)
  To: linux-arm-kernel

On 05. 11. 18 12:47, Sudeep Holla wrote:
> 
> 
> 
> On 05/11/2018 09:32, Michal Simek wrote:
>> On 24. 10. 18 13:45, Sudeep Holla wrote:
>>> Most of the legacy "gpio-key,wakeup" boolean property is already
>>> replaced with "wakeup-source". However few occurrences of old property
>>> has popped up again, probably from the remnants in downstream trees.
>>>
>>> This patch replaces the legacy properties with the unified
>>> "wakeup-source" property.
>>>
>>
>> Will be good to point to 700a38b27eefc which introduced but that's fine.
>>
> 
> If you prefer, you can add the reference as you have already applied.
> I am fine with that. Are you fine with 32-bit change ? I have posted
> single patch covering multiple platforms so that I can ask ARM SoC to
> pick it. If you can Ack it, I will ask them to pick directly.
> 

32bit version should go directly via arm-soc guys. I have sent you my
review. Also I have updated that commit message to match with sha1 above.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2018-11-05 12:43 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 11:45 [PATCH] ARM: dts: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2018-10-24 11:45 ` Sudeep Holla
2018-10-24 11:45 ` [PATCH] arm64: dts: zynqmp: " Sudeep Holla
2018-10-24 11:45   ` Sudeep Holla
2018-11-05  9:32   ` [PATCH] arm64: dts: zynqmp: replace gpio-key,wakeup " Michal Simek
2018-11-05  9:32     ` Michal Simek
2018-11-05 11:47     ` Sudeep Holla
2018-11-05 11:47       ` Sudeep Holla
2018-11-05 12:43       ` Michal Simek
2018-11-05 12:43         ` Michal Simek
2018-10-24 11:51 ` [PATCH] ARM: dts: " Alexandre Belloni
2018-10-24 11:51   ` Alexandre Belloni
2018-10-24 12:03 ` [PATCH] ARM: dts: replace gpio-key, wakeup " Fabio Estevam
2018-10-24 12:03   ` Fabio Estevam
2018-10-24 13:43 ` [PATCH] ARM: dts: replace gpio-key,wakeup " Peter Rosin
2018-10-24 13:43   ` Peter Rosin
2018-11-05 12:40 ` Michal Simek
2018-11-05 12:40   ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.