All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists
Date: Thu, 25 Oct 2018 01:43:55 +0200	[thread overview]
Message-ID: <20181025014337.762f7ec9@crub> (raw)
In-Reply-To: <20181024095456.27486-1-peng.fan@nxp.com>

Hi Peng,

On Wed, 24 Oct 2018 09:49:04 +0000
Peng Fan peng.fan at nxp.com wrote:
...
> --- /dev/null
> +++ b/tools/imx8_cntr_image.sh
> @@ -0,0 +1,32 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +# script to generate FIT image source for K3 Family boards with
> +# ATF, OPTEE, SPL and multiple device trees (given on the command line).
> +# Inspired from board/sunxi/mksunxi_fit_atf.sh

Please drop this comment, it doesn't describe what the script is
actually doing.

...
> +file=$1
> +
> +linecount=`cat ${file} | wc -l`
> +
> +for ((i=1; i<=${linecount}; i++));
> +do
[ snip ]

blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ || /^DATA/ {print $3}' $file`
for f in $blobs; do
	if [ ! -f $f ]; then
		echo "WARNING '$f' not found, resulting binary is not-functional"
	fi;
done

will do the checks more efficiently.

Thanks,

Anatolij

  parent reply	other threads:[~2018-10-24 23:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24  9:49 [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists Peng Fan
2018-10-24 14:08 ` Wolfgang Denk
2018-10-25  1:13   ` Peng Fan
2018-10-24 23:43 ` Anatolij Gustschin [this message]
2018-10-25  1:14   ` Peng Fan
2018-10-25  8:25     ` Stefano Babic
2018-10-25  8:27       ` Peng Fan
2018-10-25  8:35         ` Stefano Babic
2018-10-25  8:45           ` Peng Fan
2018-10-25  9:49             ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025014337.762f7ec9@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.