All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists
Date: Thu, 25 Oct 2018 10:35:07 +0200	[thread overview]
Message-ID: <5bfa3050-8b82-f99e-c561-2e2d300ab0fc@denx.de> (raw)
In-Reply-To: <AM0PR04MB4481380AEDC11189029566D388F70@AM0PR04MB4481.eurprd04.prod.outlook.com>

On 25/10/18 10:27, Peng Fan wrote:
> 
> 
>> -----Original Message-----
>> From: Stefano Babic [mailto:sbabic at denx.de]
>> Sent: 2018年10月25日 16:26
>> To: Peng Fan <peng.fan@nxp.com>; Anatolij Gustschin <agust@denx.de>
>> Cc: sbabic at denx.de; u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files
>> not exists
>>
>> Hi Peng,
>>
>> On 25/10/18 03:14, Peng Fan wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Anatolij Gustschin [mailto:agust at denx.de]
>>>> Sent: 2018年10月25日 7:44
>>>> To: Peng Fan <peng.fan@nxp.com>
>>>> Cc: sbabic at denx.de; u-boot at lists.denx.de
>>>> Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when
>>>> required files not exists
>>>>
>>>> Hi Peng,
>>>>
>>>> On Wed, 24 Oct 2018 09:49:04 +0000
>>>> Peng Fan peng.fan at nxp.com wrote:
>>>> ...
>>>>> --- /dev/null
>>>>> +++ b/tools/imx8_cntr_image.sh
>>>>> @@ -0,0 +1,32 @@
>>>>> +#!/bin/sh
>>>>> +# SPDX-License-Identifier: GPL-2.0+ # # script to generate FIT
>>>>> +image source for K3 Family boards with # ATF, OPTEE, SPL and
>>>>> +multiple device trees (given on the command line).
>>>>> +# Inspired from board/sunxi/mksunxi_fit_atf.sh
>>>>
>>>> Please drop this comment, it doesn't describe what the script is actually
>> doing.
>>>
>>> Thanks. Fix in V2.
>>
>> I wanted to send my PR as soon as possible to Tom. I didn't want to block i.MX8
>> merge just for this, and I merged V1 and sent PR.
> 
> No, please not use v1.
> 
> V2 patch will be out soon. It is under CI test. I'll send out now.

Ok, I drop from server and I wait for it.

Thanks,
Stefano

> 
> Thanks,
> Peng.
> 
>>
>> Can you send then a follow-up patch instead of V2 ? V1 is on u-boot-imx, and
>> Tom will merge the tree soon.
>>
>> Best regards,
>> Stefano
>>
>>>
>>>>
>>>> ...
>>>>> +file=$1
>>>>> +
>>>>> +linecount=`cat ${file} | wc -l`
>>>>> +
>>>>> +for ((i=1; i<=${linecount}; i++));
>>>>> +do
>>>> [ snip ]
>>>>
>>>> blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ || /^DATA/ {print $3}'
>>>> $file` for f in $blobs; do
>>>> 	if [ ! -f $f ]; then
>>>> 		echo "WARNING '$f' not found, resulting binary is not-functional"
>>>> 	fi;
>>>> done
>>>>
>>>> will do the checks more efficiently.
>>>
>>> Yes. Simpiler.
>>>
>>> Thanks,
>>> Peng.
>>>
>>>>
>>>> Thanks,
>>>>
>>>> Anatolij
>>
>>
>> --
>> ================================================================
>> =====
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
>> ================================================================
>> =====


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2018-10-25  8:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24  9:49 [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists Peng Fan
2018-10-24 14:08 ` Wolfgang Denk
2018-10-25  1:13   ` Peng Fan
2018-10-24 23:43 ` Anatolij Gustschin
2018-10-25  1:14   ` Peng Fan
2018-10-25  8:25     ` Stefano Babic
2018-10-25  8:27       ` Peng Fan
2018-10-25  8:35         ` Stefano Babic [this message]
2018-10-25  8:45           ` Peng Fan
2018-10-25  9:49             ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bfa3050-8b82-f99e-c561-2e2d300ab0fc@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.