* [PATCH] xen/pvh: don't try to unplug emulated devices
@ 2018-10-25 7:54 Juergen Gross
0 siblings, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2018-10-25 7:54 UTC (permalink / raw)
To: linux-kernel, xen-devel
Cc: Juergen Gross, boris.ostrovsky, sstabellini, stable
A Xen PVH guest has no associated qemu device model, so trying to
unplug any emulated devices is making no sense at all.
Bail out early from xen_unplug_emulated_devices() when running as PVH
guest. This will avoid issuing the boot message:
[ 0.000000] Xen Platform PCI: unrecognised magic value
Cc: <stable@vger.kernel.org> # 4.11
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/xen/platform-pci-unplug.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
index 66ab96a4e2b3..96d7f7d39cb9 100644
--- a/arch/x86/xen/platform-pci-unplug.c
+++ b/arch/x86/xen/platform-pci-unplug.c
@@ -134,6 +134,10 @@ void xen_unplug_emulated_devices(void)
{
int r;
+ /* PVH guests don't have emulated devices. */
+ if (xen_pvh_domain())
+ return;
+
/* user explicitly requested no unplug */
if (xen_emul_unplug & XEN_UNPLUG_NEVER)
return;
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/pvh: don't try to unplug emulated devices
2018-10-25 7:54 Juergen Gross
@ 2018-10-25 12:03 ` Boris Ostrovsky
2018-10-25 12:03 ` Boris Ostrovsky
1 sibling, 0 replies; 4+ messages in thread
From: Boris Ostrovsky @ 2018-10-25 12:03 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel; +Cc: sstabellini, stable
On 10/25/18 3:54 AM, Juergen Gross wrote:
> A Xen PVH guest has no associated qemu device model, so trying to
> unplug any emulated devices is making no sense at all.
>
> Bail out early from xen_unplug_emulated_devices() when running as PVH
> guest. This will avoid issuing the boot message:
>
> [ 0.000000] Xen Platform PCI: unrecognised magic value
>
> Cc: <stable@vger.kernel.org> # 4.11
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/pvh: don't try to unplug emulated devices
2018-10-25 7:54 Juergen Gross
2018-10-25 12:03 ` Boris Ostrovsky
@ 2018-10-25 12:03 ` Boris Ostrovsky
1 sibling, 0 replies; 4+ messages in thread
From: Boris Ostrovsky @ 2018-10-25 12:03 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel; +Cc: sstabellini, stable
On 10/25/18 3:54 AM, Juergen Gross wrote:
> A Xen PVH guest has no associated qemu device model, so trying to
> unplug any emulated devices is making no sense at all.
>
> Bail out early from xen_unplug_emulated_devices() when running as PVH
> guest. This will avoid issuing the boot message:
>
> [ 0.000000] Xen Platform PCI: unrecognised magic value
>
> Cc: <stable@vger.kernel.org> # 4.11
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] xen/pvh: don't try to unplug emulated devices
@ 2018-10-25 7:54 Juergen Gross
2018-10-25 12:03 ` Boris Ostrovsky
2018-10-25 12:03 ` Boris Ostrovsky
0 siblings, 2 replies; 4+ messages in thread
From: Juergen Gross @ 2018-10-25 7:54 UTC (permalink / raw)
To: linux-kernel, xen-devel
Cc: boris.ostrovsky, sstabellini, Juergen Gross, stable
A Xen PVH guest has no associated qemu device model, so trying to
unplug any emulated devices is making no sense at all.
Bail out early from xen_unplug_emulated_devices() when running as PVH
guest. This will avoid issuing the boot message:
[ 0.000000] Xen Platform PCI: unrecognised magic value
Cc: <stable@vger.kernel.org> # 4.11
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/xen/platform-pci-unplug.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
index 66ab96a4e2b3..96d7f7d39cb9 100644
--- a/arch/x86/xen/platform-pci-unplug.c
+++ b/arch/x86/xen/platform-pci-unplug.c
@@ -134,6 +134,10 @@ void xen_unplug_emulated_devices(void)
{
int r;
+ /* PVH guests don't have emulated devices. */
+ if (xen_pvh_domain())
+ return;
+
/* user explicitly requested no unplug */
if (xen_emul_unplug & XEN_UNPLUG_NEVER)
return;
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-25 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 7:54 [PATCH] xen/pvh: don't try to unplug emulated devices Juergen Gross
2018-10-25 7:54 Juergen Gross
2018-10-25 12:03 ` Boris Ostrovsky
2018-10-25 12:03 ` Boris Ostrovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.