All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
	viro@zeniv.linux.org.uk, smfrench@gmail.com, miklos@szeredi.hu,
	linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org,
	linux-man@vger.kernel.org
Subject: Re: [PATCH v3 01/11] VFS move cross device copy_file_range() check into filesystems
Date: Thu, 25 Oct 2018 15:17:52 -0700	[thread overview]
Message-ID: <20181025221752.GM25444@bombadil.infradead.org> (raw)
In-Reply-To: <20181025215147.36248-2-olga.kornievskaia@gmail.com>

On Thu, Oct 25, 2018 at 05:51:36PM -0400, Olga Kornievskaia wrote:
> +--
> +[mandatory]
> +	->copy_file_range() may now be passed files which belong to two
> +	different superblocks of the same file system type or which belong
> +	to two different filesystems types all together. As before, the
> +        destination's copy_file_range() is the function which is called.
> +	If it cannot copy ranges from the source, it should return -EXDEV.

Something weird happened to the indentation here?

> +++ b/Documentation/filesystems/vfs.txt
> @@ -1,5 +1,6 @@
>  
>  	      Overview of the Linux Virtual File System
> +- [fs] nfs: Don't let readdirplus revalidate an inode that was marked as stale (Benjamin Coddington) [1429514 1416532]
>  
>  	Original author: Richard Gooch <rgooch@atnf.csiro.au>
>  

This stray change slipped in.

> @@ -958,7 +959,10 @@ otherwise noted.
>  
>    fallocate: called by the VFS to preallocate blocks or punch a hole.
>  
> -  copy_file_range: called by the copy_file_range(2) system call.
> +  copy_file_range: called by copy_file_range(2) system call. This method
> +		   works on two file descriptors that might reside on
> +		   different superblocks which might belong to file systems
> +		   of different types.

I don't think you need this change at all.

The actual code looks good.

  reply	other threads:[~2018-10-25 22:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 21:51 [PATCH v3 00/11] client-side support for "inter" SSC copy Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 01/11] VFS move cross device copy_file_range() check into filesystems Olga Kornievskaia
2018-10-25 22:17   ` Matthew Wilcox [this message]
2018-10-25 22:52     ` Olga Kornievskaia
2018-10-25 21:51 ` [PATCH 1/1] man-page: copy_file_range(2) allow for cross-device copies Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 02/11] VFS copy_file_range check validity of input source offset Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 03/11] NFS NFSD defining nl4_servers structure needed by both Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 04/11] NFS add COPY_NOTIFY operation Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 05/11] NFS add ca_source_server<> to COPY Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 06/11] NFS also send OFFLOAD_CANCEL to source server Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 07/11] NFS inter ssc open Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 08/11] NFS skip recovery of copy open on dest server Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 09/11] NFS for "inter" copy treat ESTALE as ENOTSUPP Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 10/11] NFS COPY handle ERR_OFFLOAD_DENIED Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 11/11] NFS replace cross device with cross filesystem check in copy_file_range Olga Kornievskaia
2018-10-25 22:27   ` Matthew Wilcox
2018-10-26 12:45     ` Olga Kornievskaia
2018-10-26 12:54       ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025221752.GM25444@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=olga.kornievskaia@gmail.com \
    --cc=smfrench@gmail.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.