All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: trond.myklebust@hammerspace.com,
	Anna Schumaker <anna.schumaker@netapp.com>,
	viro@zeniv.linux.org.uk, Steve French <smfrench@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	linux-nfs <linux-nfs@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-unionfs@vger.kernel.org, linux-man@vger.kernel.org
Subject: Re: [PATCH v3 11/11] NFS replace cross device with cross filesystem check in copy_file_range
Date: Fri, 26 Oct 2018 05:54:43 -0700	[thread overview]
Message-ID: <20181026125443.GR25444@bombadil.infradead.org> (raw)
In-Reply-To: <CAN-5tyEtHdZZ6Rvs+DZWbU9O5MU3hVwvSCsUFx+fjrY7AZ1JMA@mail.gmail.com>

On Fri, Oct 26, 2018 at 08:45:38AM -0400, Olga Kornievskaia wrote:
> On Thu, Oct 25, 2018 at 6:27 PM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Thu, Oct 25, 2018 at 05:51:47PM -0400, Olga Kornievskaia wrote:
> > > -     if (file_in->f_inode->i_sb != file_out->f_inode->i_sb)
> > > +     if (file_in->f_inode->i_sb->s_type != file_out->f_inode->i_sb->s_type)
> >
> > Isn't it simpler to do:
> >
> >         if (file_in->f_inode->i_sb->s_type != &nfs4_fs_type)
> 
> I don't believe that's sufficient. What if "in"  fs was NFS and "out"
> fs was CIFS?

This is the NFS implementation, so you know that 'out' is an NFS file.

> > But now I've done some grepping, and I wonder whether it's possible
> > / desirable to also copy between inodes on a nfs4_remote_fs_type,
> > nfs4_remote_referral_fs_type, nfs4_referral_fs_type or nfs4_xdev_fs_type.
> > I haven't kept up with NFS development for a while, so maybe none of
> > those are possible.
> 
> Thank you for pointing it out. Grepping thru the code, don't believe
> the last one is used but for the migration and replication types, I
> don't know if there are any caveats that would preclude support for
> copy offload I'll check with Chuck Lever. Then the check should be
> that "in" and "out" are any of the 4 NFS types.

      reply	other threads:[~2018-10-26 12:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 21:51 [PATCH v3 00/11] client-side support for "inter" SSC copy Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 01/11] VFS move cross device copy_file_range() check into filesystems Olga Kornievskaia
2018-10-25 22:17   ` Matthew Wilcox
2018-10-25 22:52     ` Olga Kornievskaia
2018-10-25 21:51 ` [PATCH 1/1] man-page: copy_file_range(2) allow for cross-device copies Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 02/11] VFS copy_file_range check validity of input source offset Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 03/11] NFS NFSD defining nl4_servers structure needed by both Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 04/11] NFS add COPY_NOTIFY operation Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 05/11] NFS add ca_source_server<> to COPY Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 06/11] NFS also send OFFLOAD_CANCEL to source server Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 07/11] NFS inter ssc open Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 08/11] NFS skip recovery of copy open on dest server Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 09/11] NFS for "inter" copy treat ESTALE as ENOTSUPP Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 10/11] NFS COPY handle ERR_OFFLOAD_DENIED Olga Kornievskaia
2018-10-25 21:51 ` [PATCH v3 11/11] NFS replace cross device with cross filesystem check in copy_file_range Olga Kornievskaia
2018-10-25 22:27   ` Matthew Wilcox
2018-10-26 12:45     ` Olga Kornievskaia
2018-10-26 12:54       ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026125443.GR25444@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=olga.kornievskaia@gmail.com \
    --cc=smfrench@gmail.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.