[Buildroot] [PATCH] configs/{at91sam9*, atmel*}: drop OpenSSH as it duplicates Dropbear

[Buildroot] [PATCH] configs/{at91sam9*, atmel*}: drop OpenSSH as it duplicates Dropbear

[Thomas Petazzoni]

The "development" defconfigs for Atmel platforms enable both OpenSSH
and Dropbear, which doesn't make a lot of sense, as only one SSH
server can start on port 22.

This commit therefore drops BR2_PACKAGE_OPENSSH=y from those
defconfigs, keeping Dropbear as an SSH server/client.

However, since BR2_PACKAGE_OPENSSH=y was enabling OpenSSL, we keep
BR2_PACKAGE_OPENSSL=y enable to preserve SSL support in other packages
(for example "wget").

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Joshua Henderson <joshua.henderson@microchip.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
---
 configs/at91sam9x5ek_dev_defconfig               | 2 +-
 configs/at91sam9x5ek_mmc_dev_defconfig           | 2 +-
 configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig | 2 +-
 configs/atmel_sama5d2_xplained_mmc_dev_defconfig | 2 +-
 configs/atmel_sama5d3_xplained_dev_defconfig     | 2 +-
 configs/atmel_sama5d3_xplained_mmc_dev_defconfig | 2 +-
 configs/atmel_sama5d4_xplained_dev_defconfig     | 2 +-
 configs/atmel_sama5d4_xplained_mmc_dev_defconfig | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/configs/at91sam9x5ek_dev_defconfig b/configs/at91sam9x5ek_dev_defconfig
index dee365a56c..2971befa19 100644
--- a/configs/at91sam9x5ek_dev_defconfig
+++ b/configs/at91sam9x5ek_dev_defconfig
@@ -67,7 +67,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/at91sam9x5ek_mmc_dev_defconfig b/configs/at91sam9x5ek_mmc_dev_defconfig
index a8fdad72b7..112146320e 100644
--- a/configs/at91sam9x5ek_mmc_dev_defconfig
+++ b/configs/at91sam9x5ek_mmc_dev_defconfig
@@ -70,7 +70,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
index f3cb11ce70..b32bcd6a28 100644
--- a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
+++ b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
@@ -59,7 +59,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
index 78d082f9cb..0a7685b0b1 100644
--- a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
+++ b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
@@ -73,7 +73,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/atmel_sama5d3_xplained_dev_defconfig b/configs/atmel_sama5d3_xplained_dev_defconfig
index 91ded5bfeb..40f781531d 100644
--- a/configs/atmel_sama5d3_xplained_dev_defconfig
+++ b/configs/atmel_sama5d3_xplained_dev_defconfig
@@ -69,7 +69,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
index 20dc8929ab..c16cb67fd0 100644
--- a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
+++ b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
@@ -72,7 +72,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/atmel_sama5d4_xplained_dev_defconfig b/configs/atmel_sama5d4_xplained_dev_defconfig
index 69a71eb51e..c2e1418431 100644
--- a/configs/atmel_sama5d4_xplained_dev_defconfig
+++ b/configs/atmel_sama5d4_xplained_dev_defconfig
@@ -70,7 +70,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
diff --git a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
index 60692d98cb..9f7318d420 100644
--- a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
+++ b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
@@ -73,7 +73,7 @@ BR2_PACKAGE_IPTABLES=y
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_LRZSZ=y
 BR2_PACKAGE_MII_DIAG=y
-BR2_PACKAGE_OPENSSH=y
+BR2_PACKAGE_OPENSSL=y
 BR2_PACKAGE_WGET=y
 BR2_PACKAGE_WIRELESS_TOOLS=y
 BR2_PACKAGE_WPA_SUPPLICANT=y
-- 
2.14.4

[Buildroot] [PATCH] configs/{at91sam9*, atmel*}: drop OpenSSH as it duplicates Dropbear

[Nicolas.Ferre at microchip.com]

On 26/10/2018 at 11:40, Thomas Petazzoni wrote:
> The "development" defconfigs for Atmel platforms enable both OpenSSH
> and Dropbear, which doesn't make a lot of sense, as only one SSH
> server can start on port 22.
> 
> This commit therefore drops BR2_PACKAGE_OPENSSH=y from those
> defconfigs, keeping Dropbear as an SSH server/client.

A gut feeling is telling me that I would have preferred the other way 
around: Keeping OpenSSH.

Is scp provided by Dropbear?

> However, since BR2_PACKAGE_OPENSSH=y was enabling OpenSSL, we keep
> BR2_PACKAGE_OPENSSL=y enable to preserve SSL support in other packages
> (for example "wget").
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Joshua Henderson <joshua.henderson@microchip.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
>   configs/at91sam9x5ek_dev_defconfig               | 2 +-
>   configs/at91sam9x5ek_mmc_dev_defconfig           | 2 +-
>   configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig | 2 +-
>   configs/atmel_sama5d2_xplained_mmc_dev_defconfig | 2 +-
>   configs/atmel_sama5d3_xplained_dev_defconfig     | 2 +-
>   configs/atmel_sama5d3_xplained_mmc_dev_defconfig | 2 +-
>   configs/atmel_sama5d4_xplained_dev_defconfig     | 2 +-
>   configs/atmel_sama5d4_xplained_mmc_dev_defconfig | 2 +-
>   8 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/configs/at91sam9x5ek_dev_defconfig b/configs/at91sam9x5ek_dev_defconfig
> index dee365a56c..2971befa19 100644
> --- a/configs/at91sam9x5ek_dev_defconfig
> +++ b/configs/at91sam9x5ek_dev_defconfig
> @@ -67,7 +67,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/at91sam9x5ek_mmc_dev_defconfig b/configs/at91sam9x5ek_mmc_dev_defconfig
> index a8fdad72b7..112146320e 100644
> --- a/configs/at91sam9x5ek_mmc_dev_defconfig
> +++ b/configs/at91sam9x5ek_mmc_dev_defconfig
> @@ -70,7 +70,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
> index f3cb11ce70..b32bcd6a28 100644
> --- a/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
> +++ b/configs/atmel_sama5d27_som1_ek_mmc_dev_defconfig
> @@ -59,7 +59,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
> index 78d082f9cb..0a7685b0b1 100644
> --- a/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
> +++ b/configs/atmel_sama5d2_xplained_mmc_dev_defconfig
> @@ -73,7 +73,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/atmel_sama5d3_xplained_dev_defconfig b/configs/atmel_sama5d3_xplained_dev_defconfig
> index 91ded5bfeb..40f781531d 100644
> --- a/configs/atmel_sama5d3_xplained_dev_defconfig
> +++ b/configs/atmel_sama5d3_xplained_dev_defconfig
> @@ -69,7 +69,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
> index 20dc8929ab..c16cb67fd0 100644
> --- a/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
> +++ b/configs/atmel_sama5d3_xplained_mmc_dev_defconfig
> @@ -72,7 +72,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/atmel_sama5d4_xplained_dev_defconfig b/configs/atmel_sama5d4_xplained_dev_defconfig
> index 69a71eb51e..c2e1418431 100644
> --- a/configs/atmel_sama5d4_xplained_dev_defconfig
> +++ b/configs/atmel_sama5d4_xplained_dev_defconfig
> @@ -70,7 +70,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> diff --git a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
> index 60692d98cb..9f7318d420 100644
> --- a/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
> +++ b/configs/atmel_sama5d4_xplained_mmc_dev_defconfig
> @@ -73,7 +73,7 @@ BR2_PACKAGE_IPTABLES=y
>   BR2_PACKAGE_IW=y
>   BR2_PACKAGE_LRZSZ=y
>   BR2_PACKAGE_MII_DIAG=y
> -BR2_PACKAGE_OPENSSH=y
> +BR2_PACKAGE_OPENSSL=y
>   BR2_PACKAGE_WGET=y
>   BR2_PACKAGE_WIRELESS_TOOLS=y
>   BR2_PACKAGE_WPA_SUPPLICANT=y
> 


-- 
Nicolas Ferre

[Buildroot] [PATCH] configs/{at91sam9*, atmel*}: drop OpenSSH as it duplicates Dropbear

[Alexander Dahl]

Hei hei,

On Fri, Oct 26, 2018 at 09:48:44AM +0000, Nicolas.Ferre at microchip.com wrote:
> On 26/10/2018 at 11:40, Thomas Petazzoni wrote:
> > The "development" defconfigs for Atmel platforms enable both OpenSSH
> > and Dropbear, which doesn't make a lot of sense, as only one SSH
> > server can start on port 22.
> > 
> > This commit therefore drops BR2_PACKAGE_OPENSSH=y from those
> > defconfigs, keeping Dropbear as an SSH server/client.
> 
> A gut feeling is telling me that I would have preferred the other way 
> around: Keeping OpenSSH.

I would have opted for Dropbear, too. Especially because old at91
based boards usually don't come with a lot of memory (both RAM and
Flash).

> Is scp provided by Dropbear?

Yes it is. sftp is tricky, however.

Greets
Alex

-- 
/"\ ASCII RIBBON | ?With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.?
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181026/ce44e26a/attachment.asc>

[Buildroot] [PATCH] configs/{at91sam9*, atmel*}: drop OpenSSH as it duplicates Dropbear

[Peter Korsgaard]

>>>>> "Alexander" == Alexander Dahl <post@lespocky.de> writes:

Hi,

 >> Is scp provided by Dropbear?

 > Yes it is. sftp is tricky, however.

server side sftp can be provided by gesftpserver.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] configs/{at91sam9*, atmel*}: drop OpenSSH as it duplicates Dropbear

[Thomas Petazzoni]

Hello,

On Fri, 26 Oct 2018 09:48:44 +0000, Nicolas.Ferre at microchip.com wrote:
> On 26/10/2018 at 11:40, Thomas Petazzoni wrote:
> > The "development" defconfigs for Atmel platforms enable both OpenSSH
> > and Dropbear, which doesn't make a lot of sense, as only one SSH
> > server can start on port 22.
> > 
> > This commit therefore drops BR2_PACKAGE_OPENSSH=y from those
> > defconfigs, keeping Dropbear as an SSH server/client.  
> 
> A gut feeling is telling me that I would have preferred the other way 
> around: Keeping OpenSSH.

I don't really care either way. Those defconfigs already have plenty of
packages enabled anyway (which is the whole point of those defconfigs).

Should I resend a v2 that keeps BR2_PACKAGE_OPENSSH=y and drops
BR2_PACKAGE_DROPBEAR=y ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com