All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio
Date: Fri, 26 Oct 2018 19:56:17 +0300	[thread overview]
Message-ID: <20181026165617.GC9144@intel.com> (raw)
In-Reply-To: <154045022989.5632.11725434520493726099@skylake-alporthouse-com>

On Thu, Oct 25, 2018 at 07:50:29AM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-10-24 17:32:04)
> > Quoting Ville Syrjälä (2018-10-24 17:28:45)
> > > On Wed, Oct 24, 2018 at 04:52:22PM +0100, Chris Wilson wrote:
> > > > Quoting Ville Syrjala (2018-10-24 16:48:24)
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > 
> > > > > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > > > > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > > > > runtime suspend the GPU since the sysfs  power/control for the
> > > > > lpe-audio device no longer exists and the device is considered
> > > > > always active. We can fix this by not marking the device as
> > > > > active.
> > > > 
> > > > Do you also want to send with a HAX patch to force selection of SND_X86
> > > > for CI?
> > > 
> > > Hmm. Would have been a good idea a few minutes ago. Not sure I want
> > > to spam the list again. Depends how long it'll take to adjust the ci
> > > .config I suppose.
> > 
> > Trybot and link to the results?
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3118/issues.html
> 
> The fi-byt-clapper pm tests passed which is the most significant result.
> For enabling LPE audio in CI, it appears we need to trick
> snd_hdmi_lpe_audio.ko into unloading on demand.

Re-ran the test for good measure after fixing the module unload in igt.
Now all green.

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3140/issues.html

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-10-26 16:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 15:48 [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio Ville Syrjala
2018-10-24 15:48 ` [PATCH 2/2] ALSA: x86: Rip out the lpe audio runtime suspend/resume hooks Ville Syrjala
2018-10-25  6:53   ` Chris Wilson
2018-10-24 15:52 ` [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio Chris Wilson
2018-10-24 16:28   ` Ville Syrjälä
2018-10-24 16:32     ` Chris Wilson
2018-10-25  6:50       ` Chris Wilson
2018-10-26 16:56         ` Ville Syrjälä [this message]
2018-10-24 16:09 ` Chris Wilson
2018-10-24 17:02 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
2018-10-24 17:19 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-24 22:08 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-01 15:24 ` [PATCH 1/2] " Ville Syrjälä
2018-11-02  9:31   ` Takashi Iwai
2018-11-02 16:20     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181026165617.GC9144@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.