Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Oct 24, 2018 at 06:48:24PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> "no callbacks"") broke runtime PM with lpe audio. We can no longer
> runtime suspend the GPU since the sysfs  power/control for the
> lpe-audio device no longer exists and the device is considered
> always active. We can fix this by not marking the device as
> active.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Takashi, do you want to take these or should I just smash them
into drm-intel?

> ---
>  sound/x86/intel_hdmi_audio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index 83d76c345940..bbed4acaafd1 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -1877,7 +1877,6 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
>  
>  	pm_runtime_use_autosuspend(&pdev->dev);
>  	pm_runtime_mark_last_busy(&pdev->dev);
> -	pm_runtime_set_active(&pdev->dev);
>  
>  	dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
>  	for_each_port(card_ctx, port) {
> -- 
> 2.18.1

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx