[igt-dev] [PATCH i-g-t] tests/kms_content_protection: restore for real before failing

[igt-dev] [PATCH i-g-t] tests/kms_content_protection: restore for real before failing

[Daniel Vetter]

Nothing happens if you don't commit ...

v2: rebased!?

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108550
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108549
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_content_protection.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
index 1e7d2b9e4e69..801eff66c272 100644
--- a/tests/kms_content_protection.c
+++ b/tests/kms_content_protection.c
@@ -175,12 +175,11 @@ test_cp_enable_disable(const enum pipe pipe, igt_output_t *output,
 	 * "content protection" at "UNDESIRED".
 	 */
 	igt_output_set_prop_value(output, IGT_CONNECTOR_CONTENT_PROTECTION, 0);
-
-	igt_assert_f(ret, "Content Protection not enabled\n");
-
 	igt_plane_set_fb(primary, &red);
 	igt_display_commit2(display, s);
 
+	igt_assert_f(ret, "Content Protection not enabled\n");
+
 	/* Wait for HDCP to be disabled, before crtc off */
 	wait_for_prop_value(output, 0, 1000);
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_content_protection: restore for real before failing (rev2)

[Patchwork]

== Series Details ==

Series: tests/kms_content_protection: restore for real before failing (rev2)
URL   : https://patchwork.freedesktop.org/series/51604/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5042 -> IGTPW_2005 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51604/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_2005 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#108070)

    igt@drv_selftest@live_contexts:
      fi-icl-u2:          NOTRUN -> DMESG-FAIL (fdo#108569)

    igt@gem_exec_suspend@basic-s3:
      fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#106612)
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_chamelium@hdmi-hpd-fast:
      fi-icl-u2:          NOTRUN -> FAIL (fdo#108559) +3

    igt@kms_flip@basic-flip-vs-dpms:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106238)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_frontbuffer_tracking@basic:
      fi-icl-u:           PASS -> FAIL (fdo#103167)

    igt@pm_rpm@module-reload:
      fi-glk-j4005:       PASS -> FAIL (fdo#104767)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7560u:       INCOMPLETE (fdo#108044) -> PASS

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       FAIL (fdo#100368) -> PASS

    igt@kms_flip@basic-plain-flip:
      fi-glk-j4005:       DMESG-WARN (fdo#106097) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-icl-u:           INCOMPLETE (fdo#107713) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#104767 https://bugs.freedesktop.org/show_bug.cgi?id=104767
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
  fdo#106238 https://bugs.freedesktop.org/show_bug.cgi?id=106238
  fdo#106612 https://bugs.freedesktop.org/show_bug.cgi?id=106612
  fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#108044 https://bugs.freedesktop.org/show_bug.cgi?id=108044
  fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070
  fdo#108559 https://bugs.freedesktop.org/show_bug.cgi?id=108559
  fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569


== Participating hosts (48 -> 39) ==

  Additional (5): fi-icl-u2 fi-cfl-8109u fi-ivb-3770 fi-pnv-d510 fi-snb-2600 
  Missing    (14): fi-kbl-soraka fi-ilk-m540 fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ilk-650 fi-apl-guc fi-ctg-p8600 fi-gdg-551 fi-elk-e7500 fi-bsw-kefka fi-byt-n2820 fi-byt-clapper 


== Build changes ==

    * IGT: IGT_4696 -> IGTPW_2005

  CI_DRM_5042: 591c74093dc70bdceaa02441c494dd7090533564 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2005: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2005/
  IGT_4696: ff2db94acb53543acd7ba4e2badff59807069365 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2005/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_content_protection: restore for real before failing (rev2)

[Patchwork]

== Series Details ==

Series: tests/kms_content_protection: restore for real before failing (rev2)
URL   : https://patchwork.freedesktop.org/series/51604/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4696_full -> IGTPW_2005_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51604/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_2005_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_cursor_crc@cursor-128x42-sliding:
      shard-apl:          PASS -> FAIL (fdo#103232) +2

    igt@kms_cursor_crc@cursor-256x256-offscreen:
      shard-glk:          PASS -> INCOMPLETE (fdo#103359, k.org#198133)

    igt@kms_cursor_crc@cursor-size-change:
      shard-glk:          PASS -> FAIL (fdo#103232) +1

    igt@kms_fence_pin_leak:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_flip@plain-flip-ts-check:
      shard-kbl:          PASS -> FAIL (fdo#100368)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-apl:          PASS -> FAIL (fdo#103167) +4
      shard-kbl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
      shard-glk:          PASS -> FAIL (fdo#103167) +4

    igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-pwrite:
      shard-apl:          SKIP -> INCOMPLETE (fdo#103927)

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
      shard-apl:          PASS -> FAIL (fdo#108145)

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          PASS -> FAIL (fdo#108145) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          PASS -> FAIL (fdo#103166) +2

    igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
      shard-apl:          PASS -> FAIL (fdo#103166) +2

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_busy@close-race:
      shard-glk:          DMESG-FAIL (fdo#108561) -> PASS

    igt@gem_ctx_isolation@vcs1-s3:
      shard-kbl:          DMESG-WARN (fdo#108549) -> PASS

    igt@kms_atomic_transition@plane-all-modeset-transition:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_busy@extended-modeset-hang-newfb-render-b:
      shard-hsw:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_color@pipe-c-legacy-gamma:
      shard-kbl:          FAIL (fdo#104782) -> PASS
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-256x85-random:
      shard-apl:          FAIL (fdo#103232) -> PASS +4

    igt@kms_cursor_crc@cursor-64x64-sliding:
      shard-glk:          FAIL (fdo#103232) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
      shard-glk:          FAIL (fdo#103167) -> PASS +1

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
      shard-apl:          DMESG-WARN (fdo#108549) -> PASS +47

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
      shard-kbl:          DMESG-WARN (fdo#108550, fdo#108549) -> PASS +1

    igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
      shard-glk:          FAIL (fdo#108146) -> PASS

    igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
      shard-kbl:          FAIL (fdo#108146) -> PASS +1
      shard-apl:          FAIL (fdo#108146) -> PASS +1

    igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
      shard-glk:          FAIL (fdo#103166) -> PASS

    igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
      shard-apl:          FAIL (fdo#103166) -> PASS

    igt@kms_vblank@pipe-b-query-busy-hang:
      shard-kbl:          DMESG-WARN (fdo#108550) -> PASS +7

    igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
      shard-apl:          DMESG-FAIL (fdo#108549) -> PASS +1

    igt@pm_rpm@modeset-stress-extra-wait:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    
    ==== Warnings ====

    igt@gem_busy@close-race:
      shard-apl:          DMESG-FAIL (fdo#108561) -> INCOMPLETE (fdo#103927)

    igt@kms_color@pipe-c-degamma:
      shard-apl:          DMESG-WARN (fdo#108549) -> FAIL (fdo#104782)

    igt@kms_cursor_crc@cursor-256x85-onscreen:
      shard-apl:          DMESG-WARN (fdo#108549) -> FAIL (fdo#103232)

    igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
      shard-apl:          DMESG-FAIL (fdo#108145, fdo#108549) -> FAIL (fdo#108145)

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
  fdo#108549 https://bugs.freedesktop.org/show_bug.cgi?id=108549
  fdo#108550 https://bugs.freedesktop.org/show_bug.cgi?id=108550
  fdo#108561 https://bugs.freedesktop.org/show_bug.cgi?id=108561
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-skl 


== Build changes ==

    * IGT: IGT_4696 -> IGTPW_2005
    * Linux: CI_DRM_5041 -> CI_DRM_5042

  CI_DRM_5041: a45f611eae66546bb297a81c88e89bfd409bf199 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_5042: 591c74093dc70bdceaa02441c494dd7090533564 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2005: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2005/
  IGT_4696: ff2db94acb53543acd7ba4e2badff59807069365 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2005/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_content_protection: restore for real before failing

[Daniel Vetter]

On Mon, Oct 29, 2018 at 09:52:04AM +0100, Daniel Vetter wrote:
> Nothing happens if you don't commit ...
> 
> v2: rebased!?

Seems to have worked now, I guess I had a stored conflict resolution
locally that I wasnted aware of. Applied.
-Daniel

> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108550
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108549
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  tests/kms_content_protection.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
> index 1e7d2b9e4e69..801eff66c272 100644
> --- a/tests/kms_content_protection.c
> +++ b/tests/kms_content_protection.c
> @@ -175,12 +175,11 @@ test_cp_enable_disable(const enum pipe pipe, igt_output_t *output,
>  	 * "content protection" at "UNDESIRED".
>  	 */
>  	igt_output_set_prop_value(output, IGT_CONNECTOR_CONTENT_PROTECTION, 0);
> -
> -	igt_assert_f(ret, "Content Protection not enabled\n");
> -
>  	igt_plane_set_fb(primary, &red);
>  	igt_display_commit2(display, s);
>  
> +	igt_assert_f(ret, "Content Protection not enabled\n");
> +
>  	/* Wait for HDCP to be disabled, before crtc off */
>  	wait_for_prop_value(output, 0, 1000);
>  
> -- 
> 2.19.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_content_protection: restore for real before failing

[C, Ramalingam]

On 10/26/2018 7:44 PM, Daniel Vetter wrote:
> Nothing happens if you don't commit ...
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108550
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108549
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>   tests/kms_content_protection.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
> index 87c7a9abd38a..060a00f95d04 100644
> --- a/tests/kms_content_protection.c
> +++ b/tests/kms_content_protection.c
> @@ -174,12 +174,11 @@ test_cp_enable_disable(const enum pipe pipe, igt_output_t *output,
>   	/* FIXME: Kernel totally falls over if we leave HDCP enabled. Work
>   	 * around this for now by restoring it before check whether it worked. */
>   	igt_output_set_prop_value(output, IGT_CONNECTOR_CONTENT_PROTECTION, 0);
> -
> -	igt_assert_f(ret, "Content Protection not enabled\n");
> -
>   	igt_plane_set_fb(primary, &red);
>   	igt_display_commit2(display, s);
>   
> +	igt_assert_f(ret, "Content Protection not enabled\n");
> +

Ashamed for not catching this at original change itself. :(

Reviewed-by: Ramalingam C <ramalingam.c@intel.com>

>   	/* Wait for HDCP to be disabled, before crtc off */
>   	wait_for_prop_value(output, 0, 1000);
>   
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_content_protection: restore for real before failing

[Daniel Vetter]

Nothing happens if you don't commit ...

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108550
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108549
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_content_protection.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
index 87c7a9abd38a..060a00f95d04 100644
--- a/tests/kms_content_protection.c
+++ b/tests/kms_content_protection.c
@@ -174,12 +174,11 @@ test_cp_enable_disable(const enum pipe pipe, igt_output_t *output,
 	/* FIXME: Kernel totally falls over if we leave HDCP enabled. Work
 	 * around this for now by restoring it before check whether it worked. */
 	igt_output_set_prop_value(output, IGT_CONNECTOR_CONTENT_PROTECTION, 0);
-
-	igt_assert_f(ret, "Content Protection not enabled\n");
-
 	igt_plane_set_fb(primary, &red);
 	igt_display_commit2(display, s);
 
+	igt_assert_f(ret, "Content Protection not enabled\n");
+
 	/* Wait for HDCP to be disabled, before crtc off */
 	wait_for_prop_value(output, 0, 1000);
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev