[U-Boot] [PATCH 0/3] Small fixes for Olimex MX23 based Olinuxino boards

[U-Boot] [PATCH 0/3] Small fixes for Olimex MX23 based Olinuxino boards

[Michael Heimpold]

Testing of v2018.11-rc2 on this board uncovered three small "issues"
I would like to see fixed. See individual patch descriptions for details.

Michael Heimpold (3):
  configs: drop CMD_CACHE from mx23_olinuxino_defconfig
  configs: mx23_olinuxino_defconfig: fix status led definition
  configs: mx23_olinuxino_defconfig: disable bootefi command

 configs/mx23_olinuxino_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

[U-Boot] [PATCH 1/3] configs: drop CMD_CACHE from mx23_olinuxino_defconfig

[Michael Heimpold]

This prevents the warning message
"No arch specific invalidate_icache_all available!"
during boot.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
 configs/mx23_olinuxino_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
index 2eee19dab5..6597dc3870 100644
--- a/configs/mx23_olinuxino_defconfig
+++ b/configs/mx23_olinuxino_defconfig
@@ -20,7 +20,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
-CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_ENV_IS_IN_MMC=y
-- 
2.17.1

[U-Boot] [PATCH 2/3] configs: mx23_olinuxino_defconfig: fix status led definition

[Michael Heimpold]

While migrating individual status led usages to Kconfig stuff,
a (random) value was introduced for this board which does not
work but produces the following error message during boot:

__led_init: failed requesting GPIO59!

Since Kconfig does not seem to accept a define as this point,
but the mxs gpio driver requires not only a simple integer value,
we need to use the plain value of MX23_PAD_SSP1_DETECT__GPIO_2_1.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Fixes: 2d8d190c8394 ("status_led: Kconfig migration")
---
 configs/mx23_olinuxino_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
index 6597dc3870..598547a5f5 100644
--- a/configs/mx23_olinuxino_defconfig
+++ b/configs/mx23_olinuxino_defconfig
@@ -26,7 +26,7 @@ CONFIG_ENV_IS_IN_MMC=y
 CONFIG_LED_STATUS=y
 CONFIG_LED_STATUS_GPIO=y
 CONFIG_LED_STATUS0=y
-CONFIG_LED_STATUS_BIT=59
+CONFIG_LED_STATUS_BIT=778
 CONFIG_LED_STATUS_STATE=2
 CONFIG_LED_STATUS_BOOT_ENABLE=y
 CONFIG_LED_STATUS_BOOT=0
-- 
2.17.1

[U-Boot] [PATCH 3/3] configs: mx23_olinuxino_defconfig: disable bootefi command

[Michael Heimpold]

CONFIG_CMD_BOOTEFI is enabled by Kconfig default, but rarely
used on this board/platform.
So let's disable it for the boards default config.
This also saves around 16 KiB in the final u-boot.sb.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
 configs/mx23_olinuxino_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
index 598547a5f5..1bf76e2e11 100644
--- a/configs/mx23_olinuxino_defconfig
+++ b/configs/mx23_olinuxino_defconfig
@@ -14,6 +14,7 @@ CONFIG_VERSION_VARIABLE=y
 CONFIG_ARCH_MISC_INIT=y
 # CONFIG_SPL_FRAMEWORK is not set
 CONFIG_HUSH_PARSER=y
+# CONFIG_CMD_BOOTEFI is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
-- 
2.17.1

[U-Boot] [PATCH 1/3] configs: drop CMD_CACHE from mx23_olinuxino_defconfig

[Marek Vasut]

On 10/29/2018 08:21 PM, Michael Heimpold wrote:
> This prevents the warning message
> "No arch specific invalidate_icache_all available!"
> during boot.

Can you implement it ? The cache support worked on MX23.

> Signed-off-by: Michael Heimpold <mhei@heimpold.de>
> ---
>  configs/mx23_olinuxino_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
> index 2eee19dab5..6597dc3870 100644
> --- a/configs/mx23_olinuxino_defconfig
> +++ b/configs/mx23_olinuxino_defconfig
> @@ -20,7 +20,6 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_USB=y
>  # CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_DHCP=y
> -CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT2=y
>  CONFIG_CMD_FAT=y
>  CONFIG_ENV_IS_IN_MMC=y
> 


-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH 1/3] configs: drop CMD_CACHE from mx23_olinuxino_defconfig

[Michael Heimpold]

Am Dienstag, 30. Oktober 2018, 11:35:25 CET schrieb Marek Vasut:
> On 10/29/2018 08:21 PM, Michael Heimpold wrote:
> > This prevents the warning message
> > "No arch specific invalidate_icache_all available!"
> > during boot.
> 
> Can you implement it ? The cache support worked on MX23.

Hm, I had a second look: for invalidate_icache_all()
- we already have an implementation in arch/arm/cpu/arm926ejs/cache.c
- we have a weak symbol in cmd/cache.c
- we have a weak symbol in lib/efi_loader/efi_image_loader.c

I don't know how I managed to get the warning - cannot reproduce it
anymore.
So I withdraw this one patch, sorry for the noise.

Regards,
Michael

> 
> > Signed-off-by: Michael Heimpold <mhei@heimpold.de>
> > ---
> > 
> >  configs/mx23_olinuxino_defconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/configs/mx23_olinuxino_defconfig
> > b/configs/mx23_olinuxino_defconfig index 2eee19dab5..6597dc3870 100644
> > --- a/configs/mx23_olinuxino_defconfig
> > +++ b/configs/mx23_olinuxino_defconfig
> > @@ -20,7 +20,6 @@ CONFIG_CMD_MMC=y
> > 
> >  CONFIG_CMD_USB=y
> >  # CONFIG_CMD_SETEXPR is not set
> >  CONFIG_CMD_DHCP=y
> > 
> > -CONFIG_CMD_CACHE=y
> > 
> >  CONFIG_CMD_EXT2=y
> >  CONFIG_CMD_FAT=y
> >  CONFIG_ENV_IS_IN_MMC=y

[U-Boot] [PATCH 2/3] configs: mx23_olinuxino_defconfig: fix status led definition

[Stefano Babic]

On 29/10/18 20:21, Michael Heimpold wrote:
> While migrating individual status led usages to Kconfig stuff,
> a (random) value was introduced for this board which does not
> work but produces the following error message during boot:
> 
> __led_init: failed requesting GPIO59!
> 
> Since Kconfig does not seem to accept a define as this point,
> but the mxs gpio driver requires not only a simple integer value,
> we need to use the plain value of MX23_PAD_SSP1_DETECT__GPIO_2_1.
> 
> Signed-off-by: Michael Heimpold <mhei@heimpold.de>
> Fixes: 2d8d190c8394 ("status_led: Kconfig migration")
> ---
>  configs/mx23_olinuxino_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
> index 6597dc3870..598547a5f5 100644
> --- a/configs/mx23_olinuxino_defconfig
> +++ b/configs/mx23_olinuxino_defconfig
> @@ -26,7 +26,7 @@ CONFIG_ENV_IS_IN_MMC=y
>  CONFIG_LED_STATUS=y
>  CONFIG_LED_STATUS_GPIO=y
>  CONFIG_LED_STATUS0=y
> -CONFIG_LED_STATUS_BIT=59
> +CONFIG_LED_STATUS_BIT=778
>  CONFIG_LED_STATUS_STATE=2
>  CONFIG_LED_STATUS_BOOT_ENABLE=y
>  CONFIG_LED_STATUS_BOOT=0
> 

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH 3/3] configs: mx23_olinuxino_defconfig: disable bootefi command

[Stefano Babic]

On 29/10/18 20:21, Michael Heimpold wrote:
> CONFIG_CMD_BOOTEFI is enabled by Kconfig default, but rarely
> used on this board/platform.
> So let's disable it for the boards default config.
> This also saves around 16 KiB in the final u-boot.sb.
> 
> Signed-off-by: Michael Heimpold <mhei@heimpold.de>
> ---
>  configs/mx23_olinuxino_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
> index 598547a5f5..1bf76e2e11 100644
> --- a/configs/mx23_olinuxino_defconfig
> +++ b/configs/mx23_olinuxino_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VERSION_VARIABLE=y
>  CONFIG_ARCH_MISC_INIT=y
>  # CONFIG_SPL_FRAMEWORK is not set
>  CONFIG_HUSH_PARSER=y
> +# CONFIG_CMD_BOOTEFI is not set
>  # CONFIG_CMD_FLASH is not set
>  CONFIG_CMD_GPIO=y
>  CONFIG_CMD_MMC=y
> 

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================