All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] igt/gem_ppgtt: Unroll 32b memset
@ 2018-10-29 19:37 Chris Wilson
  2018-10-30  2:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-10-29 19:37 UTC (permalink / raw)
  To: igt-dev

Manually unroll the 32b memset in create_bo() to set a cacheline at a
time, for a 2x speed improve of the whole test.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_ppgtt.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c
index af5e3e07..86fe59f2 100644
--- a/tests/i915/gem_ppgtt.c
+++ b/tests/i915/gem_ppgtt.c
@@ -47,16 +47,20 @@
 static drm_intel_bo *create_bo(drm_intel_bufmgr *bufmgr,
 			       uint32_t pixel)
 {
+	uint64_t value = (uint64_t)pixel << 32 | pixel, *v;
 	drm_intel_bo *bo;
-	uint32_t *v;
 
 	bo = drm_intel_bo_alloc(bufmgr, "surface", SIZE, 4096);
 	igt_assert(bo);
 
 	do_or_die(drm_intel_bo_map(bo, 1));
 	v = bo->virtual;
-	for (int i = 0; i < SIZE/4; i++)
-		v[i] = pixel;
+	for (int i = 0; i < SIZE / sizeof(value); i += 8) {
+		v[i + 0] = value; v[i + 1] = value;
+		v[i + 2] = value; v[i + 3] = value;
+		v[i + 4] = value; v[i + 5] = value;
+		v[i + 6] = value; v[i + 7] = value;
+	}
 	drm_intel_bo_unmap(bo);
 
 	return bo;
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_ppgtt: Unroll 32b memset
  2018-10-29 19:37 [igt-dev] [PATCH i-g-t] igt/gem_ppgtt: Unroll 32b memset Chris Wilson
@ 2018-10-30  2:46 ` Patchwork
  2018-10-30  9:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2018-10-31  9:12 ` [igt-dev] [PATCH i-g-t] " Michał Winiarski
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-30  2:46 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gem_ppgtt: Unroll 32b memset
URL   : https://patchwork.freedesktop.org/series/51706/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5044 -> IGTPW_2010 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51706/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_2010 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_contexts:
      fi-icl-u:           PASS -> DMESG-FAIL (fdo#108569)

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      PASS -> DMESG-WARN (fdo#105998)

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload:
      fi-glk-j4005:       DMESG-WARN (fdo#106725, fdo#106248) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@gem_sync@basic-each:
      fi-glk-j4005:       DMESG-WARN (fdo#105719) -> PASS

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       DMESG-WARN (fdo#106000) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
      fi-glk-j4005:       DMESG-FAIL (fdo#106000) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
  fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569


== Participating hosts (47 -> 44) ==

  Additional (5): fi-gdg-551 fi-cfl-8109u fi-ivb-3770 fi-pnv-d510 fi-snb-2600 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ilk-650 fi-ctg-p8600 fi-kbl-8809g fi-elk-e7500 fi-byt-n2820 


== Build changes ==

    * IGT: IGT_4698 -> IGTPW_2010

  CI_DRM_5044: c4487dca27970879bf67f331614142c749984d65 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2010: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2010/
  IGT_4698: af57164fcb16950187ad402ed31f565e88c42a78 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2010/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for igt/gem_ppgtt: Unroll 32b memset
  2018-10-29 19:37 [igt-dev] [PATCH i-g-t] igt/gem_ppgtt: Unroll 32b memset Chris Wilson
  2018-10-30  2:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-30  9:54 ` Patchwork
  2018-10-31  9:12 ` [igt-dev] [PATCH i-g-t] " Michał Winiarski
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-30  9:54 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gem_ppgtt: Unroll 32b memset
URL   : https://patchwork.freedesktop.org/series/51706/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4698_full -> IGTPW_2010_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51706/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_2010_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> INCOMPLETE (fdo#106886, k.org#198133, fdo#103359)

    igt@gem_userptr_blits@readonly-unsync:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@i915_query@query-topology-unsupported:
      shard-glk:          SKIP -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL (fdo#106641)

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_color@pipe-b-ctm-max:
      shard-kbl:          PASS -> FAIL (fdo#108147)

    igt@kms_cursor_crc@cursor-256x256-sliding:
      shard-glk:          PASS -> FAIL (fdo#103232) +2

    igt@kms_cursor_crc@cursor-256x85-random:
      shard-apl:          PASS -> FAIL (fdo#103232) +5

    igt@kms_cursor_crc@cursor-64x64-onscreen:
      shard-kbl:          PASS -> FAIL (fdo#103232) +1

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          NOTRUN -> FAIL (fdo#105454, fdo#106509)

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#106538, fdo#105763)

    igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
      shard-glk:          PASS -> DMESG-FAIL (fdo#106538, fdo#103184)

    igt@kms_flip@2x-flip-vs-dpms:
      shard-hsw:          NOTRUN -> DMESG-WARN (fdo#102614)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-apl:          PASS -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt:
      shard-glk:          PASS -> FAIL (fdo#103167) +8

    igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
      shard-glk:          PASS -> FAIL (fdo#108145) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-apl:          PASS -> FAIL (fdo#103166) +3
      shard-glk:          PASS -> FAIL (fdo#103166) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-kbl:          PASS -> FAIL (fdo#103166) +2

    igt@kms_rotation_crc@sprite-rotation-90:
      shard-glk:          PASS -> DMESG-FAIL (fdo#106538)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_busy@close-race:
      shard-glk:          DMESG-FAIL (fdo#108561) -> PASS
      shard-snb:          DMESG-FAIL (fdo#108561) -> PASS
      shard-hsw:          DMESG-FAIL (fdo#108561) -> PASS
      shard-kbl:          DMESG-FAIL (fdo#108561) -> PASS

    igt@gem_ctx_isolation@bcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@gem_exec_reloc@basic-gtt:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@gem_softpin@noreloc-s3:
      shard-kbl:          DMESG-WARN (fdo#103313) -> PASS

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
      shard-apl:          DMESG-FAIL (fdo#108549) -> PASS +1

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
      shard-kbl:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_chv_cursor_fail@pipe-b-64x64-top-edge:
      shard-kbl:          DMESG-WARN (fdo#108550) -> PASS +9

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-apl:          FAIL (fdo#103232, fdo#103191) -> PASS

    igt@kms_cursor_crc@cursor-256x85-onscreen:
      shard-glk:          FAIL (fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-64x21-sliding:
      shard-apl:          FAIL (fdo#103232) -> PASS +3

    igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
      shard-glk:          FAIL (fdo#107791) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
      shard-apl:          FAIL (fdo#103167) -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-1p-rte:
      shard-apl:          DMESG-WARN (fdo#103558, fdo#108131) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
      shard-glk:          FAIL (fdo#103167) -> PASS +3

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
      shard-apl:          FAIL (fdo#103375) -> PASS

    igt@kms_plane@plane-panning-top-left-pipe-b-planes:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-apl:          FAIL (fdo#103166) -> PASS +2

    igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
      shard-glk:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
      shard-kbl:          FAIL (fdo#103166) -> PASS

    igt@pm_rpm@gem-mmap-cpu:
      shard-apl:          DMESG-WARN (fdo#108549) -> PASS +19

    igt@prime_busy@hang-bsd:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    
    ==== Warnings ====

    igt@kms_color@pipe-b-ctm-max:
      shard-apl:          DMESG-WARN (fdo#108549) -> FAIL (fdo#108147)

    igt@kms_cursor_crc@cursor-128x42-sliding:
      shard-apl:          DMESG-WARN (fdo#108549) -> FAIL (fdo#103232) +2

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107791 https://bugs.freedesktop.org/show_bug.cgi?id=107791
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108131 https://bugs.freedesktop.org/show_bug.cgi?id=108131
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
  fdo#108549 https://bugs.freedesktop.org/show_bug.cgi?id=108549
  fdo#108550 https://bugs.freedesktop.org/show_bug.cgi?id=108550
  fdo#108561 https://bugs.freedesktop.org/show_bug.cgi?id=108561
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-skl 


== Build changes ==

    * IGT: IGT_4698 -> IGTPW_2010
    * Linux: CI_DRM_5042 -> CI_DRM_5044

  CI_DRM_5042: 591c74093dc70bdceaa02441c494dd7090533564 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_5044: c4487dca27970879bf67f331614142c749984d65 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2010: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2010/
  IGT_4698: af57164fcb16950187ad402ed31f565e88c42a78 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2010/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_ppgtt: Unroll 32b memset
  2018-10-29 19:37 [igt-dev] [PATCH i-g-t] igt/gem_ppgtt: Unroll 32b memset Chris Wilson
  2018-10-30  2:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-10-30  9:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-31  9:12 ` Michał Winiarski
  2 siblings, 0 replies; 4+ messages in thread
From: Michał Winiarski @ 2018-10-31  9:12 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

On Mon, Oct 29, 2018 at 07:37:29PM +0000, Chris Wilson wrote:
> Manually unroll the 32b memset in create_bo() to set a cacheline at a
> time, for a 2x speed improve of the whole test.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał

> ---
>  tests/i915/gem_ppgtt.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c
> index af5e3e07..86fe59f2 100644
> --- a/tests/i915/gem_ppgtt.c
> +++ b/tests/i915/gem_ppgtt.c
> @@ -47,16 +47,20 @@
>  static drm_intel_bo *create_bo(drm_intel_bufmgr *bufmgr,
>  			       uint32_t pixel)
>  {
> +	uint64_t value = (uint64_t)pixel << 32 | pixel, *v;
>  	drm_intel_bo *bo;
> -	uint32_t *v;
>  
>  	bo = drm_intel_bo_alloc(bufmgr, "surface", SIZE, 4096);
>  	igt_assert(bo);
>  
>  	do_or_die(drm_intel_bo_map(bo, 1));
>  	v = bo->virtual;
> -	for (int i = 0; i < SIZE/4; i++)
> -		v[i] = pixel;
> +	for (int i = 0; i < SIZE / sizeof(value); i += 8) {
> +		v[i + 0] = value; v[i + 1] = value;
> +		v[i + 2] = value; v[i + 3] = value;
> +		v[i + 4] = value; v[i + 5] = value;
> +		v[i + 6] = value; v[i + 7] = value;
> +	}
>  	drm_intel_bo_unmap(bo);
>  
>  	return bo;
> -- 
> 2.19.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-31  9:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29 19:37 [igt-dev] [PATCH i-g-t] igt/gem_ppgtt: Unroll 32b memset Chris Wilson
2018-10-30  2:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-30  9:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-31  9:12 ` [igt-dev] [PATCH i-g-t] " Michał Winiarski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.