All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] udmabuf: set read/write flag when exporting
@ 2018-10-30  1:32 Gurchetan Singh
  2018-10-30  6:19 ` Gerd Hoffmann
  0 siblings, 1 reply; 8+ messages in thread
From: Gurchetan Singh @ 2018-10-30  1:32 UTC (permalink / raw)
  To: dri-devel; +Cc: kraxel, Gurchetan Singh

Otherwise, mmap fails when done with PROT_WRITE.
---
 drivers/dma-buf/udmabuf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 5b44ef226904..fc359ca4503d 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -184,6 +184,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
 	exp_info.ops  = &udmabuf_ops;
 	exp_info.size = ubuf->pagecount << PAGE_SHIFT;
 	exp_info.priv = ubuf;
+	exp_info.flags = O_RDWR;
 
 	buf = dma_buf_export(&exp_info);
 	if (IS_ERR(buf)) {
-- 
2.16.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] udmabuf: set read/write flag when exporting
  2018-10-30  1:32 [PATCH] udmabuf: set read/write flag when exporting Gurchetan Singh
@ 2018-10-30  6:19 ` Gerd Hoffmann
  2018-10-30 17:36   ` Gurchetan Singh
  0 siblings, 1 reply; 8+ messages in thread
From: Gerd Hoffmann @ 2018-10-30  6:19 UTC (permalink / raw)
  To: Gurchetan Singh; +Cc: dri-devel

On Mon, Oct 29, 2018 at 06:32:37PM -0700, Gurchetan Singh wrote:
> Otherwise, mmap fails when done with PROT_WRITE.

Patch looks good, but sign-off is missing.

cheers,
  Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] udmabuf: set read/write flag when exporting
  2018-10-30  6:19 ` Gerd Hoffmann
@ 2018-10-30 17:36   ` Gurchetan Singh
  0 siblings, 0 replies; 8+ messages in thread
From: Gurchetan Singh @ 2018-10-30 17:36 UTC (permalink / raw)
  To: dri-devel; +Cc: Gurchetan Singh

Otherwise, mmap fails when done with PROT_WRITE.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
---
 drivers/dma-buf/udmabuf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 5b44ef226904..fc359ca4503d 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -184,6 +184,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
 	exp_info.ops  = &udmabuf_ops;
 	exp_info.size = ubuf->pagecount << PAGE_SHIFT;
 	exp_info.priv = ubuf;
+	exp_info.flags = O_RDWR;
 
 	buf = dma_buf_export(&exp_info);
 	if (IS_ERR(buf)) {
-- 
2.16.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] udmabuf: set read/write flag when exporting
  2018-11-16  1:46   ` Gurchetan Singh
  (?)
@ 2018-11-16  7:52   ` Gerd Hoffmann
  -1 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2018-11-16  7:52 UTC (permalink / raw)
  To: Gurchetan Singh
  Cc: ML dri-devel, sumit.semwal, linux-media, linaro-mm-sig, linux-kernel

On Thu, Nov 15, 2018 at 05:46:30PM -0800, Gurchetan Singh wrote:
> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
> Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>

Thanks.  Pushed to drm-misc-fixes.

cheers,
  Gerd


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] udmabuf: set read/write flag when exporting
  2018-11-14 12:20 ` Gerd Hoffmann
@ 2018-11-16  1:46   ` Gurchetan Singh
  -1 siblings, 0 replies; 8+ messages in thread
From: Gurchetan Singh @ 2018-11-16  1:46 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: ML dri-devel, sumit.semwal, linux-media, linaro-mm-sig, linux-kernel

Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
On Wed, Nov 14, 2018 at 4:20 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Otherwise, mmap fails when done with PROT_WRITE.
>
> Suggested-by: Gurchetan Singh <gurchetansingh@chromium.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  drivers/dma-buf/udmabuf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index e70328ab7e..d9ff246093 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
>         exp_info.ops  = &udmabuf_ops;
>         exp_info.size = ubuf->pagecount << PAGE_SHIFT;
>         exp_info.priv = ubuf;
> +       exp_info.flags = O_RDWR;
>
>         buf = dma_buf_export(&exp_info);
>         if (IS_ERR(buf)) {
> --
> 2.9.3
>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] udmabuf: set read/write flag when exporting
@ 2018-11-16  1:46   ` Gurchetan Singh
  0 siblings, 0 replies; 8+ messages in thread
From: Gurchetan Singh @ 2018-11-16  1:46 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: linaro-mm-sig, linux-kernel, ML dri-devel, linux-media

Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
On Wed, Nov 14, 2018 at 4:20 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Otherwise, mmap fails when done with PROT_WRITE.
>
> Suggested-by: Gurchetan Singh <gurchetansingh@chromium.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  drivers/dma-buf/udmabuf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index e70328ab7e..d9ff246093 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
>         exp_info.ops  = &udmabuf_ops;
>         exp_info.size = ubuf->pagecount << PAGE_SHIFT;
>         exp_info.priv = ubuf;
> +       exp_info.flags = O_RDWR;
>
>         buf = dma_buf_export(&exp_info);
>         if (IS_ERR(buf)) {
> --
> 2.9.3
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] udmabuf: set read/write flag when exporting
@ 2018-11-14 12:20 ` Gerd Hoffmann
  0 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2018-11-14 12:20 UTC (permalink / raw)
  To: dri-devel
  Cc: gurchetansingh, Gerd Hoffmann, Sumit Semwal,
	open list:DMA BUFFER SHARING FRAMEWORK,
	moderated list:DMA BUFFER SHARING FRAMEWORK, open list

Otherwise, mmap fails when done with PROT_WRITE.

Suggested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/dma-buf/udmabuf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index e70328ab7e..d9ff246093 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
 	exp_info.ops  = &udmabuf_ops;
 	exp_info.size = ubuf->pagecount << PAGE_SHIFT;
 	exp_info.priv = ubuf;
+	exp_info.flags = O_RDWR;
 
 	buf = dma_buf_export(&exp_info);
 	if (IS_ERR(buf)) {
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] udmabuf: set read/write flag when exporting
@ 2018-11-14 12:20 ` Gerd Hoffmann
  0 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2018-11-14 12:20 UTC (permalink / raw)
  To: dri-devel
  Cc: gurchetansingh, Gerd Hoffmann, Sumit Semwal,
	open list:DMA BUFFER SHARING FRAMEWORK,
	moderated list:DMA BUFFER SHARING FRAMEWORK, open list

Otherwise, mmap fails when done with PROT_WRITE.

Suggested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/dma-buf/udmabuf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index e70328ab7e..d9ff246093 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
 	exp_info.ops  = &udmabuf_ops;
 	exp_info.size = ubuf->pagecount << PAGE_SHIFT;
 	exp_info.priv = ubuf;
+	exp_info.flags = O_RDWR;
 
 	buf = dma_buf_export(&exp_info);
 	if (IS_ERR(buf)) {
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-11-16  7:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30  1:32 [PATCH] udmabuf: set read/write flag when exporting Gurchetan Singh
2018-10-30  6:19 ` Gerd Hoffmann
2018-10-30 17:36   ` Gurchetan Singh
2018-11-14 12:20 Gerd Hoffmann
2018-11-14 12:20 ` Gerd Hoffmann
2018-11-16  1:46 ` Gurchetan Singh
2018-11-16  1:46   ` Gurchetan Singh
2018-11-16  7:52   ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.