* [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
@ 2018-10-29 20:49 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-10-29 20:49 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Older platforms require fence registers to perform blits, and so
userspace is expected to mark up the objects to request fences be
assigned.
Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_tiled_fence_blits.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
index 7560fa52..e40a7b43 100644
--- a/tests/i915/gem_tiled_fence_blits.c
+++ b/tests/i915/gem_tiled_fence_blits.c
@@ -141,6 +141,8 @@ static void run_test(int fd, int count)
memset(reloc, 0, sizeof(reloc));
memset(obj, 0, sizeof(obj));
+ obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
+ obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
obj[2].handle = create_batch(fd, reloc);
obj[2].relocs_ptr = to_user_pointer(reloc);
obj[2].relocation_count = ARRAY_SIZE(reloc);
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
@ 2018-10-29 20:49 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-10-29 20:49 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Older platforms require fence registers to perform blits, and so
userspace is expected to mark up the objects to request fences be
assigned.
Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_tiled_fence_blits.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
index 7560fa52..e40a7b43 100644
--- a/tests/i915/gem_tiled_fence_blits.c
+++ b/tests/i915/gem_tiled_fence_blits.c
@@ -141,6 +141,8 @@ static void run_test(int fd, int count)
memset(reloc, 0, sizeof(reloc));
memset(obj, 0, sizeof(obj));
+ obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
+ obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
obj[2].handle = create_batch(fd, reloc);
obj[2].relocs_ptr = to_user_pointer(reloc);
obj[2].relocation_count = ARRAY_SIZE(reloc);
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_tiled_fence_blits: Remember to mark up fence blits
2018-10-29 20:49 ` [Intel-gfx] " Chris Wilson
(?)
@ 2018-10-30 2:59 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-10-30 2:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/gem_tiled_fence_blits: Remember to mark up fence blits
URL : https://patchwork.freedesktop.org/series/51708/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5044 -> IGTPW_2011 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51708/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_2011 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-kbl-7560u: PASS -> INCOMPLETE (fdo#108044)
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: PASS -> DMESG-WARN (fdo#105998) +1
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362) +1
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106725, fdo#106248) -> PASS
igt@drv_selftest@live_contexts:
fi-icl-u2: DMESG-FAIL (fdo#108569) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@gem_sync@basic-each:
fi-glk-j4005: DMESG-WARN (fdo#105719) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
fi-glk-j4005: DMESG-FAIL (fdo#106000) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108044 https://bugs.freedesktop.org/show_bug.cgi?id=108044
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (47 -> 44) ==
Additional (5): fi-gdg-551 fi-cfl-8109u fi-ivb-3770 fi-pnv-d510 fi-snb-2600
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ilk-650 fi-ctg-p8600 fi-kbl-8809g fi-elk-e7500 fi-byt-n2820
== Build changes ==
* IGT: IGT_4698 -> IGTPW_2011
CI_DRM_5044: c4487dca27970879bf67f331614142c749984d65 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2011: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2011/
IGT_4698: af57164fcb16950187ad402ed31f565e88c42a78 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2011/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/gem_tiled_fence_blits: Remember to mark up fence blits
2018-10-29 20:49 ` [Intel-gfx] " Chris Wilson
(?)
(?)
@ 2018-10-30 10:36 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-10-30 10:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/gem_tiled_fence_blits: Remember to mark up fence blits
URL : https://patchwork.freedesktop.org/series/51708/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4698_full -> IGTPW_2011_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51708/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_2011_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_largeobject:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_cursor_crc@cursor-128x42-random:
shard-apl: PASS -> FAIL (fdo#103232)
shard-kbl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-128x42-sliding:
shard-glk: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: NOTRUN -> FAIL (fdo#105454, fdo#106509)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167)
shard-kbl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
shard-glk: PASS -> FAIL (fdo#103167) +4
igt@kms_frontbuffer_tracking@fbc-suspend:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: PASS -> FAIL (fdo#103166) +2
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +2
igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
shard-glk: PASS -> FAIL (fdo#108145) +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-kbl: PASS -> FAIL (fdo#103166)
igt@perf_pmu@rc6-runtime-pm-long:
shard-apl: PASS -> FAIL (fdo#105010)
shard-glk: PASS -> FAIL (fdo#105010) +1
shard-kbl: PASS -> FAIL (fdo#105010)
==== Possible fixes ====
igt@gem_busy@close-race:
shard-glk: DMESG-FAIL (fdo#108561) -> PASS
shard-hsw: DMESG-FAIL (fdo#108561) -> PASS
shard-kbl: DMESG-FAIL (fdo#108561) -> PASS
igt@gem_ctx_isolation@bcs0-s3:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@gem_exec_reloc@basic-gtt:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@gem_softpin@noreloc-s3:
shard-kbl: DMESG-WARN (fdo#103313) -> PASS
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
shard-apl: DMESG-FAIL (fdo#108549) -> PASS +1
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_chv_cursor_fail@pipe-b-64x64-top-edge:
shard-kbl: DMESG-WARN (fdo#108550) -> PASS +9
igt@kms_color@pipe-b-ctm-max:
shard-apl: DMESG-WARN (fdo#108549) -> PASS +23
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: FAIL (fdo#103191, fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-64x21-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_crc@cursor-size-change:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
shard-glk: FAIL (fdo#107791) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
shard-apl: FAIL (fdo#103167) -> PASS +2
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-apl: DMESG-WARN (fdo#103558, fdo#108131) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS +5
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
shard-apl: FAIL (fdo#103375) -> PASS
igt@kms_plane@plane-panning-top-left-pipe-b-planes:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: FAIL (fdo#103166) -> PASS +3
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +2
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@prime_busy@hang-bsd:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107791 https://bugs.freedesktop.org/show_bug.cgi?id=107791
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108131 https://bugs.freedesktop.org/show_bug.cgi?id=108131
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108549 https://bugs.freedesktop.org/show_bug.cgi?id=108549
fdo#108550 https://bugs.freedesktop.org/show_bug.cgi?id=108550
fdo#108561 https://bugs.freedesktop.org/show_bug.cgi?id=108561
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4698 -> IGTPW_2011
* Linux: CI_DRM_5042 -> CI_DRM_5044
CI_DRM_5042: 591c74093dc70bdceaa02441c494dd7090533564 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_5044: c4487dca27970879bf67f331614142c749984d65 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2011: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2011/
IGT_4698: af57164fcb16950187ad402ed31f565e88c42a78 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2011/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
2018-10-29 20:49 ` [Intel-gfx] " Chris Wilson
@ 2018-10-30 13:32 ` Ville Syrjälä
-1 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2018-10-30 13:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> Older platforms require fence registers to perform blits, and so
> userspace is expected to mark up the objects to request fences be
> assigned.
>
> Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_tiled_fence_blits.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> index 7560fa52..e40a7b43 100644
> --- a/tests/i915/gem_tiled_fence_blits.c
> +++ b/tests/i915/gem_tiled_fence_blits.c
> @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
>
> memset(reloc, 0, sizeof(reloc));
> memset(obj, 0, sizeof(obj));
> + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
No harm in always asking for the fence I suppose.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> obj[2].handle = create_batch(fd, reloc);
> obj[2].relocs_ptr = to_user_pointer(reloc);
> obj[2].relocation_count = ARRAY_SIZE(reloc);
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
@ 2018-10-30 13:32 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2018-10-30 13:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> Older platforms require fence registers to perform blits, and so
> userspace is expected to mark up the objects to request fences be
> assigned.
>
> Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_tiled_fence_blits.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> index 7560fa52..e40a7b43 100644
> --- a/tests/i915/gem_tiled_fence_blits.c
> +++ b/tests/i915/gem_tiled_fence_blits.c
> @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
>
> memset(reloc, 0, sizeof(reloc));
> memset(obj, 0, sizeof(obj));
> + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
No harm in always asking for the fence I suppose.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> obj[2].handle = create_batch(fd, reloc);
> obj[2].relocs_ptr = to_user_pointer(reloc);
> obj[2].relocation_count = ARRAY_SIZE(reloc);
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
2018-10-30 13:32 ` [Intel-gfx] " Ville Syrjälä
@ 2018-10-30 17:30 ` Chris Wilson
-1 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-10-30 17:30 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx
Quoting Ville Syrjälä (2018-10-30 13:32:39)
> On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> > Older platforms require fence registers to perform blits, and so
> > userspace is expected to mark up the objects to request fences be
> > assigned.
> >
> > Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/i915/gem_tiled_fence_blits.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> > index 7560fa52..e40a7b43 100644
> > --- a/tests/i915/gem_tiled_fence_blits.c
> > +++ b/tests/i915/gem_tiled_fence_blits.c
> > @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
> >
> > memset(reloc, 0, sizeof(reloc));
> > memset(obj, 0, sizeof(obj));
> > + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> > + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
>
> No harm in always asking for the fence I suppose.
If the fence isn't required for the GPU (i.e. gen4+) we just quietly
pretend it was never requested. Probably violates the principle of least
surprise (I asked for a fence!!!), but oh well.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
@ 2018-10-30 17:30 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-10-30 17:30 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx
Quoting Ville Syrjälä (2018-10-30 13:32:39)
> On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> > Older platforms require fence registers to perform blits, and so
> > userspace is expected to mark up the objects to request fences be
> > assigned.
> >
> > Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/i915/gem_tiled_fence_blits.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> > index 7560fa52..e40a7b43 100644
> > --- a/tests/i915/gem_tiled_fence_blits.c
> > +++ b/tests/i915/gem_tiled_fence_blits.c
> > @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
> >
> > memset(reloc, 0, sizeof(reloc));
> > memset(obj, 0, sizeof(obj));
> > + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> > + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
>
> No harm in always asking for the fence I suppose.
If the fence isn't required for the GPU (i.e. gen4+) we just quietly
pretend it was never requested. Probably violates the principle of least
surprise (I asked for a fence!!!), but oh well.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
2018-10-30 17:30 ` Chris Wilson
@ 2018-10-30 18:04 ` Ville Syrjälä
-1 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2018-10-30 18:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Oct 30, 2018 at 05:30:46PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-10-30 13:32:39)
> > On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> > > Older platforms require fence registers to perform blits, and so
> > > userspace is expected to mark up the objects to request fences be
> > > assigned.
> > >
> > > Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > > tests/i915/gem_tiled_fence_blits.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> > > index 7560fa52..e40a7b43 100644
> > > --- a/tests/i915/gem_tiled_fence_blits.c
> > > +++ b/tests/i915/gem_tiled_fence_blits.c
> > > @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
> > >
> > > memset(reloc, 0, sizeof(reloc));
> > > memset(obj, 0, sizeof(obj));
> > > + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> > > + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
> >
> > No harm in always asking for the fence I suppose.
>
> If the fence isn't required for the GPU (i.e. gen4+) we just quietly
> pretend it was never requested.
Ah yes. I do recall that being the case. But I couldn't immediately
find the code for it. Now after a second look it seems to be this:
if (!eb->reloc_cache.has_fence) {
entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
} else {
...
I guess the "reloc_cache" name threw me off the track the first time
around.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits
@ 2018-10-30 18:04 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2018-10-30 18:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Oct 30, 2018 at 05:30:46PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-10-30 13:32:39)
> > On Mon, Oct 29, 2018 at 08:49:58PM +0000, Chris Wilson wrote:
> > > Older platforms require fence registers to perform blits, and so
> > > userspace is expected to mark up the objects to request fences be
> > > assigned.
> > >
> > > Fixes: ff2db94acb53 ("igt/gem_tiled_fence_blits: Remove libdrm_intel dependence")
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108591
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > > tests/i915/gem_tiled_fence_blits.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tests/i915/gem_tiled_fence_blits.c b/tests/i915/gem_tiled_fence_blits.c
> > > index 7560fa52..e40a7b43 100644
> > > --- a/tests/i915/gem_tiled_fence_blits.c
> > > +++ b/tests/i915/gem_tiled_fence_blits.c
> > > @@ -141,6 +141,8 @@ static void run_test(int fd, int count)
> > >
> > > memset(reloc, 0, sizeof(reloc));
> > > memset(obj, 0, sizeof(obj));
> > > + obj[0].flags = EXEC_OBJECT_NEEDS_FENCE;
> > > + obj[1].flags = EXEC_OBJECT_NEEDS_FENCE;
> >
> > No harm in always asking for the fence I suppose.
>
> If the fence isn't required for the GPU (i.e. gen4+) we just quietly
> pretend it was never requested.
Ah yes. I do recall that being the case. But I couldn't immediately
find the code for it. Now after a second look it seems to be this:
if (!eb->reloc_cache.has_fence) {
entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
} else {
...
I guess the "reloc_cache" name threw me off the track the first time
around.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-10-30 18:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29 20:49 [PATCH i-g-t] igt/gem_tiled_fence_blits: Remember to mark up fence blits Chris Wilson
2018-10-29 20:49 ` [Intel-gfx] " Chris Wilson
2018-10-30 2:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-30 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-30 13:32 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2018-10-30 13:32 ` [Intel-gfx] " Ville Syrjälä
2018-10-30 17:30 ` Chris Wilson
2018-10-30 17:30 ` Chris Wilson
2018-10-30 18:04 ` Ville Syrjälä
2018-10-30 18:04 ` [Intel-gfx] " Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.