From: Kurt Kanzenbach <kurt@linutronix.de> To: Anirudha Sarangi <anirudh@xilinx.com>, John Linn <John.Linn@xilinx.com>, "David S. Miller" <davem@davemloft.net> Cc: Michal Simek <michal.simek@xilinx.com>, Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>, Andrew Lunn <andrew@lunn.ch>, YueHaibing <yuehaibing@huawei.com>, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kurt Kanzenbach <kurt@linutronix.de> Subject: [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Date: Tue, 30 Oct 2018 10:31:37 +0100 [thread overview] Message-ID: <20181030093139.10226-1-kurt@linutronix.de> (raw) Hi, the Xilinx mdio wait functions may return false positives under certain circumstances: If the functions get preempted between reading the corresponding mdio register and checking for the timeout, they could falsely indicate a timeout. In order to avoid the issue, the condition should be rechecked in the timeout case. Kurt Kanzenbach (2): net: axienet: recheck condition after timeout in mdio_wait() net: xilinx_emaclite: recheck condition after timeout in mdio_wait() drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 21 ++++++++++++++++----- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 20 +++++++++++++++----- 2 files changed, 31 insertions(+), 10 deletions(-) -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: kurt@linutronix.de (Kurt Kanzenbach) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Date: Tue, 30 Oct 2018 10:31:37 +0100 [thread overview] Message-ID: <20181030093139.10226-1-kurt@linutronix.de> (raw) Hi, the Xilinx mdio wait functions may return false positives under certain circumstances: If the functions get preempted between reading the corresponding mdio register and checking for the timeout, they could falsely indicate a timeout. In order to avoid the issue, the condition should be rechecked in the timeout case. Kurt Kanzenbach (2): net: axienet: recheck condition after timeout in mdio_wait() net: xilinx_emaclite: recheck condition after timeout in mdio_wait() drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 21 ++++++++++++++++----- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 20 +++++++++++++++----- 2 files changed, 31 insertions(+), 10 deletions(-) -- 2.11.0
next reply other threads:[~2018-10-30 9:31 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-30 9:31 Kurt Kanzenbach [this message] 2018-10-30 9:31 ` [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Kurt Kanzenbach 2018-10-30 9:31 ` [PATCH 1/2] net: axienet: recheck condition after timeout in mdio_wait() Kurt Kanzenbach 2018-10-30 9:31 ` Kurt Kanzenbach 2018-10-30 18:25 ` David Miller 2018-10-30 18:25 ` David Miller 2018-10-31 13:06 ` Kurt Kanzenbach 2018-10-31 13:06 ` Kurt Kanzenbach 2018-11-05 9:16 ` Sebastian Andrzej Siewior 2018-11-05 9:16 ` Sebastian Andrzej Siewior 2018-10-30 9:31 ` [PATCH 2/2] net: xilinx_emaclite: " Kurt Kanzenbach 2018-10-30 9:31 ` Kurt Kanzenbach 2018-10-30 12:10 ` Andrew Lunn 2018-10-30 12:10 ` Andrew Lunn 2018-10-30 12:58 ` Radhey Shyam Pandey 2018-10-30 12:58 ` Radhey Shyam Pandey 2018-10-30 12:58 ` Radhey Shyam Pandey 2018-10-30 18:25 ` David Miller 2018-10-30 18:25 ` David Miller 2018-10-30 12:08 ` [PATCH 0/2] net: xlinx: mdio: recheck condition after timeout Andrew Lunn 2018-10-30 12:08 ` Andrew Lunn 2018-10-30 13:47 ` Kurt Kanzenbach 2018-10-30 13:47 ` Kurt Kanzenbach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181030093139.10226-1-kurt@linutronix.de \ --to=kurt@linutronix.de \ --cc=John.Linn@xilinx.com \ --cc=andrew@lunn.ch \ --cc=anirudh@xilinx.com \ --cc=davem@davemloft.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=netdev@vger.kernel.org \ --cc=radhey.shyam.pandey@xilinx.com \ --cc=yuehaibing@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.