All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	qemu-arm@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Max Reitz" <mreitz@redhat.com>, "Fam Zheng" <famz@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	qemu-trivial@nongnu.org, qemu-block@nongnu.org,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	xen-devel@lists.xenproject.org,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Michael Walle" <michael@walle.cc>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: [Qemu-devel] [PULL v2 14/20] qobject: Catch another straggler for use of qdict_put_str()
Date: Tue, 30 Oct 2018 12:23:31 +0100	[thread overview]
Message-ID: <20181030112337.17973-15-laurent@vivier.eu> (raw)
In-Reply-To: <20181030112337.17973-1-laurent@vivier.eu>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/qobject.cocci \
            --macro-file scripts/cocci-macro-file.h \
            --dir . --in-place

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20180705155811.20366-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 qobject/block-qdict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
index 42054cc274..1487cc5dd8 100644
--- a/qobject/block-qdict.c
+++ b/qobject/block-qdict.c
@@ -577,7 +577,7 @@ static QObject *qdict_crumple_for_keyval_qiv(QDict *src, Error **errp)
         if (!tmp) {
             tmp = qdict_clone_shallow(src);
         }
-        qdict_put(tmp, ent->key, qstring_from_str(s));
+        qdict_put_str(tmp, ent->key, s);
         g_free(buf);
     }
 
-- 
2.17.2

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	qemu-block@nongnu.org, qemu-trivial@nongnu.org,
	"Michael Walle" <michael@walle.cc>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>, "Fam Zheng" <famz@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	qemu-arm@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL v2 14/20] qobject: Catch another straggler for use of qdict_put_str()
Date: Tue, 30 Oct 2018 12:23:31 +0100	[thread overview]
Message-ID: <20181030112337.17973-15-laurent@vivier.eu> (raw)
In-Reply-To: <20181030112337.17973-1-laurent@vivier.eu>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/qobject.cocci \
            --macro-file scripts/cocci-macro-file.h \
            --dir . --in-place

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20180705155811.20366-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 qobject/block-qdict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
index 42054cc274..1487cc5dd8 100644
--- a/qobject/block-qdict.c
+++ b/qobject/block-qdict.c
@@ -577,7 +577,7 @@ static QObject *qdict_crumple_for_keyval_qiv(QDict *src, Error **errp)
         if (!tmp) {
             tmp = qdict_clone_shallow(src);
         }
-        qdict_put(tmp, ent->key, qstring_from_str(s));
+        qdict_put_str(tmp, ent->key, s);
         g_free(buf);
     }
 
-- 
2.17.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-10-30 11:24 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 11:23 [Qemu-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches Laurent Vivier
2018-10-30 11:23 ` Laurent Vivier
2018-10-30 11:23 ` [PULL v2 01/20] configs/alpha: Remove unused CONFIG_PARALLEL_ISA switch Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] " Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 02/20] vga_int: remove unused function protype Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 03/20] memory.h: fix typos in comments Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 04/20] tests/tcg/README: fix location for lm32 tests Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 05/20] qemu-iotests: fix filename containing checks Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 06/20] docs/devel/testing.rst: add missing newlines after code block Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 07/20] scripts/decodetree.py: remove unused imports Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 08/20] scripts/qemu.py: remove trailing quotes on docstring Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 09/20] qemu-iotests: make 218 executable Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 10/20] linux-user: fix comment s/atomic_write/atomic_set/ Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 11/20] cpu.h: fix a typo in comment Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 12/20] tests: Fix typos in comments and help message (found by codespell) Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 13/20] configure: Support pkg-config for zlib Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` Laurent Vivier [this message]
2018-10-30 11:23   ` [PULL v2 14/20] qobject: Catch another straggler for use of qdict_put_str() Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 15/20] xen: Use the PCI_DEVICE macro Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 16/20] tests/bios-tables-test: Remove an useless cast Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 17/20] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 18/20] hw/intc/gicv3: " Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 19/20] ppc: move at24c to its own CONFIG_ symbol Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 11:23 ` [Qemu-devel] [PULL v2 20/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report Laurent Vivier
2018-10-30 11:23   ` Laurent Vivier
2018-10-30 17:31 ` [Qemu-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches Peter Maydell
2018-10-30 17:31   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181030112337.17973-15-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=alex.bennee@linaro.org \
    --cc=amarkovic@wavecomp.com \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael@walle.cc \
    --cc=mjt@tls.msk.ru \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=sstabellini@kernel.org \
    --cc=thuth@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.