All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: speakup: clean up few indentation issues
@ 2018-10-30 11:09 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-10-30 11:09 UTC (permalink / raw)
  To: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
	Greg Kroah-Hartman, speakup, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to clean up indentation issues across the driver

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/speakup/kobjects.c      | 2 +-
 drivers/staging/speakup/speakup_decpc.c | 6 +++---
 drivers/staging/speakup/speakup_keypc.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 08f11cc17371..2e36d872662c 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -545,7 +545,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
 	int rv = 0;
 	struct st_var_header *param;
 	struct var_t *var;
-		char *cp1;
+	char *cp1;
 	char *cp;
 	char ch;
 	unsigned long flags;
diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 6649309e0342..459ee0c0bd57 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -302,12 +302,12 @@ static void synth_flush(struct spk_synth *synth)
 	while (dt_ctrl(CTRL_flush)) {
 		if (--timeout == 0)
 			break;
-udelay(50);
+		udelay(50);
 	}
 	for (timeout = 0; timeout < 10; timeout++) {
 		if (dt_waitbit(STAT_dma_ready))
 			break;
-udelay(50);
+		udelay(50);
 	}
 	outb_p(DMA_sync, speakup_info.port_tts + 4);
 	outb_p(0, speakup_info.port_tts + 4);
@@ -315,7 +315,7 @@ udelay(50);
 	for (timeout = 0; timeout < 10; timeout++) {
 		if (!(dt_getstatus() & STAT_flushing))
 			break;
-udelay(50);
+		udelay(50);
 	}
 	dma_state = dt_getstatus() & STAT_dma_state;
 	dma_state ^= STAT_dma_state;
diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
index 3901734982a4..b788272da4f9 100644
--- a/drivers/staging/speakup/speakup_keypc.c
+++ b/drivers/staging/speakup/speakup_keypc.c
@@ -177,7 +177,7 @@ static void do_catch_up(struct spk_synth *synth)
 	jiffy_delta = spk_get_var(JIFFY);
 	delay_time = spk_get_var(DELAY);
 	full_time = spk_get_var(FULL);
-spin_lock_irqsave(&speakup_info.spinlock, flags);
+	spin_lock_irqsave(&speakup_info.spinlock, flags);
 	jiffy_delta_val = jiffy_delta->u.n.value;
 	spin_unlock_irqrestore(&speakup_info.spinlock, flags);
 
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] staging: speakup: clean up few indentation issues
@ 2018-10-30 11:09 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2018-10-30 11:09 UTC (permalink / raw)
  To: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
	Greg Kroah-Hartman, speakup, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to clean up indentation issues across the driver

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/speakup/kobjects.c      | 2 +-
 drivers/staging/speakup/speakup_decpc.c | 6 +++---
 drivers/staging/speakup/speakup_keypc.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 08f11cc17371..2e36d872662c 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -545,7 +545,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
 	int rv = 0;
 	struct st_var_header *param;
 	struct var_t *var;
-		char *cp1;
+	char *cp1;
 	char *cp;
 	char ch;
 	unsigned long flags;
diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 6649309e0342..459ee0c0bd57 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -302,12 +302,12 @@ static void synth_flush(struct spk_synth *synth)
 	while (dt_ctrl(CTRL_flush)) {
 		if (--timeout = 0)
 			break;
-udelay(50);
+		udelay(50);
 	}
 	for (timeout = 0; timeout < 10; timeout++) {
 		if (dt_waitbit(STAT_dma_ready))
 			break;
-udelay(50);
+		udelay(50);
 	}
 	outb_p(DMA_sync, speakup_info.port_tts + 4);
 	outb_p(0, speakup_info.port_tts + 4);
@@ -315,7 +315,7 @@ udelay(50);
 	for (timeout = 0; timeout < 10; timeout++) {
 		if (!(dt_getstatus() & STAT_flushing))
 			break;
-udelay(50);
+		udelay(50);
 	}
 	dma_state = dt_getstatus() & STAT_dma_state;
 	dma_state ^= STAT_dma_state;
diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
index 3901734982a4..b788272da4f9 100644
--- a/drivers/staging/speakup/speakup_keypc.c
+++ b/drivers/staging/speakup/speakup_keypc.c
@@ -177,7 +177,7 @@ static void do_catch_up(struct spk_synth *synth)
 	jiffy_delta = spk_get_var(JIFFY);
 	delay_time = spk_get_var(DELAY);
 	full_time = spk_get_var(FULL);
-spin_lock_irqsave(&speakup_info.spinlock, flags);
+	spin_lock_irqsave(&speakup_info.spinlock, flags);
 	jiffy_delta_val = jiffy_delta->u.n.value;
 	spin_unlock_irqrestore(&speakup_info.spinlock, flags);
 
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: speakup: clean up few indentation issues
  2018-10-30 11:09 ` Colin King
@ 2018-10-30 11:51   ` Samuel Thibault
  -1 siblings, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2018-10-30 11:51 UTC (permalink / raw)
  To: Colin King
  Cc: William Hubbs, Chris Brannon, Kirk Reiser, Greg Kroah-Hartman,
	speakup, devel, kernel-janitors, linux-kernel

Colin King, le mar. 30 oct. 2018 11:09:59 +0000, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to clean up indentation issues across the driver
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/kobjects.c      | 2 +-
>  drivers/staging/speakup/speakup_decpc.c | 6 +++---
>  drivers/staging/speakup/speakup_keypc.c | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 08f11cc17371..2e36d872662c 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -545,7 +545,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
>  	int rv = 0;
>  	struct st_var_header *param;
>  	struct var_t *var;
> -		char *cp1;
> +	char *cp1;
>  	char *cp;
>  	char ch;
>  	unsigned long flags;
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 6649309e0342..459ee0c0bd57 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -302,12 +302,12 @@ static void synth_flush(struct spk_synth *synth)
>  	while (dt_ctrl(CTRL_flush)) {
>  		if (--timeout == 0)
>  			break;
> -udelay(50);
> +		udelay(50);
>  	}
>  	for (timeout = 0; timeout < 10; timeout++) {
>  		if (dt_waitbit(STAT_dma_ready))
>  			break;
> -udelay(50);
> +		udelay(50);
>  	}
>  	outb_p(DMA_sync, speakup_info.port_tts + 4);
>  	outb_p(0, speakup_info.port_tts + 4);
> @@ -315,7 +315,7 @@ udelay(50);
>  	for (timeout = 0; timeout < 10; timeout++) {
>  		if (!(dt_getstatus() & STAT_flushing))
>  			break;
> -udelay(50);
> +		udelay(50);
>  	}
>  	dma_state = dt_getstatus() & STAT_dma_state;
>  	dma_state ^= STAT_dma_state;
> diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> index 3901734982a4..b788272da4f9 100644
> --- a/drivers/staging/speakup/speakup_keypc.c
> +++ b/drivers/staging/speakup/speakup_keypc.c
> @@ -177,7 +177,7 @@ static void do_catch_up(struct spk_synth *synth)
>  	jiffy_delta = spk_get_var(JIFFY);
>  	delay_time = spk_get_var(DELAY);
>  	full_time = spk_get_var(FULL);
> -spin_lock_irqsave(&speakup_info.spinlock, flags);
> +	spin_lock_irqsave(&speakup_info.spinlock, flags);
>  	jiffy_delta_val = jiffy_delta->u.n.value;
>  	spin_unlock_irqrestore(&speakup_info.spinlock, flags);
>  
> -- 
> 2.19.1
> 

-- 
Samuel
<P> je sens venir la fonte 14 pour le rapport
 -+- #ens-mim -+-

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: speakup: clean up few indentation issues
@ 2018-10-30 11:51   ` Samuel Thibault
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2018-10-30 11:51 UTC (permalink / raw)
  To: Colin King
  Cc: William Hubbs, Chris Brannon, Kirk Reiser, Greg Kroah-Hartman,
	speakup, devel, kernel-janitors, linux-kernel

Colin King, le mar. 30 oct. 2018 11:09:59 +0000, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to clean up indentation issues across the driver
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/kobjects.c      | 2 +-
>  drivers/staging/speakup/speakup_decpc.c | 6 +++---
>  drivers/staging/speakup/speakup_keypc.c | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 08f11cc17371..2e36d872662c 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -545,7 +545,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
>  	int rv = 0;
>  	struct st_var_header *param;
>  	struct var_t *var;
> -		char *cp1;
> +	char *cp1;
>  	char *cp;
>  	char ch;
>  	unsigned long flags;
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 6649309e0342..459ee0c0bd57 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -302,12 +302,12 @@ static void synth_flush(struct spk_synth *synth)
>  	while (dt_ctrl(CTRL_flush)) {
>  		if (--timeout = 0)
>  			break;
> -udelay(50);
> +		udelay(50);
>  	}
>  	for (timeout = 0; timeout < 10; timeout++) {
>  		if (dt_waitbit(STAT_dma_ready))
>  			break;
> -udelay(50);
> +		udelay(50);
>  	}
>  	outb_p(DMA_sync, speakup_info.port_tts + 4);
>  	outb_p(0, speakup_info.port_tts + 4);
> @@ -315,7 +315,7 @@ udelay(50);
>  	for (timeout = 0; timeout < 10; timeout++) {
>  		if (!(dt_getstatus() & STAT_flushing))
>  			break;
> -udelay(50);
> +		udelay(50);
>  	}
>  	dma_state = dt_getstatus() & STAT_dma_state;
>  	dma_state ^= STAT_dma_state;
> diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> index 3901734982a4..b788272da4f9 100644
> --- a/drivers/staging/speakup/speakup_keypc.c
> +++ b/drivers/staging/speakup/speakup_keypc.c
> @@ -177,7 +177,7 @@ static void do_catch_up(struct spk_synth *synth)
>  	jiffy_delta = spk_get_var(JIFFY);
>  	delay_time = spk_get_var(DELAY);
>  	full_time = spk_get_var(FULL);
> -spin_lock_irqsave(&speakup_info.spinlock, flags);
> +	spin_lock_irqsave(&speakup_info.spinlock, flags);
>  	jiffy_delta_val = jiffy_delta->u.n.value;
>  	spin_unlock_irqrestore(&speakup_info.spinlock, flags);
>  
> -- 
> 2.19.1
> 

-- 
Samuel
<P> je sens venir la fonte 14 pour le rapport
 -+- #ens-mim -+-

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-30 11:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 11:09 [PATCH] staging: speakup: clean up few indentation issues Colin King
2018-10-30 11:09 ` Colin King
2018-10-30 11:51 ` Samuel Thibault
2018-10-30 11:51   ` Samuel Thibault

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.