All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4] um: Fix warning at kernel/time/clockevents.c:466
@ 2018-10-30 11:58 Richard Weinberger
  2018-10-30 11:58 ` [PATCH 2/4] um: Add HAVE_DEBUG_BUGVERBOSE Richard Weinberger
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Richard Weinberger @ 2018-10-30 11:58 UTC (permalink / raw)
  To: linux-um; +Cc: Richard Weinberger

Since fbfa9260085b ("clockevents: Warn if cpu_all_mask is used as
cpumask") the WARN_ON() make sure that nobody is using cpu_all_mask.
For UML this never was a real problem since it is UP only.
Switch to cpu_possible_mask to no longer violate the rules of the clock
framework.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/um/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/kernel/time.c b/arch/um/kernel/time.c
index 052de4c8acb2..0c572a48158e 100644
--- a/arch/um/kernel/time.c
+++ b/arch/um/kernel/time.c
@@ -56,7 +56,7 @@ static int itimer_one_shot(struct clock_event_device *evt)
 static struct clock_event_device timer_clockevent = {
 	.name			= "posix-timer",
 	.rating			= 250,
-	.cpumask		= cpu_all_mask,
+	.cpumask		= cpu_possible_mask,
 	.features		= CLOCK_EVT_FEAT_PERIODIC |
 				  CLOCK_EVT_FEAT_ONESHOT,
 	.set_state_shutdown	= itimer_shutdown,
-- 
2.19.1


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/4] um: Add HAVE_DEBUG_BUGVERBOSE.
  2018-10-30 11:58 [PATCH 1/4] um: Fix warning at kernel/time/clockevents.c:466 Richard Weinberger
@ 2018-10-30 11:58 ` Richard Weinberger
  2018-10-30 11:58 ` [PATCH 3/4] um: Include sys/uio.h to have writev() Richard Weinberger
  2018-10-30 11:58 ` [PATCH 4/4] um: Make GCOV depend on !KCOV Richard Weinberger
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2018-10-30 11:58 UTC (permalink / raw)
  To: linux-um; +Cc: Hernán Gonzalez, Richard Weinberger

From: Hernán Gonzalez <hernan@vanguardiasur.com.ar>

This option restores the DEBUG_BUGVERBOSE functionality as it was
previous to commit 9a93848fe787 ("x86/debug: Implement __WARN() using
UD0").

Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/um/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/um/Kconfig b/arch/um/Kconfig
index 6b9938919f0b..c37c7dfee8be 100644
--- a/arch/um/Kconfig
+++ b/arch/um/Kconfig
@@ -12,6 +12,7 @@ config UML
 	select HAVE_UID16
 	select HAVE_FUTEX_CMPXCHG if FUTEX
 	select HAVE_DEBUG_KMEMLEAK
+	select HAVE_DEBUG_BUGVERBOSE
 	select GENERIC_IRQ_SHOW
 	select GENERIC_CPU_DEVICES
 	select GENERIC_CLOCKEVENTS
-- 
2.19.1


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/4] um: Include sys/uio.h to have writev()
  2018-10-30 11:58 [PATCH 1/4] um: Fix warning at kernel/time/clockevents.c:466 Richard Weinberger
  2018-10-30 11:58 ` [PATCH 2/4] um: Add HAVE_DEBUG_BUGVERBOSE Richard Weinberger
@ 2018-10-30 11:58 ` Richard Weinberger
  2018-10-30 11:58 ` [PATCH 4/4] um: Make GCOV depend on !KCOV Richard Weinberger
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2018-10-30 11:58 UTC (permalink / raw)
  To: linux-um; +Cc: Richard Weinberger

sys/uio.h gives us writev(), otherwise the build might fail on
some systems.

Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/um/drivers/vector_user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
index 3d8cdbdb4e66..07dc8904510b 100644
--- a/arch/um/drivers/vector_user.c
+++ b/arch/um/drivers/vector_user.c
@@ -30,6 +30,7 @@
 #include <stdlib.h>
 #include <os.h>
 #include <um_malloc.h>
+#include <sys/uio.h>
 #include "vector_user.h"
 
 #define ID_GRE 0
-- 
2.19.1


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 4/4] um: Make GCOV depend on !KCOV
  2018-10-30 11:58 [PATCH 1/4] um: Fix warning at kernel/time/clockevents.c:466 Richard Weinberger
  2018-10-30 11:58 ` [PATCH 2/4] um: Add HAVE_DEBUG_BUGVERBOSE Richard Weinberger
  2018-10-30 11:58 ` [PATCH 3/4] um: Include sys/uio.h to have writev() Richard Weinberger
@ 2018-10-30 11:58 ` Richard Weinberger
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2018-10-30 11:58 UTC (permalink / raw)
  To: linux-um; +Cc: Richard Weinberger

Both do more or less the same thing and are mutually exclusive.
If both are enabled the build will fail.
Sooner or later we can kill UML's GCOV.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/um/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/um/Kconfig.debug b/arch/um/Kconfig.debug
index 2014597605ea..85726eeec345 100644
--- a/arch/um/Kconfig.debug
+++ b/arch/um/Kconfig.debug
@@ -16,6 +16,7 @@ config GPROF
 config GCOV
 	bool "Enable gcov support"
 	depends on DEBUG_INFO
+	depends on !KCOV
 	help
 	  This option allows developers to retrieve coverage data from a UML
 	  session.
-- 
2.19.1


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-30 11:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 11:58 [PATCH 1/4] um: Fix warning at kernel/time/clockevents.c:466 Richard Weinberger
2018-10-30 11:58 ` [PATCH 2/4] um: Add HAVE_DEBUG_BUGVERBOSE Richard Weinberger
2018-10-30 11:58 ` [PATCH 3/4] um: Include sys/uio.h to have writev() Richard Weinberger
2018-10-30 11:58 ` [PATCH 4/4] um: Make GCOV depend on !KCOV Richard Weinberger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.