All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, libvir-list@redhat.com,
	Prasad J Pandit <ppandit@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated
Date: Tue, 30 Oct 2018 18:00:50 +0000	[thread overview]
Message-ID: <20181030180050.GD3541@redhat.com> (raw)
In-Reply-To: <20181029091244.mgq4xhodjv62quof@sirius.home.kraxel.org>

On Mon, Oct 29, 2018 at 10:12:44AM +0100, Gerd Hoffmann wrote:
> On Thu, Oct 25, 2018 at 09:37:58PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Oct 25, 2018 at 10:52:56AM +0200, Gerd Hoffmann wrote:
> > > While being at it deprecate cirrus too.
> > > 
> > > Reason (short version): use stdvga instead.
> > > Verbose version:
> > >     https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful
> > 
> > Every single one of my guests is using cirrus. This wasn't an explicit
> > choice on my part, so I believe it is being used as the default in
> > virt-install.
> > 
> > I don't debate the points in the blog post above that stdvga is a
> > better choice, but I don't think that's enough to justify deprecating
> > cirrus at this point in time, because when it then gets deleted it
> > will break way too many existing deployments.
> > 
> > We need to socialize info in that blog post above more widely and
> > especially ensure that apps are not using that by default. I don't
> > see it being viable to formally deprecate it in QEMU any time soon
> > though given existing usage.
> 
> Well, getting that message to the users is the point of deprecating it.
> I think in this specific case we'll need a longer (maybe much longer)
> deprecation period than only two releases.  But I think it still makes
> sense to deprecate it now.

As mentioned elsewhere in this thread, I think it is important that
QEMU distinction between devices that are best practice / recommended
for use with KVM virt, vs devices that exist solely for sake of
emulating hardware for use with old platforms.

I agree that cirrus doesn't have a place in a KVM guest for future,
but I don't thjink that means it should be deprecated & removed from
QEMU entirely, as its still relevant from POV of QEMU's goal to
emulate old hardware platforms.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

      reply	other threads:[~2018-10-30 18:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  8:52 [Qemu-devel] [PATCH 0/3] RfC: add support for deprecated devices Gerd Hoffmann
2018-10-25  8:52 ` [Qemu-devel] [PATCH 1/3] qdev: add deprecation_reason to DeviceClass Gerd Hoffmann
2018-10-25 10:50   ` P J P
2018-10-25 11:12   ` Philippe Mathieu-Daudé
2018-10-29  9:19     ` Gerd Hoffmann
2018-10-25  8:52 ` [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated Gerd Hoffmann
2018-10-25 10:56   ` P J P
2018-10-25 20:40     ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2018-10-26  7:08       ` P J P
2018-10-26  9:54         ` Daniel P. Berrangé
2018-10-26 12:35           ` P J P
2018-10-25 11:15   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-10-25 20:27   ` Thomas Huth
2018-10-26  8:48   ` Paolo Bonzini
2018-10-26  9:34     ` P J P
2018-10-26 10:01       ` Paolo Bonzini
2018-10-26 11:53         ` P J P
2018-10-29  9:05           ` Gerd Hoffmann
2018-10-25  8:52 ` [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated Gerd Hoffmann
2018-10-25 10:59   ` P J P
2018-10-25 11:17   ` Philippe Mathieu-Daudé
2018-10-25 20:28   ` Thomas Huth
2018-10-25 20:37   ` Daniel P. Berrangé
2018-10-26  7:03     ` P J P
2018-10-26  9:42       ` Daniel P. Berrangé
2018-10-26  9:59         ` Daniel P. Berrangé
2018-10-26 10:03           ` Paolo Bonzini
2018-10-26 14:14             ` Daniel P. Berrangé
2018-10-26 18:56               ` P J P
2018-10-26 10:40         ` Dr. David Alan Gilbert
2018-10-26 13:25         ` [Qemu-devel] [libvirt] " Christian Borntraeger
2018-10-26  8:48     ` Cole Robinson
2018-10-26  9:43       ` Daniel P. Berrangé
2018-10-29  9:12     ` [Qemu-devel] " Gerd Hoffmann
2018-10-30 18:00       ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181030180050.GD3541@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.