All of lore.kernel.org
 help / color / mirror / Atom feed
* [CI 1/4] drm/i915: Kill WA 0528
@ 2018-10-31 16:28 Rodrigo Vivi
  2018-10-31 16:28 ` [CI 2/4] drm/i915: Kill WA 0826 Rodrigo Vivi
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Rodrigo Vivi @ 2018-10-31 16:28 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

First of all I believe this WA as written here was wrong.

Because it is listed on BSpec only for SKL and BXT, exactly
the only 2 platforms skipped here.

But also it is written there that we don't need this WA
anymore:
"This workaround is no longer needed since NV12 support is
dropped for the affected projects in #0870."

SO, let's kill it.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c3cadc09f859..ce60aefc14d7 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -455,18 +455,6 @@ static const struct intel_limit intel_limits_bxt = {
 	.p2 = { .p2_slow = 1, .p2_fast = 20 },
 };
 
-static void
-skl_wa_528(struct drm_i915_private *dev_priv, int pipe, bool enable)
-{
-	if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
-		return;
-
-	if (enable)
-		I915_WRITE(CHICKEN_PIPESL_1(pipe), HSW_FBCQ_DIS);
-	else
-		I915_WRITE(CHICKEN_PIPESL_1(pipe), 0);
-}
-
 static void
 skl_wa_clkgate(struct drm_i915_private *dev_priv, int pipe, bool enable)
 {
@@ -5286,7 +5274,6 @@ static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
 	if (needs_nv12_wa(dev_priv, old_crtc_state) &&
 	    !needs_nv12_wa(dev_priv, pipe_config)) {
 		skl_wa_clkgate(dev_priv, crtc->pipe, false);
-		skl_wa_528(dev_priv, crtc->pipe, false);
 	}
 }
 
@@ -5326,7 +5313,6 @@ static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state,
 	if (!needs_nv12_wa(dev_priv, old_crtc_state) &&
 	    needs_nv12_wa(dev_priv, pipe_config)) {
 		skl_wa_clkgate(dev_priv, crtc->pipe, true);
-		skl_wa_528(dev_priv, crtc->pipe, true);
 	}
 
 	/*
-- 
2.19.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-11-01 18:27 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-31 16:28 [CI 1/4] drm/i915: Kill WA 0528 Rodrigo Vivi
2018-10-31 16:28 ` [CI 2/4] drm/i915: Kill WA 0826 Rodrigo Vivi
2018-10-31 16:28 ` [CI 3/4] drm/i915: Define WA 0870 and kill dead code Rodrigo Vivi
2018-10-31 16:28 ` [CI 4/4] drm/i915: Remove CNL from WA 827 Rodrigo Vivi
2018-10-31 17:20 ` ✗ Fi.CI.BAT: failure for series starting with [CI,1/4] drm/i915: Kill WA 0528 Patchwork
2018-10-31 17:59 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-01  0:44 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-01 18:27   ` Rodrigo Vivi
2018-11-01  2:07 ` Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.