All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: firoz.khan@linaro.org
Cc: sparclinux@vger.kernel.org, gregkh@linuxfoundation.org,
	pombredanne@nexb.com, tglx@linutronix.de,
	kstewart@linuxfoundation.org, y2038@lists.linaro.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	arnd@arndb.de, deepa.kernel@gmail.com,
	marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH v2 3/4] sparc: add system call table generation support
Date: Thu, 01 Nov 2018 23:04:27 -0700 (PDT)	[thread overview]
Message-ID: <20181101.230427.364286844194487248.davem@davemloft.net> (raw)
In-Reply-To: <CALxhOnieTqFzs-D9mNB5nL0=iPGFE92Gwm-Coft7D0_7RJgHiQ@mail.gmail.com>

From: Firoz Khan <firoz.khan@linaro.org>
Date: Fri, 2 Nov 2018 11:09:57 +0530

> On Fri, 2 Nov 2018 at 02:03, David Miller <davem@davemloft.net> wrote:
>>
>> If sys_nis_syscall for the compat syscall shows up in a situation where the
>> native 32-bit syscall does have an entry, that's a BUG and the script should
>> point this out so that the bug can be fixed.
> 
> syscall.tbl is the input to the script, so the developers has the
> responsibility to fill the table
> properly. I don't know, we have to write a script which has to be
> smart enough to catch the
> wrong syscall entries.

It does not need anything "smart", it just needs to see that
sys_nis_syscall in the "compat" column just as my eyes noticed
them in your patch.

It can be completely automated.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: firoz.khan@linaro.org
Cc: sparclinux@vger.kernel.org, gregkh@linuxfoundation.org,
	pombredanne@nexb.com, tglx@linutronix.de,
	kstewart@linuxfoundation.org, y2038@lists.linaro.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	arnd@arndb.de, deepa.kernel@gmail.com,
	marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH v2 3/4] sparc: add system call table generation support
Date: Fri, 02 Nov 2018 06:04:27 +0000	[thread overview]
Message-ID: <20181101.230427.364286844194487248.davem@davemloft.net> (raw)
In-Reply-To: <CALxhOnieTqFzs-D9mNB5nL0=iPGFE92Gwm-Coft7D0_7RJgHiQ@mail.gmail.com>

From: Firoz Khan <firoz.khan@linaro.org>
Date: Fri, 2 Nov 2018 11:09:57 +0530

> On Fri, 2 Nov 2018 at 02:03, David Miller <davem@davemloft.net> wrote:
>>
>> If sys_nis_syscall for the compat syscall shows up in a situation where the
>> native 32-bit syscall does have an entry, that's a BUG and the script should
>> point this out so that the bug can be fixed.
> 
> syscall.tbl is the input to the script, so the developers has the
> responsibility to fill the table
> properly. I don't know, we have to write a script which has to be
> smart enough to catch the
> wrong syscall entries.

It does not need anything "smart", it just needs to see that
sys_nis_syscall in the "compat" column just as my eyes noticed
them in your patch.

It can be completely automated.

  reply	other threads:[~2018-11-02  6:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 13:53 [PATCH v2 0/4] sparc: system call table generation support Firoz Khan
2018-11-01 13:53 ` Firoz Khan
2018-11-01 13:53 ` [PATCH v2 1/4] sparc: move __IGNORE* entries to non uapi header Firoz Khan
2018-11-01 13:53   ` Firoz Khan
2018-11-01 13:53 ` [PATCH v2 2/4] sparc: add __NR_syscalls along with NR_syscalls Firoz Khan
2018-11-01 13:54   ` Firoz Khan
2018-11-01 13:53 ` [PATCH v2 3/4] sparc: add system call table generation support Firoz Khan
2018-11-01 13:54   ` Firoz Khan
2018-11-01 20:33   ` David Miller
2018-11-01 20:33     ` David Miller
2018-11-01 20:33     ` David Miller
2018-11-02  5:39     ` Firoz Khan
2018-11-02  5:51       ` Firoz Khan
2018-11-02  5:39       ` Firoz Khan
2018-11-02  6:04       ` David Miller [this message]
2018-11-02  6:04         ` David Miller
2018-11-05 10:48     ` Arnd Bergmann
2018-11-05 10:48       ` Arnd Bergmann
2018-11-06  4:28       ` David Miller
2018-11-06  4:28         ` David Miller
2018-11-01 13:53 ` [PATCH v2 4/4] sparc: generate uapi header and system call table files Firoz Khan
2018-11-01 13:54   ` Firoz Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101.230427.364286844194487248.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=firoz.khan@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.