* [PATCH -next] firewire: net: remove set but not used variable 'guid'
@ 2018-11-01 2:33 YueHaibing
0 siblings, 0 replies; 2+ messages in thread
From: YueHaibing @ 2018-11-01 2:33 UTC (permalink / raw)
To: stefanr; +Cc: linux-kernel, linux1394-devel, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/firewire/net.c:488:9: warning:
variable ‘guid’ set but not used [-Wunused-but-set-variable]
It not used anymore after commit 6752c8db8e0c ("firewire net, ipv4 arp:
Extend hardware address and remove driver-level packet inspection.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/firewire/net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 82ba110..5dcb991 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -485,7 +485,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
{
struct fwnet_device *dev;
int status;
- __be64 guid;
switch (ether_type) {
case ETH_P_ARP:
@@ -507,7 +506,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
* Parse the encapsulation header. This actually does the job of
* converting to an ethernet-like pseudo frame header.
*/
- guid = cpu_to_be64(dev->card->guid);
if (dev_hard_header(skb, net, ether_type,
is_broadcast ? net->broadcast : net->dev_addr,
NULL, skb->len) >= 0) {
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] firewire: net: remove set but not used variable 'guid'
@ 2019-01-29 2:54 YueHaibing
0 siblings, 0 replies; 2+ messages in thread
From: YueHaibing @ 2019-01-29 2:54 UTC (permalink / raw)
To: stefanr, davem; +Cc: linux-kernel, linux1394-devel, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/firewire/net.c:488:9:
warning: variable 'guid' set but not used [-Wunused-but-set-variable]
It not used since commit 6752c8db8e0c ("firewire net, ipv4 arp:
Extend hardware address and remove driver-level packet inspection.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/firewire/net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 82ba110..5dcb991 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -485,7 +485,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
{
struct fwnet_device *dev;
int status;
- __be64 guid;
switch (ether_type) {
case ETH_P_ARP:
@@ -507,7 +506,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
* Parse the encapsulation header. This actually does the job of
* converting to an ethernet-like pseudo frame header.
*/
- guid = cpu_to_be64(dev->card->guid);
if (dev_hard_header(skb, net, ether_type,
is_broadcast ? net->broadcast : net->dev_addr,
NULL, skb->len) >= 0) {
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-29 2:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 2:33 [PATCH -next] firewire: net: remove set but not used variable 'guid' YueHaibing
2019-01-29 2:54 YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.