[bug report] rapidio: add RapidIO channelized messaging driver

* [bug report] rapidio: add RapidIO channelized messaging driver
@ 2018-11-01  5:44 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-11-01  5:44 UTC (permalink / raw)
  To: kernel-janitors

Hello Alexandre Bounine,

This is a semi-automatic email about new static checker warnings.

The patch b6e8d4aa1110: "rapidio: add RapidIO channelized messaging 
driver" from Aug 2, 2016, leads to the following Smatch complaint:

    drivers/rapidio/rio_cm.c:1220 riocm_ch_listen()
     error: we previously assumed 'ch' could be null (see line 1218)

drivers/rapidio/rio_cm.c
  1217		ch = riocm_get_channel(ch_id);
  1218		if (!ch || !riocm_cmp_exch(ch, RIO_CM_CHAN_BOUND, RIO_CM_LISTEN))
                    ^^^
Check.

  1219			ret = -EINVAL;
  1220		riocm_put_channel(ch);
                                  ^^
Unchecked dereference.

  1221		return ret;
  1222	}

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread