From: "Stefan Mätje" <stefan.maetje@esd.eu>
To: <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Cc: "Stefan Mätje" <stefan.maetje@esd.eu>
Subject: [PATCH 0/1] PCI/ASPM: Proposal to add a fix for an erratum of the PI7C9X111SLB PCI-to-PCIe bridge
Date: Thu, 1 Nov 2018 20:22:28 +0100 [thread overview]
Message-ID: <20181101192229.48352-1-stefan.maetje@esd.eu> (raw)
The proposed patch fixes an erratum of the PI7C9X111SLB PCI-to-PCIe bridge in reverse mode.
It is somewhat ugly because it introduces hardware dependend code in the function
pcie_aspm_configure_common_clock() of drivers/pci/pcie/aspm.c that is totally device agnostic
atm. Also because the code which checks for the PI7C9X111SLB bridge and then applies a workaround
is executed for all devices that are candidates for a PCIe link clock reconfiguration. But I have
no idea how to move the code out of this "hotpath".
It would be cool if the fix could be included in the current release.
To quote the errata sheet:
> In Reverse Mode, retrain Link bit is not cleared automatically; this bit
> needs to be cleared manually by configuration write after it is set.
>
> Problem:
> In Reverse mode, after setting Retrain Link (bit 5 of register C0h), this bit will stay on
> and PI7C9x111SL will continuously retrain until this bit is cleared by another
> Configuration Write to register C0h.
>
> Workaround:
> Issue another configuration write to clear Retrain Link bit after setting this bit. No delay
> is required between these two configuration write.
Regards,
Stefan
Stefan Mätje (1):
PCI/ASPM: Add a fix for an erratum of the PI7C9X111SLB PCI-to-PCIe
bridge
drivers/pci/pcie/aspm.c | 9 +++++++++
1 file changed, 9 insertions(+)
--
2.15.0
next reply other threads:[~2018-11-01 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 19:22 Stefan Mätje [this message]
2018-11-01 19:22 ` [PATCH 1/1] PCI/ASPM: Add a fix for an erratum of the PI7C9X111SLB PCI-to-PCIe bridge Stefan Mätje
2018-11-01 20:06 ` Sinan Kaya
2018-11-02 11:08 ` Stefan Mätje
2019-01-30 23:26 ` Bjorn Helgaas
2019-02-07 15:16 ` Stefan Mätje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101192229.48352-1-stefan.maetje@esd.eu \
--to=stefan.maetje@esd.eu \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.