From: "Stefan Mätje" <Stefan.Maetje@esd.eu>
To: Sinan Kaya <okaya@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/1] PCI/ASPM: Add a fix for an erratum of the PI7C9X111SLB PCI-to-PCIe bridge
Date: Fri, 2 Nov 2018 12:08:42 +0100 [thread overview]
Message-ID: <64feebd1-8d14-8c9d-1054-6b26934e0979@esd.eu> (raw)
In-Reply-To: <626f2816-5f2b-b611-6177-d393ef0cdd0e@kernel.org>
Am 01.11.18 um 21:06 schrieb Sinan Kaya:
> On 11/1/2018 3:22 PM, Stefan Mätje wrote:
>> + b/drivers/pci/pcie/aspm.c
>> @@ -268,6 +268,15 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
>> /* Retrain link */
>> reg16 |= PCI_EXP_LNKCTL_RL;
>> pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16);
>> + if (0x12d8 == parent->vendor && 0xe111 == parent->device) {
>> + /*
>> + * Due to an erratum in the Pericom PI7C9X111SLB bridge in
>> + * reverse mode the retrain link bit needs to be cleared
>> + * again manually to allow the link training to succeed.
>> + */
>> + reg16 &= ~PCI_EXP_LNKCTL_RL;
>> + pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16);
>> + }
>
> The typical model is to abstract quirk work into quirks.c and add some
> callbacks from the actual code.
Yes, I'm aware of the quirks.c code. But I don't believe the problem can be solved
by a quirk function that is run via pci_fixup_device() at certain points of the
PCI scan (i. e. pci_fixup_pass like pci_fixup_early / pci_fixup_header ...) after
pcie_aspm_cap_init() has run.
Let's have a look at the function pcie_aspm_cap_init() from where pcie_aspm_configure_common_clock()
is called (where the patch was included). Be aware of the fact that the PCI express link downstream
is broken after leaving that function without the patch. But looking in pcie_aspm_cap_init() you can
see that it is reloading the ASPM registers from the child device after returning from
pcie_aspm_configure_common_clock() and from this point on it is working on bogus ASPM register
contents.
Therefore I think the rest of pcie_aspm_cap_init() is doing nothing sensible for the downstream
PCIe tree. Also I think that pcie_aspm_configure_common_clock() must be fixed in a way that after
leaving that function the PCIe downstream link is still working. This is what my patch is good for.
Best regards,
Stefan
next prev parent reply other threads:[~2018-11-02 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 19:22 [PATCH 0/1] PCI/ASPM: Proposal to add a fix for an erratum of the PI7C9X111SLB PCI-to-PCIe bridge Stefan Mätje
2018-11-01 19:22 ` [PATCH 1/1] PCI/ASPM: Add " Stefan Mätje
2018-11-01 20:06 ` Sinan Kaya
2018-11-02 11:08 ` Stefan Mätje [this message]
2019-01-30 23:26 ` Bjorn Helgaas
2019-02-07 15:16 ` Stefan Mätje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64feebd1-8d14-8c9d-1054-6b26934e0979@esd.eu \
--to=stefan.maetje@esd.eu \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.