All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: 禹舟键 <ufo19890607@gmail.com>
Cc: akpm@linux-foundation.org, rientjes@google.com,
	kirill.shutemov@linux.intel.com, aarcange@redhat.com,
	penguin-kernel@i-love.sakura.ne.jp, guro@fb.com,
	yang.s@alibaba-inc.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Wind Yu <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v15 1/2] Reorganize the oom report in dump_header
Date: Fri, 2 Nov 2018 09:34:13 +0100	[thread overview]
Message-ID: <20181102083413.GR23921@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHCio2jZ-RRuJ02ARmio5YON4mn0jwtuK_purFRxqSuVD=JsPA@mail.gmail.com>

On Fri 02-11-18 14:18:59, 禹舟键 wrote:
> Hi Michal
> The message-id is as below
> https://lkml.org/lkml/2018/7/31/148

David said
: It's possible that p is NULL when calling dump_header().  In this case we
: do not want to print any line concerning a victim because no oom kill has
: occurred.

This means that we should check for p rather than oc.

-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: 禹舟键 <ufo19890607@gmail.com>
Cc: akpm@linux-foundation.org, rientjes@google.com,
	kirill.shutemov@linux.intel.com, aarcange@redhat.com,
	penguin-kernel@i-love.sakura.ne.jp, guro@fb.com,
	yang.s@alibaba-inc.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Wind Yu <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v15 1/2] Reorganize the oom report in dump_header
Date: Fri, 2 Nov 2018 09:34:13 +0100	[thread overview]
Message-ID: <20181102083413.GR23921@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHCio2jZ-RRuJ02ARmio5YON4mn0jwtuK_purFRxqSuVD=JsPA@mail.gmail.com>

On Fri 02-11-18 14:18:59, c|1e??e?(R) wrote:
> Hi Michal
> The message-id is as below
> https://lkml.org/lkml/2018/7/31/148

David said
: It's possible that p is NULL when calling dump_header().  In this case we
: do not want to print any line concerning a victim because no oom kill has
: occurred.

This means that we should check for p rather than oc.

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2018-11-02  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29 13:06 [PATCH v15 1/2] Reorganize the oom report in dump_header ufo19890607
2018-09-29 13:06 ` [PATCH v15 2/2] Add oom victim's memcg to the oom context information ufo19890607
2018-10-31 13:50 ` [PATCH v15 1/2] Reorganize the oom report in dump_header Michal Hocko
2018-11-01 10:09   ` 禹舟键
2018-11-01 10:30     ` Michal Hocko
2018-11-01 10:30       ` Michal Hocko
2018-11-02  6:18       ` 禹舟键
2018-11-02  8:34         ` Michal Hocko [this message]
2018-11-02  8:34           ` Michal Hocko
2018-11-21 11:29 ufo19890607
2018-11-22 13:38 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181102083413.GR23921@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rientjes@google.com \
    --cc=ufo19890607@gmail.com \
    --cc=yang.s@alibaba-inc.com \
    --cc=yuzhoujian@didichuxing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.