* [PATCH] drm/lease: drop EXPORT_SYMBOL
@ 2018-11-02 14:31 Daniel Vetter
2018-11-02 15:05 ` Keith Packard
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2018-11-02 14:31 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Keith Packard, Daniel Vetter
Leases are entirely implemented within drm.ko, no need to even tempt
drivers into doing nasty things. And if there's really a need, we can
always re-export these again.
Cc: Keith Packard <keithp@keithp.com>
Cc: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_lease.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c
index ce49d1919214..7e02fdd7d3d1 100644
--- a/drivers/gpu/drm/drm_lease.c
+++ b/drivers/gpu/drm/drm_lease.c
@@ -39,7 +39,6 @@ struct drm_master *drm_lease_owner(struct drm_master *master)
master = master->lessor;
return master;
}
-EXPORT_SYMBOL(drm_lease_owner);
/**
* _drm_find_lessee - find lessee by id (idr_mutex held)
@@ -117,7 +116,6 @@ bool _drm_lease_held(struct drm_file *file_priv, int id)
return _drm_lease_held_master(file_priv->master, id);
}
-EXPORT_SYMBOL(_drm_lease_held);
/**
* drm_lease_held - check drm_mode_object lease status (idr_mutex not held)
@@ -144,7 +142,6 @@ bool drm_lease_held(struct drm_file *file_priv, int id)
mutex_unlock(&master->dev->mode_config.idr_mutex);
return ret;
}
-EXPORT_SYMBOL(drm_lease_held);
/**
* drm_lease_filter_crtcs - restricted crtc set to leased values (idr_mutex not held)
@@ -184,7 +181,6 @@ uint32_t drm_lease_filter_crtcs(struct drm_file *file_priv, uint32_t crtcs_in)
mutex_unlock(&master->dev->mode_config.idr_mutex);
return crtcs_out;
}
-EXPORT_SYMBOL(drm_lease_filter_crtcs);
/*
* drm_lease_create - create a new drm_master with leased objects (idr_mutex not held)
--
2.14.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/lease: drop EXPORT_SYMBOL
2018-11-02 14:31 [PATCH] drm/lease: drop EXPORT_SYMBOL Daniel Vetter
@ 2018-11-02 15:05 ` Keith Packard
2018-11-02 20:57 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Keith Packard @ 2018-11-02 15:05 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
[-- Attachment #1.1: Type: text/plain, Size: 431 bytes --]
Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> Leases are entirely implemented within drm.ko, no need to even tempt
> drivers into doing nasty things. And if there's really a need, we can
> always re-export these again.
>
> Cc: Keith Packard <keithp@keithp.com>
> Cc: Dave Airlie <airlied@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Keith Packard <keithp@keithp.com>
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/lease: drop EXPORT_SYMBOL
2018-11-02 15:05 ` Keith Packard
@ 2018-11-02 20:57 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-11-02 20:57 UTC (permalink / raw)
To: Keith Packard; +Cc: Daniel Vetter, DRI Development, Daniel Vetter
On Fri, Nov 02, 2018 at 08:05:07AM -0700, Keith Packard wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
>
> > Leases are entirely implemented within drm.ko, no need to even tempt
> > drivers into doing nasty things. And if there's really a need, we can
> > always re-export these again.
> >
> > Cc: Keith Packard <keithp@keithp.com>
> > Cc: Dave Airlie <airlied@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Acked-by: Keith Packard <keithp@keithp.com>
Applied, thanks for taking a look.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-02 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 14:31 [PATCH] drm/lease: drop EXPORT_SYMBOL Daniel Vetter
2018-11-02 15:05 ` Keith Packard
2018-11-02 20:57 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.