* [PATCH 1/2] drm/i915/icl: Configure MG PHY gating for HDMI ports too
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
@ 2018-11-02 19:26 ` Imre Deak
2018-11-02 21:51 ` Souza, Jose
2018-11-02 19:26 ` [PATCH 2/2] drm/i915/icl: Configure MG DP mode " Imre Deak
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Imre Deak @ 2018-11-02 19:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
The MG PHY clock gating needs to be configured for Type C
static/fixed/legacy HDMI ports the same way it's configured for Type C
static/fixed/legacy and aternate mode DP ports, fix this.
Bspec: 4232, 21735
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 70 ++++++++++++++++++++++++++++++++++++++++
drivers/gpu/drm/i915/intel_dp.c | 66 -------------------------------------
drivers/gpu/drm/i915/intel_drv.h | 2 --
3 files changed, 70 insertions(+), 68 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 3eea987e909b..cb06058179fd 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2914,6 +2914,72 @@ static void intel_ddi_clk_disable(struct intel_encoder *encoder)
}
}
+static void icl_enable_phy_clock_gating(struct intel_digital_port *dig_port)
+{
+ struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
+ enum port port = dig_port->base.port;
+ enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
+ i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port, 1) };
+ u32 val;
+ int i;
+
+ if (tc_port == PORT_TC_NONE)
+ return;
+
+ for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
+ val = I915_READ(mg_regs[i]);
+ val |= MG_DP_MODE_CFG_TR2PWR_GATING |
+ MG_DP_MODE_CFG_TRPWR_GATING |
+ MG_DP_MODE_CFG_CLNPWR_GATING |
+ MG_DP_MODE_CFG_DIGPWR_GATING |
+ MG_DP_MODE_CFG_GAONPWR_GATING;
+ I915_WRITE(mg_regs[i], val);
+ }
+
+ val = I915_READ(MG_MISC_SUS0(tc_port));
+ val |= MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE(3) |
+ MG_MISC_SUS0_CFG_TR2PWR_GATING |
+ MG_MISC_SUS0_CFG_CL2PWR_GATING |
+ MG_MISC_SUS0_CFG_GAONPWR_GATING |
+ MG_MISC_SUS0_CFG_TRPWR_GATING |
+ MG_MISC_SUS0_CFG_CL1PWR_GATING |
+ MG_MISC_SUS0_CFG_DGPWR_GATING;
+ I915_WRITE(MG_MISC_SUS0(tc_port), val);
+}
+
+static void icl_disable_phy_clock_gating(struct intel_digital_port *dig_port)
+{
+ struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
+ enum port port = dig_port->base.port;
+ enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
+ i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port, 1) };
+ u32 val;
+ int i;
+
+ if (tc_port == PORT_TC_NONE)
+ return;
+
+ for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
+ val = I915_READ(mg_regs[i]);
+ val &= ~(MG_DP_MODE_CFG_TR2PWR_GATING |
+ MG_DP_MODE_CFG_TRPWR_GATING |
+ MG_DP_MODE_CFG_CLNPWR_GATING |
+ MG_DP_MODE_CFG_DIGPWR_GATING |
+ MG_DP_MODE_CFG_GAONPWR_GATING);
+ I915_WRITE(mg_regs[i], val);
+ }
+
+ val = I915_READ(MG_MISC_SUS0(tc_port));
+ val &= ~(MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE_MASK |
+ MG_MISC_SUS0_CFG_TR2PWR_GATING |
+ MG_MISC_SUS0_CFG_CL2PWR_GATING |
+ MG_MISC_SUS0_CFG_GAONPWR_GATING |
+ MG_MISC_SUS0_CFG_TRPWR_GATING |
+ MG_MISC_SUS0_CFG_CL1PWR_GATING |
+ MG_MISC_SUS0_CFG_DGPWR_GATING);
+ I915_WRITE(MG_MISC_SUS0(tc_port), val);
+}
+
static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
const struct drm_connector_state *conn_state)
@@ -2978,6 +3044,8 @@ static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder,
intel_display_power_get(dev_priv, dig_port->ddi_io_power_domain);
+ icl_disable_phy_clock_gating(dig_port);
+
if (IS_ICELAKE(dev_priv))
icl_ddi_vswing_sequence(encoder, crtc_state->port_clock,
level, INTEL_OUTPUT_HDMI);
@@ -2988,6 +3056,8 @@ static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder,
else
intel_prepare_hdmi_ddi_buffers(encoder, level);
+ icl_enable_phy_clock_gating(dig_port);
+
if (IS_GEN9_BC(dev_priv))
skl_ddi_set_iboost(encoder, level, INTEL_OUTPUT_HDMI);
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index b39b4bda8e40..127fc82902c6 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -307,72 +307,6 @@ void icl_program_mg_dp_mode(struct intel_dp *intel_dp)
I915_WRITE(MG_DP_MODE(port, 1), ln1);
}
-void icl_enable_phy_clock_gating(struct intel_digital_port *dig_port)
-{
- struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
- enum port port = dig_port->base.port;
- enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
- i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port, 1) };
- u32 val;
- int i;
-
- if (tc_port == PORT_TC_NONE)
- return;
-
- for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
- val = I915_READ(mg_regs[i]);
- val |= MG_DP_MODE_CFG_TR2PWR_GATING |
- MG_DP_MODE_CFG_TRPWR_GATING |
- MG_DP_MODE_CFG_CLNPWR_GATING |
- MG_DP_MODE_CFG_DIGPWR_GATING |
- MG_DP_MODE_CFG_GAONPWR_GATING;
- I915_WRITE(mg_regs[i], val);
- }
-
- val = I915_READ(MG_MISC_SUS0(tc_port));
- val |= MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE(3) |
- MG_MISC_SUS0_CFG_TR2PWR_GATING |
- MG_MISC_SUS0_CFG_CL2PWR_GATING |
- MG_MISC_SUS0_CFG_GAONPWR_GATING |
- MG_MISC_SUS0_CFG_TRPWR_GATING |
- MG_MISC_SUS0_CFG_CL1PWR_GATING |
- MG_MISC_SUS0_CFG_DGPWR_GATING;
- I915_WRITE(MG_MISC_SUS0(tc_port), val);
-}
-
-void icl_disable_phy_clock_gating(struct intel_digital_port *dig_port)
-{
- struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
- enum port port = dig_port->base.port;
- enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
- i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port, 1) };
- u32 val;
- int i;
-
- if (tc_port == PORT_TC_NONE)
- return;
-
- for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
- val = I915_READ(mg_regs[i]);
- val &= ~(MG_DP_MODE_CFG_TR2PWR_GATING |
- MG_DP_MODE_CFG_TRPWR_GATING |
- MG_DP_MODE_CFG_CLNPWR_GATING |
- MG_DP_MODE_CFG_DIGPWR_GATING |
- MG_DP_MODE_CFG_GAONPWR_GATING);
- I915_WRITE(mg_regs[i], val);
- }
-
- val = I915_READ(MG_MISC_SUS0(tc_port));
- val &= ~(MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE_MASK |
- MG_MISC_SUS0_CFG_TR2PWR_GATING |
- MG_MISC_SUS0_CFG_CL2PWR_GATING |
- MG_MISC_SUS0_CFG_GAONPWR_GATING |
- MG_MISC_SUS0_CFG_TRPWR_GATING |
- MG_MISC_SUS0_CFG_CL1PWR_GATING |
- MG_MISC_SUS0_CFG_DGPWR_GATING);
- I915_WRITE(MG_MISC_SUS0(tc_port), val);
-}
-
int
intel_dp_max_data_rate(int max_link_clock, int max_lanes)
{
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 191c26e17f2d..d0be59599e23 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1820,8 +1820,6 @@ void intel_edp_drrs_invalidate(struct drm_i915_private *dev_priv,
void intel_edp_drrs_flush(struct drm_i915_private *dev_priv,
unsigned int frontbuffer_bits);
void icl_program_mg_dp_mode(struct intel_dp *intel_dp);
-void icl_enable_phy_clock_gating(struct intel_digital_port *dig_port);
-void icl_disable_phy_clock_gating(struct intel_digital_port *dig_port);
void
intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] drm/i915/icl: Configure MG PHY gating for HDMI ports too
2018-11-02 19:26 ` [PATCH 1/2] drm/i915/icl: Configure MG PHY gating for HDMI ports too Imre Deak
@ 2018-11-02 21:51 ` Souza, Jose
0 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2018-11-02 21:51 UTC (permalink / raw)
To: intel-gfx, Deak, Imre; +Cc: Zanoni, Paulo R
On Fri, 2018-11-02 at 21:26 +0200, Imre Deak wrote:
> The MG PHY clock gating needs to be configured for Type C
> static/fixed/legacy HDMI ports the same way it's configured for Type
> C
> static/fixed/legacy and aternate mode DP ports, fix this.
>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Bspec: 4232, 21735
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 70
> ++++++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/i915/intel_dp.c | 66 ------------------------------
> -------
> drivers/gpu/drm/i915/intel_drv.h | 2 --
> 3 files changed, 70 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 3eea987e909b..cb06058179fd 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2914,6 +2914,72 @@ static void intel_ddi_clk_disable(struct
> intel_encoder *encoder)
> }
> }
>
> +static void icl_enable_phy_clock_gating(struct intel_digital_port
> *dig_port)
> +{
> + struct drm_i915_private *dev_priv = to_i915(dig_port-
> >base.base.dev);
> + enum port port = dig_port->base.port;
> + enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> + i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port,
> 1) };
> + u32 val;
> + int i;
> +
> + if (tc_port == PORT_TC_NONE)
> + return;
> +
> + for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
> + val = I915_READ(mg_regs[i]);
> + val |= MG_DP_MODE_CFG_TR2PWR_GATING |
> + MG_DP_MODE_CFG_TRPWR_GATING |
> + MG_DP_MODE_CFG_CLNPWR_GATING |
> + MG_DP_MODE_CFG_DIGPWR_GATING |
> + MG_DP_MODE_CFG_GAONPWR_GATING;
> + I915_WRITE(mg_regs[i], val);
> + }
> +
> + val = I915_READ(MG_MISC_SUS0(tc_port));
> + val |= MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE(3) |
> + MG_MISC_SUS0_CFG_TR2PWR_GATING |
> + MG_MISC_SUS0_CFG_CL2PWR_GATING |
> + MG_MISC_SUS0_CFG_GAONPWR_GATING |
> + MG_MISC_SUS0_CFG_TRPWR_GATING |
> + MG_MISC_SUS0_CFG_CL1PWR_GATING |
> + MG_MISC_SUS0_CFG_DGPWR_GATING;
> + I915_WRITE(MG_MISC_SUS0(tc_port), val);
> +}
> +
> +static void icl_disable_phy_clock_gating(struct intel_digital_port
> *dig_port)
> +{
> + struct drm_i915_private *dev_priv = to_i915(dig_port-
> >base.base.dev);
> + enum port port = dig_port->base.port;
> + enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> + i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port,
> 1) };
> + u32 val;
> + int i;
> +
> + if (tc_port == PORT_TC_NONE)
> + return;
> +
> + for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
> + val = I915_READ(mg_regs[i]);
> + val &= ~(MG_DP_MODE_CFG_TR2PWR_GATING |
> + MG_DP_MODE_CFG_TRPWR_GATING |
> + MG_DP_MODE_CFG_CLNPWR_GATING |
> + MG_DP_MODE_CFG_DIGPWR_GATING |
> + MG_DP_MODE_CFG_GAONPWR_GATING);
> + I915_WRITE(mg_regs[i], val);
> + }
> +
> + val = I915_READ(MG_MISC_SUS0(tc_port));
> + val &= ~(MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE_MASK |
> + MG_MISC_SUS0_CFG_TR2PWR_GATING |
> + MG_MISC_SUS0_CFG_CL2PWR_GATING |
> + MG_MISC_SUS0_CFG_GAONPWR_GATING |
> + MG_MISC_SUS0_CFG_TRPWR_GATING |
> + MG_MISC_SUS0_CFG_CL1PWR_GATING |
> + MG_MISC_SUS0_CFG_DGPWR_GATING);
> + I915_WRITE(MG_MISC_SUS0(tc_port), val);
> +}
> +
> static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,
> const struct intel_crtc_state
> *crtc_state,
> const struct drm_connector_state
> *conn_state)
> @@ -2978,6 +3044,8 @@ static void intel_ddi_pre_enable_hdmi(struct
> intel_encoder *encoder,
>
> intel_display_power_get(dev_priv, dig_port-
> >ddi_io_power_domain);
>
> + icl_disable_phy_clock_gating(dig_port);
> +
> if (IS_ICELAKE(dev_priv))
> icl_ddi_vswing_sequence(encoder, crtc_state-
> >port_clock,
> level, INTEL_OUTPUT_HDMI);
> @@ -2988,6 +3056,8 @@ static void intel_ddi_pre_enable_hdmi(struct
> intel_encoder *encoder,
> else
> intel_prepare_hdmi_ddi_buffers(encoder, level);
>
> + icl_enable_phy_clock_gating(dig_port);
> +
> if (IS_GEN9_BC(dev_priv))
> skl_ddi_set_iboost(encoder, level, INTEL_OUTPUT_HDMI);
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c
> b/drivers/gpu/drm/i915/intel_dp.c
> index b39b4bda8e40..127fc82902c6 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -307,72 +307,6 @@ void icl_program_mg_dp_mode(struct intel_dp
> *intel_dp)
> I915_WRITE(MG_DP_MODE(port, 1), ln1);
> }
>
> -void icl_enable_phy_clock_gating(struct intel_digital_port
> *dig_port)
> -{
> - struct drm_i915_private *dev_priv = to_i915(dig_port-
> >base.base.dev);
> - enum port port = dig_port->base.port;
> - enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> - i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port,
> 1) };
> - u32 val;
> - int i;
> -
> - if (tc_port == PORT_TC_NONE)
> - return;
> -
> - for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
> - val = I915_READ(mg_regs[i]);
> - val |= MG_DP_MODE_CFG_TR2PWR_GATING |
> - MG_DP_MODE_CFG_TRPWR_GATING |
> - MG_DP_MODE_CFG_CLNPWR_GATING |
> - MG_DP_MODE_CFG_DIGPWR_GATING |
> - MG_DP_MODE_CFG_GAONPWR_GATING;
> - I915_WRITE(mg_regs[i], val);
> - }
> -
> - val = I915_READ(MG_MISC_SUS0(tc_port));
> - val |= MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE(3) |
> - MG_MISC_SUS0_CFG_TR2PWR_GATING |
> - MG_MISC_SUS0_CFG_CL2PWR_GATING |
> - MG_MISC_SUS0_CFG_GAONPWR_GATING |
> - MG_MISC_SUS0_CFG_TRPWR_GATING |
> - MG_MISC_SUS0_CFG_CL1PWR_GATING |
> - MG_MISC_SUS0_CFG_DGPWR_GATING;
> - I915_WRITE(MG_MISC_SUS0(tc_port), val);
> -}
> -
> -void icl_disable_phy_clock_gating(struct intel_digital_port
> *dig_port)
> -{
> - struct drm_i915_private *dev_priv = to_i915(dig_port-
> >base.base.dev);
> - enum port port = dig_port->base.port;
> - enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> - i915_reg_t mg_regs[2] = { MG_DP_MODE(port, 0), MG_DP_MODE(port,
> 1) };
> - u32 val;
> - int i;
> -
> - if (tc_port == PORT_TC_NONE)
> - return;
> -
> - for (i = 0; i < ARRAY_SIZE(mg_regs); i++) {
> - val = I915_READ(mg_regs[i]);
> - val &= ~(MG_DP_MODE_CFG_TR2PWR_GATING |
> - MG_DP_MODE_CFG_TRPWR_GATING |
> - MG_DP_MODE_CFG_CLNPWR_GATING |
> - MG_DP_MODE_CFG_DIGPWR_GATING |
> - MG_DP_MODE_CFG_GAONPWR_GATING);
> - I915_WRITE(mg_regs[i], val);
> - }
> -
> - val = I915_READ(MG_MISC_SUS0(tc_port));
> - val &= ~(MG_MISC_SUS0_SUSCLK_DYNCLKGATE_MODE_MASK |
> - MG_MISC_SUS0_CFG_TR2PWR_GATING |
> - MG_MISC_SUS0_CFG_CL2PWR_GATING |
> - MG_MISC_SUS0_CFG_GAONPWR_GATING |
> - MG_MISC_SUS0_CFG_TRPWR_GATING |
> - MG_MISC_SUS0_CFG_CL1PWR_GATING |
> - MG_MISC_SUS0_CFG_DGPWR_GATING);
> - I915_WRITE(MG_MISC_SUS0(tc_port), val);
> -}
> -
> int
> intel_dp_max_data_rate(int max_link_clock, int max_lanes)
> {
> diff --git a/drivers/gpu/drm/i915/intel_drv.h
> b/drivers/gpu/drm/i915/intel_drv.h
> index 191c26e17f2d..d0be59599e23 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1820,8 +1820,6 @@ void intel_edp_drrs_invalidate(struct
> drm_i915_private *dev_priv,
> void intel_edp_drrs_flush(struct drm_i915_private *dev_priv,
> unsigned int frontbuffer_bits);
> void icl_program_mg_dp_mode(struct intel_dp *intel_dp);
> -void icl_enable_phy_clock_gating(struct intel_digital_port
> *dig_port);
> -void icl_disable_phy_clock_gating(struct intel_digital_port
> *dig_port);
>
> void
> intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] drm/i915/icl: Configure MG DP mode for HDMI ports too
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
2018-11-02 19:26 ` [PATCH 1/2] drm/i915/icl: Configure MG PHY gating for HDMI ports too Imre Deak
@ 2018-11-02 19:26 ` Imre Deak
2018-11-02 21:54 ` Souza, Jose
2018-11-02 19:49 ` ✗ Fi.CI.SPARSE: warning for drm/i915/icl: Fix suspend/resume for TypeC HDMI Patchwork
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Imre Deak @ 2018-11-02 19:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
The MG DP mode needs to be configured for Type C static/fixed/legacy
HDMI ports too, the same way as it's configured for Type C
static/fixed/legacy, fix this.
Bspec: 4232, 21735
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 68 +++++++++++++++++++++++++++++++++++++++-
drivers/gpu/drm/i915/intel_dp.c | 66 --------------------------------------
drivers/gpu/drm/i915/intel_drv.h | 1 -
3 files changed, 67 insertions(+), 68 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cb06058179fd..ab9a36c4ba3b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2980,6 +2980,71 @@ static void icl_disable_phy_clock_gating(struct intel_digital_port *dig_port)
I915_WRITE(MG_MISC_SUS0(tc_port), val);
}
+static void icl_program_mg_dp_mode(struct intel_digital_port *intel_dig_port)
+{
+ struct drm_i915_private *dev_priv = to_i915(intel_dig_port->base.base.dev);
+ enum port port = intel_dig_port->base.port;
+ enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
+ u32 ln0, ln1, lane_info;
+
+ if (tc_port == PORT_TC_NONE || intel_dig_port->tc_type == TC_PORT_TBT)
+ return;
+
+ ln0 = I915_READ(MG_DP_MODE(port, 0));
+ ln1 = I915_READ(MG_DP_MODE(port, 1));
+
+ switch (intel_dig_port->tc_type) {
+ case TC_PORT_TYPEC:
+ ln0 &= ~(MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE);
+ ln1 &= ~(MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE);
+
+ lane_info = (I915_READ(PORT_TX_DFLEXDPSP) &
+ DP_LANE_ASSIGNMENT_MASK(tc_port)) >>
+ DP_LANE_ASSIGNMENT_SHIFT(tc_port);
+
+ switch (lane_info) {
+ case 0x1:
+ case 0x4:
+ break;
+ case 0x2:
+ ln0 |= MG_DP_MODE_CFG_DP_X1_MODE;
+ break;
+ case 0x3:
+ ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
+ MG_DP_MODE_CFG_DP_X2_MODE;
+ break;
+ case 0x8:
+ ln1 |= MG_DP_MODE_CFG_DP_X1_MODE;
+ break;
+ case 0xC:
+ ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
+ MG_DP_MODE_CFG_DP_X2_MODE;
+ break;
+ case 0xF:
+ ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
+ MG_DP_MODE_CFG_DP_X2_MODE;
+ ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
+ MG_DP_MODE_CFG_DP_X2_MODE;
+ break;
+ default:
+ MISSING_CASE(lane_info);
+ }
+ break;
+
+ case TC_PORT_LEGACY:
+ ln0 |= MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE;
+ ln1 |= MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE;
+ break;
+
+ default:
+ MISSING_CASE(intel_dig_port->tc_type);
+ return;
+ }
+
+ I915_WRITE(MG_DP_MODE(port, 0), ln0);
+ I915_WRITE(MG_DP_MODE(port, 1), ln1);
+}
+
static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
const struct drm_connector_state *conn_state)
@@ -3002,7 +3067,7 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,
intel_display_power_get(dev_priv, dig_port->ddi_io_power_domain);
- icl_program_mg_dp_mode(intel_dp);
+ icl_program_mg_dp_mode(dig_port);
icl_disable_phy_clock_gating(dig_port);
if (IS_ICELAKE(dev_priv))
@@ -3044,6 +3109,7 @@ static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder,
intel_display_power_get(dev_priv, dig_port->ddi_io_power_domain);
+ icl_program_mg_dp_mode(dig_port);
icl_disable_phy_clock_gating(dig_port);
if (IS_ICELAKE(dev_priv))
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 127fc82902c6..b667fa85f609 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -241,72 +241,6 @@ intel_dp_link_required(int pixel_clock, int bpp)
return DIV_ROUND_UP(pixel_clock * bpp, 8);
}
-void icl_program_mg_dp_mode(struct intel_dp *intel_dp)
-{
- struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
- struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
- enum port port = intel_dig_port->base.port;
- enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
- u32 ln0, ln1, lane_info;
-
- if (tc_port == PORT_TC_NONE || intel_dig_port->tc_type == TC_PORT_TBT)
- return;
-
- ln0 = I915_READ(MG_DP_MODE(port, 0));
- ln1 = I915_READ(MG_DP_MODE(port, 1));
-
- switch (intel_dig_port->tc_type) {
- case TC_PORT_TYPEC:
- ln0 &= ~(MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE);
- ln1 &= ~(MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE);
-
- lane_info = (I915_READ(PORT_TX_DFLEXDPSP) &
- DP_LANE_ASSIGNMENT_MASK(tc_port)) >>
- DP_LANE_ASSIGNMENT_SHIFT(tc_port);
-
- switch (lane_info) {
- case 0x1:
- case 0x4:
- break;
- case 0x2:
- ln0 |= MG_DP_MODE_CFG_DP_X1_MODE;
- break;
- case 0x3:
- ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
- MG_DP_MODE_CFG_DP_X2_MODE;
- break;
- case 0x8:
- ln1 |= MG_DP_MODE_CFG_DP_X1_MODE;
- break;
- case 0xC:
- ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
- MG_DP_MODE_CFG_DP_X2_MODE;
- break;
- case 0xF:
- ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
- MG_DP_MODE_CFG_DP_X2_MODE;
- ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
- MG_DP_MODE_CFG_DP_X2_MODE;
- break;
- default:
- MISSING_CASE(lane_info);
- }
- break;
-
- case TC_PORT_LEGACY:
- ln0 |= MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE;
- ln1 |= MG_DP_MODE_CFG_DP_X1_MODE | MG_DP_MODE_CFG_DP_X2_MODE;
- break;
-
- default:
- MISSING_CASE(intel_dig_port->tc_type);
- return;
- }
-
- I915_WRITE(MG_DP_MODE(port, 0), ln0);
- I915_WRITE(MG_DP_MODE(port, 1), ln1);
-}
-
int
intel_dp_max_data_rate(int max_link_clock, int max_lanes)
{
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index d0be59599e23..a0f90d684a6b 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1819,7 +1819,6 @@ void intel_edp_drrs_invalidate(struct drm_i915_private *dev_priv,
unsigned int frontbuffer_bits);
void intel_edp_drrs_flush(struct drm_i915_private *dev_priv,
unsigned int frontbuffer_bits);
-void icl_program_mg_dp_mode(struct intel_dp *intel_dp);
void
intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] drm/i915/icl: Configure MG DP mode for HDMI ports too
2018-11-02 19:26 ` [PATCH 2/2] drm/i915/icl: Configure MG DP mode " Imre Deak
@ 2018-11-02 21:54 ` Souza, Jose
0 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2018-11-02 21:54 UTC (permalink / raw)
To: intel-gfx, Deak, Imre; +Cc: Zanoni, Paulo R
On Fri, 2018-11-02 at 21:26 +0200, Imre Deak wrote:
> The MG DP mode needs to be configured for Type C static/fixed/legacy
> HDMI ports too, the same way as it's configured for Type C
> static/fixed/legacy, fix this.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Bspec: 4232, 21735
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 68
> +++++++++++++++++++++++++++++++++++++++-
> drivers/gpu/drm/i915/intel_dp.c | 66 ------------------------------
> --------
> drivers/gpu/drm/i915/intel_drv.h | 1 -
> 3 files changed, 67 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index cb06058179fd..ab9a36c4ba3b 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2980,6 +2980,71 @@ static void
> icl_disable_phy_clock_gating(struct intel_digital_port *dig_port)
> I915_WRITE(MG_MISC_SUS0(tc_port), val);
> }
>
> +static void icl_program_mg_dp_mode(struct intel_digital_port
> *intel_dig_port)
> +{
> + struct drm_i915_private *dev_priv = to_i915(intel_dig_port-
> >base.base.dev);
> + enum port port = intel_dig_port->base.port;
> + enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> + u32 ln0, ln1, lane_info;
> +
> + if (tc_port == PORT_TC_NONE || intel_dig_port->tc_type ==
> TC_PORT_TBT)
> + return;
> +
> + ln0 = I915_READ(MG_DP_MODE(port, 0));
> + ln1 = I915_READ(MG_DP_MODE(port, 1));
> +
> + switch (intel_dig_port->tc_type) {
> + case TC_PORT_TYPEC:
> + ln0 &= ~(MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE);
> + ln1 &= ~(MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE);
> +
> + lane_info = (I915_READ(PORT_TX_DFLEXDPSP) &
> + DP_LANE_ASSIGNMENT_MASK(tc_port)) >>
> + DP_LANE_ASSIGNMENT_SHIFT(tc_port);
> +
> + switch (lane_info) {
> + case 0x1:
> + case 0x4:
> + break;
> + case 0x2:
> + ln0 |= MG_DP_MODE_CFG_DP_X1_MODE;
> + break;
> + case 0x3:
> + ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
> + MG_DP_MODE_CFG_DP_X2_MODE;
> + break;
> + case 0x8:
> + ln1 |= MG_DP_MODE_CFG_DP_X1_MODE;
> + break;
> + case 0xC:
> + ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
> + MG_DP_MODE_CFG_DP_X2_MODE;
> + break;
> + case 0xF:
> + ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
> + MG_DP_MODE_CFG_DP_X2_MODE;
> + ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
> + MG_DP_MODE_CFG_DP_X2_MODE;
> + break;
> + default:
> + MISSING_CASE(lane_info);
> + }
> + break;
> +
> + case TC_PORT_LEGACY:
> + ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE;
> + ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE;
> + break;
> +
> + default:
> + MISSING_CASE(intel_dig_port->tc_type);
> + return;
> + }
> +
> + I915_WRITE(MG_DP_MODE(port, 0), ln0);
> + I915_WRITE(MG_DP_MODE(port, 1), ln1);
> +}
> +
> static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,
> const struct intel_crtc_state
> *crtc_state,
> const struct drm_connector_state
> *conn_state)
> @@ -3002,7 +3067,7 @@ static void intel_ddi_pre_enable_dp(struct
> intel_encoder *encoder,
>
> intel_display_power_get(dev_priv, dig_port-
> >ddi_io_power_domain);
>
> - icl_program_mg_dp_mode(intel_dp);
> + icl_program_mg_dp_mode(dig_port);
> icl_disable_phy_clock_gating(dig_port);
>
> if (IS_ICELAKE(dev_priv))
> @@ -3044,6 +3109,7 @@ static void intel_ddi_pre_enable_hdmi(struct
> intel_encoder *encoder,
>
> intel_display_power_get(dev_priv, dig_port-
> >ddi_io_power_domain);
>
> + icl_program_mg_dp_mode(dig_port);
> icl_disable_phy_clock_gating(dig_port);
>
> if (IS_ICELAKE(dev_priv))
> diff --git a/drivers/gpu/drm/i915/intel_dp.c
> b/drivers/gpu/drm/i915/intel_dp.c
> index 127fc82902c6..b667fa85f609 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -241,72 +241,6 @@ intel_dp_link_required(int pixel_clock, int bpp)
> return DIV_ROUND_UP(pixel_clock * bpp, 8);
> }
>
> -void icl_program_mg_dp_mode(struct intel_dp *intel_dp)
> -{
> - struct intel_digital_port *intel_dig_port =
> dp_to_dig_port(intel_dp);
> - struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> - enum port port = intel_dig_port->base.port;
> - enum tc_port tc_port = intel_port_to_tc(dev_priv, port);
> - u32 ln0, ln1, lane_info;
> -
> - if (tc_port == PORT_TC_NONE || intel_dig_port->tc_type ==
> TC_PORT_TBT)
> - return;
> -
> - ln0 = I915_READ(MG_DP_MODE(port, 0));
> - ln1 = I915_READ(MG_DP_MODE(port, 1));
> -
> - switch (intel_dig_port->tc_type) {
> - case TC_PORT_TYPEC:
> - ln0 &= ~(MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE);
> - ln1 &= ~(MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE);
> -
> - lane_info = (I915_READ(PORT_TX_DFLEXDPSP) &
> - DP_LANE_ASSIGNMENT_MASK(tc_port)) >>
> - DP_LANE_ASSIGNMENT_SHIFT(tc_port);
> -
> - switch (lane_info) {
> - case 0x1:
> - case 0x4:
> - break;
> - case 0x2:
> - ln0 |= MG_DP_MODE_CFG_DP_X1_MODE;
> - break;
> - case 0x3:
> - ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
> - MG_DP_MODE_CFG_DP_X2_MODE;
> - break;
> - case 0x8:
> - ln1 |= MG_DP_MODE_CFG_DP_X1_MODE;
> - break;
> - case 0xC:
> - ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
> - MG_DP_MODE_CFG_DP_X2_MODE;
> - break;
> - case 0xF:
> - ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
> - MG_DP_MODE_CFG_DP_X2_MODE;
> - ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
> - MG_DP_MODE_CFG_DP_X2_MODE;
> - break;
> - default:
> - MISSING_CASE(lane_info);
> - }
> - break;
> -
> - case TC_PORT_LEGACY:
> - ln0 |= MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE;
> - ln1 |= MG_DP_MODE_CFG_DP_X1_MODE |
> MG_DP_MODE_CFG_DP_X2_MODE;
> - break;
> -
> - default:
> - MISSING_CASE(intel_dig_port->tc_type);
> - return;
> - }
> -
> - I915_WRITE(MG_DP_MODE(port, 0), ln0);
> - I915_WRITE(MG_DP_MODE(port, 1), ln1);
> -}
> -
> int
> intel_dp_max_data_rate(int max_link_clock, int max_lanes)
> {
> diff --git a/drivers/gpu/drm/i915/intel_drv.h
> b/drivers/gpu/drm/i915/intel_drv.h
> index d0be59599e23..a0f90d684a6b 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1819,7 +1819,6 @@ void intel_edp_drrs_invalidate(struct
> drm_i915_private *dev_priv,
> unsigned int frontbuffer_bits);
> void intel_edp_drrs_flush(struct drm_i915_private *dev_priv,
> unsigned int frontbuffer_bits);
> -void icl_program_mg_dp_mode(struct intel_dp *intel_dp);
>
> void
> intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
2018-11-02 19:26 ` [PATCH 1/2] drm/i915/icl: Configure MG PHY gating for HDMI ports too Imre Deak
2018-11-02 19:26 ` [PATCH 2/2] drm/i915/icl: Configure MG DP mode " Imre Deak
@ 2018-11-02 19:49 ` Patchwork
2018-11-02 20:05 ` ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2018-11-02 19:49 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
URL : https://patchwork.freedesktop.org/series/51976/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/icl: Configure MG PHY gating for HDMI ports too
Okay!
Commit: drm/i915/icl: Configure MG DP mode for HDMI ports too
+drivers/gpu/drm/i915/intel_dp.c:365:28: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_dp.c:365:28: warning: expression using sizeof(void)
-drivers/gpu/drm/i915/intel_dp.c:365:28: warning: expression using sizeof(void)
-drivers/gpu/drm/i915/intel_dp.c:365:28: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
` (2 preceding siblings ...)
2018-11-02 19:49 ` ✗ Fi.CI.SPARSE: warning for drm/i915/icl: Fix suspend/resume for TypeC HDMI Patchwork
@ 2018-11-02 20:05 ` Patchwork
2018-11-02 22:47 ` [PATCH 0/2] " Souza, Jose
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2018-11-02 20:05 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
URL : https://patchwork.freedesktop.org/series/51976/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5081 -> Patchwork_10716 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51976/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10716 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@gem_cpu_reloc@basic:
fi-kbl-7560u: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (50 -> 44) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u
== Build changes ==
* Linux: CI_DRM_5081 -> Patchwork_10716
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10716: 5862e7326db031964c0da64846806ee65b6e672d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5862e7326db0 drm/i915/icl: Configure MG DP mode for HDMI ports too
5587a135f248 drm/i915/icl: Configure MG PHY gating for HDMI ports too
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10716/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
` (3 preceding siblings ...)
2018-11-02 20:05 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-02 22:47 ` Souza, Jose
2018-11-03 0:45 ` ✗ Fi.CI.IGT: failure for " Patchwork
2018-11-05 14:06 ` ✓ Fi.CI.IGT: success " Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2018-11-02 22:47 UTC (permalink / raw)
To: intel-gfx, Deak, Imre; +Cc: Zanoni, Paulo R
On Fri, 2018-11-02 at 21:26 +0200, Imre Deak wrote:
> This patch adds missing programming for static/fixed/legacy TypeC
> HDMI
> outputs. The lack of this resulted in blank screen when booting
> without
> an HDMI display being connected, or after system suspend/resume,
> since
> in these cases BIOS doesn't do the programming either.
This case is working now.
Tested-by: José Roberto de Souza <jose.souza@intel.com>
>
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
>
> Imre Deak (2):
> drm/i915/icl: Configure MG PHY gating for HDMI ports too
> drm/i915/icl: Configure MG DP mode for HDMI ports too
>
> drivers/gpu/drm/i915/intel_ddi.c | 138
> ++++++++++++++++++++++++++++++++++++++-
> drivers/gpu/drm/i915/intel_dp.c | 132 ---------------------------
> ----------
> drivers/gpu/drm/i915/intel_drv.h | 3 -
> 3 files changed, 137 insertions(+), 136 deletions(-)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
` (4 preceding siblings ...)
2018-11-02 22:47 ` [PATCH 0/2] " Souza, Jose
@ 2018-11-03 0:45 ` Patchwork
2018-11-05 13:42 ` Imre Deak
2018-11-05 14:06 ` ✓ Fi.CI.IGT: success " Patchwork
6 siblings, 1 reply; 13+ messages in thread
From: Patchwork @ 2018-11-03 0:45 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
URL : https://patchwork.freedesktop.org/series/51976/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5081_full -> Patchwork_10716_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10716_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10716_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10716_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_cursor_crc@cursor-64x21-offscreen:
shard-skl: PASS -> INCOMPLETE
==== Warnings ====
igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
shard-snb: SKIP -> PASS +3
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
shard-snb: PASS -> SKIP +1
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10716_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_userptr_blits@readonly-unsync:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-glk: PASS -> DMESG-WARN (fdo#107956)
igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
shard-skl: PASS -> FAIL (fdo#104671)
igt@kms_chv_cursor_fail@pipe-b-64x64-bottom-edge:
shard-kbl: PASS -> DMESG-WARN (fdo#105345)
igt@kms_color@pipe-c-legacy-gamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
shard-skl: NOTRUN -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
shard-skl: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-skl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-skl: INCOMPLETE (fdo#104108) -> PASS
igt@kms_cursor_crc@cursor-128x42-random:
shard-skl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: FAIL (fdo#103166) -> PASS +2
igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
shard-skl: FAIL (fdo#107815) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
igt@pm_rpm@legacy-planes-dpms:
shard-skl: INCOMPLETE (fdo#105959, fdo#107807) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5081 -> Patchwork_10716
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10716: 5862e7326db031964c0da64846806ee65b6e672d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10716/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: ✗ Fi.CI.IGT: failure for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-03 0:45 ` ✗ Fi.CI.IGT: failure for " Patchwork
@ 2018-11-05 13:42 ` Imre Deak
2018-11-05 14:02 ` Imre Deak
2018-11-05 14:06 ` Martin Peres
0 siblings, 2 replies; 13+ messages in thread
From: Imre Deak @ 2018-11-05 13:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Tomi P Sarvela, Martin Peres
On Sat, Nov 03, 2018 at 12:45:01AM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
> URL : https://patchwork.freedesktop.org/series/51976/
> State : failure
The failures are unrelated since all those platforms are without a TypeC
port and the changes have an effect only on TypeC ports. More below.
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_5081_full -> Patchwork_10716_full =
>
> == Summary - FAILURE ==
>
> Serious unknown changes coming with Patchwork_10716_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_10716_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
>
>
> == Possible new issues ==
>
> Here are the unknown changes that may have been introduced in Patchwork_10716_full:
>
> === IGT changes ===
>
> ==== Possible regressions ====
>
> igt@kms_cursor_crc@cursor-64x21-offscreen:
> shard-skl: PASS -> INCOMPLETE
Haven't found anything in the logs, I added a comment about this failure to
https://bugs.freedesktop.org/show_bug.cgi?id=104108
> ==== Warnings ====
>
> igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
> shard-snb: SKIP -> PASS +3
Not sure what this is about, it's a 'SKIP->PASS' and I haven't found any
errors/warnings in the log.
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
> shard-snb: PASS -> SKIP +1
VGA output can't be detected after a system suspend/resume cycle. I
opened a new bug for this:
https://bugs.freedesktop.org/show_bug.cgi?id=108663
>
> igt@perf_pmu@rc6:
> shard-kbl: PASS -> SKIP
GPU doesn't enter RC6, opened a new bug for it:
https://bugs.freedesktop.org/show_bug.cgi?id=108664
>
>
> == Known issues ==
>
> Here are the changes found in Patchwork_10716_full that come from known issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@gem_userptr_blits@readonly-unsync:
> shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
>
> igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
> shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
>
> igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> shard-glk: PASS -> DMESG-WARN (fdo#107956)
>
> igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
> shard-skl: PASS -> FAIL (fdo#104671)
>
> igt@kms_chv_cursor_fail@pipe-b-64x64-bottom-edge:
> shard-kbl: PASS -> DMESG-WARN (fdo#105345)
>
> igt@kms_color@pipe-c-legacy-gamma:
> shard-apl: PASS -> FAIL (fdo#104782)
>
> igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
> shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
> shard-skl: NOTRUN -> FAIL (fdo#103167) +1
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
> shard-apl: PASS -> FAIL (fdo#103167)
>
> igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
> shard-skl: PASS -> FAIL (fdo#107362, fdo#103191)
>
> igt@kms_plane@plane-position-covered-pipe-c-planes:
> shard-apl: PASS -> FAIL (fdo#103166) +1
>
> igt@kms_setmode@basic:
> shard-kbl: PASS -> FAIL (fdo#99912)
>
> igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
> shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
>
>
> ==== Possible fixes ====
>
> igt@kms_busy@extended-modeset-hang-newfb-render-b:
> shard-skl: DMESG-WARN (fdo#107956) -> PASS
>
> igt@kms_cursor_crc@cursor-128x128-suspend:
> shard-skl: INCOMPLETE (fdo#104108) -> PASS
>
> igt@kms_cursor_crc@cursor-128x42-random:
> shard-skl: FAIL (fdo#103232) -> PASS
>
> igt@kms_cursor_crc@cursor-256x256-sliding:
> shard-glk: FAIL (fdo#103232) -> PASS +1
>
> igt@kms_cursor_crc@cursor-256x85-random:
> shard-apl: FAIL (fdo#103232) -> PASS +1
>
> igt@kms_flip@flip-vs-expired-vblank:
> shard-skl: FAIL (fdo#105363) -> PASS
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> shard-glk: FAIL (fdo#103167) -> PASS
>
> igt@kms_plane@plane-position-covered-pipe-b-planes:
> shard-glk: FAIL (fdo#103166) -> PASS +2
>
> igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> shard-skl: FAIL (fdo#107815) -> PASS
>
> igt@kms_setmode@basic:
> shard-apl: FAIL (fdo#99912) -> PASS
>
> igt@pm_rpm@legacy-planes-dpms:
> shard-skl: INCOMPLETE (fdo#105959, fdo#107807) -> PASS
>
>
> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
> fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
> fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
> fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
> fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
> fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
> fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
> fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
> fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
> fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
> fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
> fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
> fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
> fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
> fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
> fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
> fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> == Participating hosts (6 -> 6) ==
>
> No changes in participating hosts
>
>
> == Build changes ==
>
> * Linux: CI_DRM_5081 -> Patchwork_10716
>
> CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_10716: 5862e7326db031964c0da64846806ee65b6e672d @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10716/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-05 13:42 ` Imre Deak
@ 2018-11-05 14:02 ` Imre Deak
2018-11-05 14:06 ` Martin Peres
1 sibling, 0 replies; 13+ messages in thread
From: Imre Deak @ 2018-11-05 14:02 UTC (permalink / raw)
To: intel-gfx, Jose Souza; +Cc: Tomi P Sarvela, Martin Peres
On Mon, Nov 05, 2018 at 03:42:07PM +0200, Imre Deak wrote:
> On Sat, Nov 03, 2018 at 12:45:01AM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
> > URL : https://patchwork.freedesktop.org/series/51976/
> > State : failure
>
> The failures are unrelated since all those platforms are without a TypeC
> port and the changes have an effect only on TypeC ports. More below.
Thanks for the review and testing, pushed both patches to -dinq.
>
> >
> > == Summary ==
> >
> > = CI Bug Log - changes from CI_DRM_5081_full -> Patchwork_10716_full =
> >
> > == Summary - FAILURE ==
> >
> > Serious unknown changes coming with Patchwork_10716_full absolutely need to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the changes
> > introduced in Patchwork_10716_full, please notify your bug team to allow them
> > to document this new failure mode, which will reduce false positives in CI.
> >
> >
> >
> > == Possible new issues ==
> >
> > Here are the unknown changes that may have been introduced in Patchwork_10716_full:
> >
> > === IGT changes ===
> >
> > ==== Possible regressions ====
> >
> > igt@kms_cursor_crc@cursor-64x21-offscreen:
> > shard-skl: PASS -> INCOMPLETE
>
> Haven't found anything in the logs, I added a comment about this failure to
> https://bugs.freedesktop.org/show_bug.cgi?id=104108
>
> > ==== Warnings ====
> >
> > igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
> > shard-snb: SKIP -> PASS +3
>
> Not sure what this is about, it's a 'SKIP->PASS' and I haven't found any
> errors/warnings in the log.
>
> >
> > igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
> > shard-snb: PASS -> SKIP +1
>
> VGA output can't be detected after a system suspend/resume cycle. I
> opened a new bug for this:
> https://bugs.freedesktop.org/show_bug.cgi?id=108663
>
> >
> > igt@perf_pmu@rc6:
> > shard-kbl: PASS -> SKIP
>
> GPU doesn't enter RC6, opened a new bug for it:
> https://bugs.freedesktop.org/show_bug.cgi?id=108664
>
> >
> >
> > == Known issues ==
> >
> > Here are the changes found in Patchwork_10716_full that come from known issues:
> >
> > === IGT changes ===
> >
> > ==== Issues hit ====
> >
> > igt@gem_userptr_blits@readonly-unsync:
> > shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
> >
> > igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
> > shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
> >
> > igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > shard-glk: PASS -> DMESG-WARN (fdo#107956)
> >
> > igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
> > shard-skl: PASS -> FAIL (fdo#104671)
> >
> > igt@kms_chv_cursor_fail@pipe-b-64x64-bottom-edge:
> > shard-kbl: PASS -> DMESG-WARN (fdo#105345)
> >
> > igt@kms_color@pipe-c-legacy-gamma:
> > shard-apl: PASS -> FAIL (fdo#104782)
> >
> > igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
> > shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
> >
> > igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
> > shard-skl: NOTRUN -> FAIL (fdo#103167) +1
> >
> > igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
> > shard-apl: PASS -> FAIL (fdo#103167)
> >
> > igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
> > shard-skl: PASS -> FAIL (fdo#107362, fdo#103191)
> >
> > igt@kms_plane@plane-position-covered-pipe-c-planes:
> > shard-apl: PASS -> FAIL (fdo#103166) +1
> >
> > igt@kms_setmode@basic:
> > shard-kbl: PASS -> FAIL (fdo#99912)
> >
> > igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
> > shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
> >
> >
> > ==== Possible fixes ====
> >
> > igt@kms_busy@extended-modeset-hang-newfb-render-b:
> > shard-skl: DMESG-WARN (fdo#107956) -> PASS
> >
> > igt@kms_cursor_crc@cursor-128x128-suspend:
> > shard-skl: INCOMPLETE (fdo#104108) -> PASS
> >
> > igt@kms_cursor_crc@cursor-128x42-random:
> > shard-skl: FAIL (fdo#103232) -> PASS
> >
> > igt@kms_cursor_crc@cursor-256x256-sliding:
> > shard-glk: FAIL (fdo#103232) -> PASS +1
> >
> > igt@kms_cursor_crc@cursor-256x85-random:
> > shard-apl: FAIL (fdo#103232) -> PASS +1
> >
> > igt@kms_flip@flip-vs-expired-vblank:
> > shard-skl: FAIL (fdo#105363) -> PASS
> >
> > igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > shard-glk: FAIL (fdo#103167) -> PASS
> >
> > igt@kms_plane@plane-position-covered-pipe-b-planes:
> > shard-glk: FAIL (fdo#103166) -> PASS +2
> >
> > igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> > shard-skl: FAIL (fdo#107815) -> PASS
> >
> > igt@kms_setmode@basic:
> > shard-apl: FAIL (fdo#99912) -> PASS
> >
> > igt@pm_rpm@legacy-planes-dpms:
> > shard-skl: INCOMPLETE (fdo#105959, fdo#107807) -> PASS
> >
> >
> > fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
> > fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
> > fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
> > fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
> > fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
> > fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
> > fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
> > fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
> > fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
> > fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
> > fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
> > fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
> > fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
> > fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
> > fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
> >
> >
> > == Participating hosts (6 -> 6) ==
> >
> > No changes in participating hosts
> >
> >
> > == Build changes ==
> >
> > * Linux: CI_DRM_5081 -> Patchwork_10716
> >
> > CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > Patchwork_10716: 5862e7326db031964c0da64846806ee65b6e672d @ git://anongit.freedesktop.org/gfx-ci/linux
> > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10716/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-05 13:42 ` Imre Deak
2018-11-05 14:02 ` Imre Deak
@ 2018-11-05 14:06 ` Martin Peres
1 sibling, 0 replies; 13+ messages in thread
From: Martin Peres @ 2018-11-05 14:06 UTC (permalink / raw)
To: imre.deak, intel-gfx; +Cc: Tomi P Sarvela
On 05/11/2018 15:42, Imre Deak wrote:
> On Sat, Nov 03, 2018 at 12:45:01AM +0000, Patchwork wrote:
>> == Series Details ==
>>
>> Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
>> URL : https://patchwork.freedesktop.org/series/51976/
>> State : failure
>
> The failures are unrelated since all those platforms are without a TypeC
> port and the changes have an effect only on TypeC ports. More below.
>
>>
>> == Summary ==
>>
>> = CI Bug Log - changes from CI_DRM_5081_full -> Patchwork_10716_full =
>>
>> == Summary - FAILURE ==
>>
>> Serious unknown changes coming with Patchwork_10716_full absolutely need to be
>> verified manually.
>>
>> If you think the reported changes have nothing to do with the changes
>> introduced in Patchwork_10716_full, please notify your bug team to allow them
>> to document this new failure mode, which will reduce false positives in CI.
>>
>>
>>
>> == Possible new issues ==
>>
>> Here are the unknown changes that may have been introduced in Patchwork_10716_full:
>>
>> === IGT changes ===
>>
>> ==== Possible regressions ====
>>
>> igt@kms_cursor_crc@cursor-64x21-offscreen:
>> shard-skl: PASS -> INCOMPLETE
>
> Haven't found anything in the logs, I added a comment about this failure to
> https://bugs.freedesktop.org/show_bug.cgi?id=104108
Thanks, I changed the filing in the cibuglog.
Re-reported and it is a success now :)
>
>> ==== Warnings ====
>>
>> igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
>> shard-snb: SKIP -> PASS +3
>
> Not sure what this is about, it's a 'SKIP->PASS' and I haven't found any
> errors/warnings in the log.
Ignore these, we are not filing bugs for these yet.
>
>>
>> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
>> shard-snb: PASS -> SKIP +1
>
> VGA output can't be detected after a system suspend/resume cycle. I
> opened a new bug for this:
> https://bugs.freedesktop.org/show_bug.cgi?id=108663
>
>>
>> igt@perf_pmu@rc6:
>> shard-kbl: PASS -> SKIP
>
> GPU doesn't enter RC6, opened a new bug for it:
> https://bugs.freedesktop.org/show_bug.cgi?id=108664
>
>>
>>
>> == Known issues ==
>>
>> Here are the changes found in Patchwork_10716_full that come from known issues:
>>
>> === IGT changes ===
>>
>> ==== Issues hit ====
>>
>> igt@gem_userptr_blits@readonly-unsync:
>> shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
>>
>> igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
>> shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
>>
>> igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
>> shard-glk: PASS -> DMESG-WARN (fdo#107956)
>>
>> igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
>> shard-skl: PASS -> FAIL (fdo#104671)
>>
>> igt@kms_chv_cursor_fail@pipe-b-64x64-bottom-edge:
>> shard-kbl: PASS -> DMESG-WARN (fdo#105345)
>>
>> igt@kms_color@pipe-c-legacy-gamma:
>> shard-apl: PASS -> FAIL (fdo#104782)
>>
>> igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
>> shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
>>
>> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
>> shard-skl: NOTRUN -> FAIL (fdo#103167) +1
>>
>> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
>> shard-apl: PASS -> FAIL (fdo#103167)
>>
>> igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
>> shard-skl: PASS -> FAIL (fdo#107362, fdo#103191)
>>
>> igt@kms_plane@plane-position-covered-pipe-c-planes:
>> shard-apl: PASS -> FAIL (fdo#103166) +1
>>
>> igt@kms_setmode@basic:
>> shard-kbl: PASS -> FAIL (fdo#99912)
>>
>> igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
>> shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
>>
>>
>> ==== Possible fixes ====
>>
>> igt@kms_busy@extended-modeset-hang-newfb-render-b:
>> shard-skl: DMESG-WARN (fdo#107956) -> PASS
>>
>> igt@kms_cursor_crc@cursor-128x128-suspend:
>> shard-skl: INCOMPLETE (fdo#104108) -> PASS
>>
>> igt@kms_cursor_crc@cursor-128x42-random:
>> shard-skl: FAIL (fdo#103232) -> PASS
>>
>> igt@kms_cursor_crc@cursor-256x256-sliding:
>> shard-glk: FAIL (fdo#103232) -> PASS +1
>>
>> igt@kms_cursor_crc@cursor-256x85-random:
>> shard-apl: FAIL (fdo#103232) -> PASS +1
>>
>> igt@kms_flip@flip-vs-expired-vblank:
>> shard-skl: FAIL (fdo#105363) -> PASS
>>
>> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>> shard-glk: FAIL (fdo#103167) -> PASS
>>
>> igt@kms_plane@plane-position-covered-pipe-b-planes:
>> shard-glk: FAIL (fdo#103166) -> PASS +2
>>
>> igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>> shard-skl: FAIL (fdo#107815) -> PASS
>>
>> igt@kms_setmode@basic:
>> shard-apl: FAIL (fdo#99912) -> PASS
>>
>> igt@pm_rpm@legacy-planes-dpms:
>> shard-skl: INCOMPLETE (fdo#105959, fdo#107807) -> PASS
>>
>>
>> fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
>> fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
>> fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
>> fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
>> fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
>> fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
>> fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
>> fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
>> fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
>> fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
>> fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
>> fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
>> fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
>> fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
>> fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
>> fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
>> fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
>> fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
>> fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
>>
>>
>> == Participating hosts (6 -> 6) ==
>>
>> No changes in participating hosts
>>
>>
>> == Build changes ==
>>
>> * Linux: CI_DRM_5081 -> Patchwork_10716
>>
>> CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
>> IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>> Patchwork_10716: 5862e7326db031964c0da64846806ee65b6e672d @ git://anongit.freedesktop.org/gfx-ci/linux
>> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>>
>> == Logs ==
>>
>> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10716/shards.html
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/icl: Fix suspend/resume for TypeC HDMI
2018-11-02 19:26 [PATCH 0/2] drm/i915/icl: Fix suspend/resume for TypeC HDMI Imre Deak
` (5 preceding siblings ...)
2018-11-03 0:45 ` ✗ Fi.CI.IGT: failure for " Patchwork
@ 2018-11-05 14:06 ` Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2018-11-05 14:06 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
URL : https://patchwork.freedesktop.org/series/51976/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5081_full -> Patchwork_10716_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10716_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10716_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10716_full:
=== IGT changes ===
==== Warnings ====
igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
shard-snb: SKIP -> PASS +3
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
shard-snb: PASS -> SKIP +1
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10716_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_userptr_blits@readonly-unsync:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-glk: PASS -> DMESG-WARN (fdo#107956)
igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
shard-skl: PASS -> FAIL (fdo#104671)
igt@kms_chv_cursor_fail@pipe-b-64x64-bottom-edge:
shard-kbl: PASS -> DMESG-WARN (fdo#105345)
igt@kms_color@pipe-c-legacy-gamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-64x21-offscreen:
shard-skl: PASS -> INCOMPLETE (fdo#104108)
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
shard-skl: NOTRUN -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
shard-skl: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#104108, fdo#107773)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-skl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-skl: INCOMPLETE (fdo#104108) -> PASS
igt@kms_cursor_crc@cursor-128x42-random:
shard-skl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: FAIL (fdo#103166) -> PASS +2
igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
shard-skl: FAIL (fdo#107815) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
igt@pm_rpm@legacy-planes-dpms:
shard-skl: INCOMPLETE (fdo#107807, fdo#105959) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5081 -> Patchwork_10716
CI_DRM_5081: f5e16acf6c85d38756c3efdb77ec6aede55df0ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4705: 7983e19ed62ec8db1884f55e07e458a62cc51e37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10716: 5862e7326db031964c0da64846806ee65b6e672d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10716/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread