[PATCH] staging: greybus: cleanup long line in gb_uart_probe()

[PATCH] staging: greybus: cleanup long line in gb_uart_probe()

[Ioannis Valasakis]

Clear line over 80 characters warning in gb_uart_probe() by adding
appropriate lines breaks.
Reported by checkpatch

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index b3bffe91ae99..735f70c09823 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 	if (!gb_tty)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
+	connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
+					 (gbphy_dev->cport_desc->id),
 					  gb_uart_request_handler);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);
-- 
2.19.1


-- 
ta
ioannis

Re: [Outreachy kernel] [PATCH] staging: greybus: cleanup long line in gb_uart_probe()

[Julia Lawall]

On Fri, 2 Nov 2018, Ioannis Valasakis wrote:

> Clear line over 80 characters warning in gb_uart_probe() by adding
> appropriate lines breaks.
> Reported by checkpatch
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/uart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index b3bffe91ae99..735f70c09823 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
>  	if (!gb_tty)
>  		return -ENOMEM;
>
> -	connection = gb_connection_create(gbphy_dev->bundle,
> -					  le16_to_cpu(gbphy_dev->cport_desc->id),
> +	connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
> +					 (gbphy_dev->cport_desc->id),

This really hides the structure of the code.  You can just reduce the
indentation in front of the call and then line the remaining argument up
with that.

julia

>  					  gb_uart_request_handler);
>  	if (IS_ERR(connection)) {
>  		retval = PTR_ERR(connection);
> --
> 2.19.1
>
>
> --
> ta
> ioannis
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102232501.GA1571%40kvasir.local.
> For more options, visit https://groups.google.com/d/optout.
>