From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: skx_edac: add ACPI dependency
Date: Sat, 3 Nov 2018 00:42:55 +0100 [thread overview]
Message-ID: <20181102234255.GE26770@zn.tnic> (raw)
In-Reply-To: <20181102173959.GA27709@agluck-desk>
On Fri, Nov 02, 2018 at 10:39:59AM -0700, Luck, Tony wrote:
> On Fri, Nov 02, 2018 at 05:10:13PM +0100, Borislav Petkov wrote:
> > On Fri, Nov 02, 2018 at 04:32:06PM +0100, Arnd Bergmann wrote:
> > > We cannot currently select ACPI_ADXL without also enabling the top-level
> > > ACPI option:
> > >
> > > WARNING: unmet direct dependencies detected for ACPI_ADXL
> > > Depends on [n]: ACPI [=n]
> > > Selected by [y]:
> > > - EDAC_SKX [=y] && EDAC [=y] && PCI [=y] && X86_64 [=y] && X86_MCE_INTEL [=y] && PCI_MMCONFIG [=y] && (ACPI_NFIT [=n] || !ACPI_NFIT [=n])
> >
> > That should fix the issue too:
> >
> > https://marc.info/?l=linux-acpi&m=154102117706500&w=2
>
> I have to say that Arnd's fix is prettier. With it, we can go back
> to
>
> select ACPI_ADXL
>
> instead of
>
> select ACPI_ADXL if ACPI
Arnd's fix already has that last line in there:
config EDAC_SKX
tristate "Intel Skylake server Integrated MC"
- depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
+ depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG && ACPI
depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y
select DMI
select ACPI_ADXL if ACPI
^^^^^^^^^^^^^^^^^^^^^^^^
so I'm reading this as *additionally* needed, ontop of the ugly fix.
But let's wait until he clarifies first.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: EDAC: skx_edac: add ACPI dependency
Date: Sat, 3 Nov 2018 00:42:55 +0100 [thread overview]
Message-ID: <20181102234255.GE26770@zn.tnic> (raw)
On Fri, Nov 02, 2018 at 10:39:59AM -0700, Luck, Tony wrote:
> On Fri, Nov 02, 2018 at 05:10:13PM +0100, Borislav Petkov wrote:
> > On Fri, Nov 02, 2018 at 04:32:06PM +0100, Arnd Bergmann wrote:
> > > We cannot currently select ACPI_ADXL without also enabling the top-level
> > > ACPI option:
> > >
> > > WARNING: unmet direct dependencies detected for ACPI_ADXL
> > > Depends on [n]: ACPI [=n]
> > > Selected by [y]:
> > > - EDAC_SKX [=y] && EDAC [=y] && PCI [=y] && X86_64 [=y] && X86_MCE_INTEL [=y] && PCI_MMCONFIG [=y] && (ACPI_NFIT [=n] || !ACPI_NFIT [=n])
> >
> > That should fix the issue too:
> >
> > https://marc.info/?l=linux-acpi&m=154102117706500&w=2
>
> I have to say that Arnd's fix is prettier. With it, we can go back
> to
>
> select ACPI_ADXL
>
> instead of
>
> select ACPI_ADXL if ACPI
Arnd's fix already has that last line in there:
config EDAC_SKX
tristate "Intel Skylake server Integrated MC"
- depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
+ depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG && ACPI
depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y
select DMI
select ACPI_ADXL if ACPI
^^^^^^^^^^^^^^^^^^^^^^^^
so I'm reading this as *additionally* needed, ontop of the ugly fix.
But let's wait until he clarifies first.
next prev parent reply other threads:[~2018-11-02 23:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 15:32 [PATCH] EDAC: skx_edac: add ACPI dependency Arnd Bergmann
2018-11-02 15:32 ` Arnd Bergmann
2018-11-02 16:10 ` [PATCH] " Borislav Petkov
2018-11-02 16:10 ` Borislav Petkov
2018-11-02 17:39 ` [PATCH] " Luck, Tony
2018-11-02 17:39 ` Luck, Tony
2018-11-02 23:42 ` Borislav Petkov [this message]
2018-11-02 23:42 ` Borislav Petkov
2018-11-06 13:44 ` [PATCH] " Arnd Bergmann
2018-11-06 13:44 ` Arnd Bergmann
2018-11-06 14:32 ` [PATCH] " Borislav Petkov
2018-11-06 14:32 ` Borislav Petkov
2018-11-06 18:39 ` [PATCH] EDAC, skx: Better fix for randconfig builds Luck, Tony
2018-11-06 18:39 ` Luck, Tony
2018-11-07 22:03 ` [PATCH] " Borislav Petkov
2018-11-07 22:03 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102234255.GE26770@zn.tnic \
--to=bp@alien8.de \
--cc=arnd@arndb.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.