[Buildroot] [PATCH] package/libid3tag: add .pc file and install to staging hook

[Buildroot] [PATCH] package/libid3tag: add .pc file and install to staging hook

[Jörg Krause]

Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 package/libid3tag/id3tag.pc    | 11 +++++++++++
 package/libid3tag/libid3tag.mk |  7 +++++++
 2 files changed, 18 insertions(+)
 create mode 100644 package/libid3tag/id3tag.pc

diff --git a/package/libid3tag/id3tag.pc b/package/libid3tag/id3tag.pc
new file mode 100644
index 0000000000..845eb3276b
--- /dev/null
+++ b/package/libid3tag/id3tag.pc
@@ -0,0 +1,11 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: id3tag
+Description: ID3 tag reading library
+Version: 0.15.1b
+Requires:
+Libs: -L${libdir} -lid3tag
+Cflags: -I${includedir}
diff --git a/package/libid3tag/libid3tag.mk b/package/libid3tag/libid3tag.mk
index 951ae09c77..24342186cc 100644
--- a/package/libid3tag/libid3tag.mk
+++ b/package/libid3tag/libid3tag.mk
@@ -12,4 +12,11 @@ LIBID3TAG_INSTALL_STAGING = YES
 LIBID3TAG_DEPENDENCIES = zlib
 LIBID3TAG_LIBTOOL_PATCH = NO
 
+define LIBID3TAG_INSTALL_STAGING_PC
+	$(INSTALL) -D package/libid3tag/id3tag.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/id3tag.pc
+endef
+
+LIBID3TAG_POST_INSTALL_STAGING_HOOKS += LIBID3TAG_INSTALL_STAGING_PC
+
 $(eval $(autotools-package))
-- 
2.19.1

[Buildroot] [PATCH] package/libid3tag: add .pc file and install to staging hook

[Thomas Petazzoni]

Hello,

On Mon,  5 Nov 2018 07:29:26 +0100, J?rg Krause wrote:
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>

This probably needs a non-empty commit log. What is the motivation for
adding a .pc file ? Is it used by some other package in Buildroot ? By
a private application/library ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/libid3tag: add .pc file and install to staging hook

[Jörg Krause]

On Mon, 2018-11-05 at 09:18 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon,  5 Nov 2018 07:29:26 +0100, J?rg Krause wrote:
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> 
> This probably needs a non-empty commit log. What is the motivation for
> adding a .pc file ? Is it used by some other package in Buildroot ? By
> a private application/library ?

Sorry for being lazy :-) Thought it is a trivial change...

I am porting the mpd 0.21 release to the meson build system. It uses
pkg-config for detecting libid3tag and fails, because of the missing
.pc file.

Shall I send a v2 with a non-empty commit log?

J?rg