All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Stable tree <stable@vger.kernel.org>
Subject: Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages
Date: Mon, 5 Nov 2018 10:35:50 +0100	[thread overview]
Message-ID: <20181105093550.GE4361@dhcp22.suse.cz> (raw)
In-Reply-To: <20181105092618.GI27491@MiWiFi-R3L-srv>

On Mon 05-11-18 17:26:18, Baoquan He wrote:
[...]
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index a919ba5..021e39d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7824,7 +7824,8 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count,
>                 if (__PageMovable(page))
>                         continue;
> 
> -               if (!PageLRU(page))
> +               if (!PageLRU(page) &&
> +                       (get_pageblock_migratetype(page) != MIGRATE_MOVABLE))
>                         found++;
>                 /*
>                  * If there are RECLAIMABLE pages, we need to check

As explained during the private conversion I am not really thrilled by
this check. AFAIU this will be the case for basically all pages in the
zone_movable. As we have seen already some unexpected ones can lurk in
easily.

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2018-11-05  9:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  9:10 Memory hotplug failed to offline on bare metal system of multiple nodes Baoquan He
2018-11-01  9:10 ` Baoquan He
2018-11-01  9:22 ` Michal Hocko
2018-11-01  9:42   ` Baoquan He
2018-11-01  9:58     ` Michal Hocko
2018-11-02 15:55 ` [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages Michal Hocko
2018-11-02 15:55   ` Michal Hocko
2018-11-05  0:20   ` Baoquan He
2018-11-05  9:14     ` Michal Hocko
2018-11-05  9:26       ` Baoquan He
2018-11-05  9:35         ` Michal Hocko [this message]
2018-11-05  9:28       ` Michal Hocko
2018-11-05  9:45         ` Baoquan He
2018-11-05 10:25         ` Baoquan He
2018-11-05 12:38           ` Michal Hocko
2018-11-05 12:38             ` Michal Hocko
2018-11-05 12:38             ` Michal Hocko
2018-11-05 14:23             ` Baoquan He
2018-11-05 17:10               ` Michal Hocko
2018-11-06  0:22                 ` Baoquan He
2018-11-06  8:28                   ` Michal Hocko
2018-11-06  9:16                     ` Baoquan He
2018-11-06  9:36                       ` Baoquan He
2018-11-06  9:51                       ` Michal Hocko
2018-11-06 10:00                         ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105093550.GE4361@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.