Segmentation error 6 in rt_heap_create() without --enable-pshared

Segmentation error 6 in rt_heap_create() without --enable-pshared

[Petr Červenka]

Hello.
I'm continuing to test newest Xenomai (git clone).
If I configure Xenomai without --enable-pshared, I will always get an segmentation error 6 in rt_heap_create() call. It doesn't matter, if I use NULL as heap name or not.
With --enable-pshared everything works fine.
Petr

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Jan Kiszka]

On 05.11.18 12:06, Petr Červenka via Xenomai wrote:
> Hello.
> I'm continuing to test newest Xenomai (git clone).
> If I configure Xenomai without --enable-pshared, I will always get an segmentation error 6 in rt_heap_create() call. It doesn't matter, if I use NULL as heap name or not.
> With --enable-pshared everything works fine.

stable or master (or both)?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Petr Červenka]

> 
> stable or master (or both)?
 > 
 > Jan
 >
 
master
 

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Jan Kiszka]

On 05.11.18 14:31, Petr Červenka wrote:
>>
>> stable or master (or both)?
>  > 
>  > Jan
>  >
>  
> master
>  

Only? Sorry for insisting, but it may help to reduce the search space, and it's
also important as I'd like to release a new stable version - without known issues.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Petr Červenka]

> Only? Sorry for insisting, but it may help to reduce the search space, and it's
> also important as I'd like to release a new stable version - without known issues.
 > 
> Thanks,
 > Jan
 
Sorry. I tried only master branch and there was the error.
I will try also the stable/v3.0.x branch, but it will take me some time.
Petr

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Petr Červenka]

> Only? Sorry for insisting, but it may help to reduce the search space, and it's
> also important as I'd like to release a new stable version - without known issues.
 > 
> Thanks,
> Jan
 >
 
I can confirm now, that the problem happens only with the master branch.
Petr

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Jan Kiszka]

On 05.11.18 16:48, Petr Červenka wrote:
>> Only? Sorry for insisting, but it may help to reduce the search space, and it's
>> also important as I'd like to release a new stable version - without known issues.
>  > 
>> Thanks,
>> Jan
>  >
>  
> I can confirm now, that the problem happens only with the master branch.
> Petr
> 

Thanks. Philippe, any idea?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Henning Schild]

Am Thu, 8 Nov 2018 10:17:44 +0100
schrieb Philippe Gerum <rpm@xenomai.org>:

> On 11/7/18 4:09 PM, Henning Schild wrote:
> > Am Wed, 7 Nov 2018 14:31:10 +0100
> > schrieb Philippe Gerum <rpm@xenomai.org>:
> >   
> >> On 11/7/18 2:00 PM, Henning Schild via Xenomai wrote:  
> >>> Readding list ...
> >>>     
> >>
> >> Does this help?
> >>
> >> diff --git a/lib/copperplate/heapobj-heapmem.c
> >> b/lib/copperplate/heapobj-heapmem.c index 5c0ce9b2d..124fe564a
> >> 100644 --- a/lib/copperplate/heapobj-heapmem.c
> >> +++ b/lib/copperplate/heapobj-heapmem.c
> >> @@ -33,8 +33,8 @@ int __heapobj_init_private(struct heapobj *hobj,
> >> const char *name, int ret;
> >>  
> >>  	if (mem == NULL) {
> >> -		_mem = __STD(malloc(size));
> >> -		if (_mem == NULL)
> >> +		mem = __STD(malloc(size));
> >> +		if (mem == NULL)
> >>  			return -ENOMEM;
> >>  	}
> >>  	
> >> @@ -43,16 +43,16 @@ int __heapobj_init_private(struct heapobj
> >> *hobj, const char *name, else
> >>  		snprintf(hobj->name, sizeof(hobj->name), "%p",
> >> hobj); 
> >> -	ret = heapmem_init(hobj->pool, _mem, size);
> >> +	hobj->pool = mem;
> >> +	hobj->size = size;
> >> +
> >> +	ret = heapmem_init(hobj->pool, mem, size);  
> > 
> > ret = -EINVAL  
> 
> Part of the solution in this patch (on top of the previous one), but
> more changes are needed for a complete fix:

Ok, that helps. Can you prepare a patch?

Henning

> diff --git a/lib/copperplate/heapobj-heapmem.c
> b/lib/copperplate/heapobj-heapmem.c index 124fe564a..3961bd054 100644
> --- a/lib/copperplate/heapobj-heapmem.c
> +++ b/lib/copperplate/heapobj-heapmem.c
> @@ -33,6 +33,7 @@ int __heapobj_init_private(struct heapobj *hobj,
> const char *name, int ret;
>  
>  	if (mem == NULL) {
> +		size = HEAPMEM_ARENA_SIZE(size); /* Count meta-data
> in. */ mem = __STD(malloc(size));
>  		if (mem == NULL)
>  			return -ENOMEM;
> @@ -60,7 +61,7 @@ int heapobj_init_array_private(struct heapobj
> *hobj, const char *name, size_t size, int elems)
>  {
>  	return __bt(__heapobj_init_private(hobj, name,
> -			   HEAPMEM_ARENA_SIZE(size * elems), NULL));
> +					   size * elems, NULL));
>  }
>  
>  int heapobj_pkg_init_private(void)
> 

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Philippe Gerum]

On 11/7/18 4:09 PM, Henning Schild wrote:
> Am Wed, 7 Nov 2018 14:31:10 +0100
> schrieb Philippe Gerum <rpm@xenomai.org>:
> 
>> On 11/7/18 2:00 PM, Henning Schild via Xenomai wrote:
>>> Readding list ...
>>>   
>>
>> Does this help?
>>
>> diff --git a/lib/copperplate/heapobj-heapmem.c
>> b/lib/copperplate/heapobj-heapmem.c index 5c0ce9b2d..124fe564a 100644
>> --- a/lib/copperplate/heapobj-heapmem.c
>> +++ b/lib/copperplate/heapobj-heapmem.c
>> @@ -33,8 +33,8 @@ int __heapobj_init_private(struct heapobj *hobj,
>> const char *name, int ret;
>>  
>>  	if (mem == NULL) {
>> -		_mem = __STD(malloc(size));
>> -		if (_mem == NULL)
>> +		mem = __STD(malloc(size));
>> +		if (mem == NULL)
>>  			return -ENOMEM;
>>  	}
>>  	
>> @@ -43,16 +43,16 @@ int __heapobj_init_private(struct heapobj *hobj,
>> const char *name, else
>>  		snprintf(hobj->name, sizeof(hobj->name), "%p", hobj);
>>  
>> -	ret = heapmem_init(hobj->pool, _mem, size);
>> +	hobj->pool = mem;
>> +	hobj->size = size;
>> +
>> +	ret = heapmem_init(hobj->pool, mem, size);
> 
> ret = -EINVAL

Part of the solution in this patch (on top of the previous one), but more changes are needed for a complete fix:

diff --git a/lib/copperplate/heapobj-heapmem.c b/lib/copperplate/heapobj-heapmem.c
index 124fe564a..3961bd054 100644
--- a/lib/copperplate/heapobj-heapmem.c
+++ b/lib/copperplate/heapobj-heapmem.c
@@ -33,6 +33,7 @@ int __heapobj_init_private(struct heapobj *hobj, const char *name,
 	int ret;
 
 	if (mem == NULL) {
+		size = HEAPMEM_ARENA_SIZE(size); /* Count meta-data in. */
 		mem = __STD(malloc(size));
 		if (mem == NULL)
 			return -ENOMEM;
@@ -60,7 +61,7 @@ int heapobj_init_array_private(struct heapobj *hobj, const char *name,
 			       size_t size, int elems)
 {
 	return __bt(__heapobj_init_private(hobj, name,
-			   HEAPMEM_ARENA_SIZE(size * elems), NULL));
+					   size * elems, NULL));
 }
 
 int heapobj_pkg_init_private(void)

-- 
Philippe.

Re: Segmentation error 6 in rt_heap_create() without --enable-pshared

[Henning Schild]

Am Wed, 7 Nov 2018 14:31:10 +0100
schrieb Philippe Gerum <rpm@xenomai.org>:

> On 11/7/18 2:00 PM, Henning Schild via Xenomai wrote:
> > Readding list ...
> >   
> 
> Does this help?
> 
> diff --git a/lib/copperplate/heapobj-heapmem.c
> b/lib/copperplate/heapobj-heapmem.c index 5c0ce9b2d..124fe564a 100644
> --- a/lib/copperplate/heapobj-heapmem.c
> +++ b/lib/copperplate/heapobj-heapmem.c
> @@ -33,8 +33,8 @@ int __heapobj_init_private(struct heapobj *hobj,
> const char *name, int ret;
>  
>  	if (mem == NULL) {
> -		_mem = __STD(malloc(size));
> -		if (_mem == NULL)
> +		mem = __STD(malloc(size));
> +		if (mem == NULL)
>  			return -ENOMEM;
>  	}
>  	
> @@ -43,16 +43,16 @@ int __heapobj_init_private(struct heapobj *hobj,
> const char *name, else
>  		snprintf(hobj->name, sizeof(hobj->name), "%p", hobj);
>  
> -	ret = heapmem_init(hobj->pool, _mem, size);
> +	hobj->pool = mem;
> +	hobj->size = size;
> +
> +	ret = heapmem_init(hobj->pool, mem, size);

ret = -EINVAL

Henning

>  	if (ret) {
> -		if (mem == NULL)
> -			__STD(free(_mem));
> +		if (_mem == NULL)
> +			__STD(free(mem));
>  		return ret;
>  	}
>  
> -	hobj->pool = _mem;
> -	hobj->size = size;
> -
>  	return 0;
>  }
>