From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Biju Das <biju.das@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
Date: Tue, 6 Nov 2018 13:25:25 +0100 [thread overview]
Message-ID: <20181106122524.hlcgcgetunlp563w@verge.net.au> (raw)
In-Reply-To: <CAMuHMdX0rQFn330ZhOOs0tA91+oYfVxND9g1kkizgfMeA3UxPA@mail.gmail.com>
On Tue, Nov 06, 2018 at 11:18:14AM +0100, Geert Uytterhoeven wrote:
> Hi Biju,
>
> On Fri, Oct 26, 2018 at 11:40 AM Biju Das <biju.das@bp.renesas.com> wrote:
> > This patch adds watchdog support to the r8a77470 SoC dtsi.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r8a77470.dtsi
> > +++ b/arch/arm/boot/dts/r8a77470.dtsi
> > @@ -196,6 +196,16 @@
> > reg = <0 0xe6160000 0 0x100>;
> > };
> >
> > + rwdt: watchdog@e6020000 {
>
> Please follow the sort order rules:
> - By unit-address (if present), per group,
> - Alphabetically.
Thanks for noticing.
As I had already applied this patch I took the liberty of updating
it to preserve node sort order. The updates patch is as follows:
From: Biju Das <biju.das@bp.renesas.com>
Date: Fri, 26 Oct 2018 10:32:26 +0100
Subject: [PATCH] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
This patch adds watchdog support to the r8a77470 SoC dtsi.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
[simon: moved node to preserve sort order]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a77470.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 6ac7f467065e..a703b74cc1f9 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -79,6 +79,16 @@
#size-cells = <2>;
ranges;
+ rwdt: watchdog@e6020000 {
+ compatible = "renesas,r8a77470-wdt",
+ "renesas,rcar-gen2-wdt";
+ reg = <0 0xe6020000 0 0x0c>;
+ clocks = <&cpg CPG_MOD 402>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 402>;
+ status = "disabled";
+ };
+
gpio0: gpio@e6050000 {
compatible = "renesas,gpio-r8a77470",
"renesas,rcar-gen2-gpio";
--
2.11.0
prev parent reply other threads:[~2018-11-06 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 9:32 [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Biju Das
2018-10-26 9:32 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Enable watchdog support Biju Das
2018-10-26 9:42 ` Fabrizio Castro
2018-10-26 9:42 ` Fabrizio Castro
2018-10-29 16:14 ` Simon Horman
2018-10-26 9:42 ` [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi Fabrizio Castro
2018-10-26 9:42 ` Fabrizio Castro
2018-10-29 16:13 ` Simon Horman
2018-11-06 10:18 ` Geert Uytterhoeven
2018-11-06 12:25 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106122524.hlcgcgetunlp563w@verge.net.au \
--to=horms@verge.net.au \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.